2007-08-30 13:14:42

by John W. Linville

[permalink] [raw]
Subject: Re: [PATCH 3/5] Net: ath5k, use int as retval

On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote:
> ath5k, use int as retval
>
> Convert some functions to return int and proper negative return value on
> error as we are used to.

Since I didn't apply 1/5, this one didn't apply either. It seems
fine overall, so if you rediff I'll be happy to apply.

John
--
John W. Linville
[email protected]


2007-09-03 13:37:44

by Nick Kossifidis

[permalink] [raw]
Subject: Re: [PATCH 3/5] Net: ath5k, use int as retval

2007/9/3, Jiri Slaby <[email protected]>:
> Nick Kossifidis napsal(a):
> > 2007/9/1, Jiri Slaby <[email protected]>:
> >> John W. Linville napsal(a):
> >>> On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote:
> >>>> ath5k, use int as retval
> >>>>
> >>>> Convert some functions to return int and proper negative return value on
> >>>> error as we are used to.
> >>> Since I didn't apply 1/5, this one didn't apply either. It seems
> >>> fine overall, so if you rediff I'll be happy to apply.
> >> Ok, I'll do it, thanks,
> >
> > Can somebody commit my resent changes from madwifi-svn (cleanups,
> > kconfig, remove_hw_ from filenames etc) ? I don't have git repository
> > ;-(
>
> Resent to where? Or what do you mean?
>

I mean commit changes from current madwifi-svn's ath5k branch on the
list to be included on wireless-dev too. Have you sent r2697 and later
? I can't work against current wireless-dev because my laptop doesn't
even boot with it (there is a discussion on lkml about it they changed
something on 2.6.23).


--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

2007-09-01 20:39:42

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH 3/5] Net: ath5k, use int as retval

John W. Linville napsal(a):
> On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote:
>> ath5k, use int as retval
>>
>> Convert some functions to return int and proper negative return value on
>> error as we are used to.
>
> Since I didn't apply 1/5, this one didn't apply either. It seems
> fine overall, so if you rediff I'll be happy to apply.

Ok, I'll do it, thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz


2007-09-03 06:33:19

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH 3/5] Net: ath5k, use int as retval

Nick Kossifidis napsal(a):
> 2007/9/1, Jiri Slaby <[email protected]>:
>> John W. Linville napsal(a):
>>> On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote:
>>>> ath5k, use int as retval
>>>>
>>>> Convert some functions to return int and proper negative return value on
>>>> error as we are used to.
>>> Since I didn't apply 1/5, this one didn't apply either. It seems
>>> fine overall, so if you rediff I'll be happy to apply.
>> Ok, I'll do it, thanks,
>
> Can somebody commit my resent changes from madwifi-svn (cleanups,
> kconfig, remove_hw_ from filenames etc) ? I don't have git repository
> ;-(

Resent to where? Or what do you mean?

thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz

2007-09-02 15:55:16

by Nick Kossifidis

[permalink] [raw]
Subject: Re: [PATCH 3/5] Net: ath5k, use int as retval

2007/9/1, Jiri Slaby <[email protected]>:
> John W. Linville napsal(a):
> > On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote:
> >> ath5k, use int as retval
> >>
> >> Convert some functions to return int and proper negative return value on
> >> error as we are used to.
> >
> > Since I didn't apply 1/5, this one didn't apply either. It seems
> > fine overall, so if you rediff I'll be happy to apply.
>
> Ok, I'll do it, thanks,

Can somebody commit my resent changes from madwifi-svn (cleanups,
kconfig, remove_hw_ from filenames etc) ? I don't have git repository
;-(


--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick