2007-09-03 18:54:02

by Jiri Slaby

[permalink] [raw]
Subject: Re: Ath5k panic fix

Krzysztof Halasa napsal(a):
> Ath5k panics on ath_open() because sc->pdev is never set, fixed.
>
> Signed-off-by: Krzysztof Halasa <[email protected]>

Acked-by: Jiri Slaby <[email protected]>

I wonder how it is possible that the driver works here.

> --- a/drivers/net/wireless/ath5k_base.c
> +++ b/drivers/net/wireless/ath5k_base.c
> @@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
> hw->max_rssi = 127; /* FIXME: get a real value for this. */
> sc = hw->priv;
> sc->hw = hw;
> + sc->pdev = pdev;
>
> /*
> * Mark the device as detached to avoid processing
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz


2007-09-03 20:53:13

by Nick Kossifidis

[permalink] [raw]
Subject: Re: Ath5k panic fix

2007/9/3, Jiri Slaby <[email protected]>:
> Krzysztof Halasa napsal(a):
> > Ath5k panics on ath_open() because sc->pdev is never set, fixed.
> >
> > Signed-off-by: Krzysztof Halasa <[email protected]>
>
> Acked-by: Jiri Slaby <[email protected]>
>
> I wonder how it is possible that the driver works here.
>
> > --- a/drivers/net/wireless/ath5k_base.c
> > +++ b/drivers/net/wireless/ath5k_base.c
> > @@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
> > hw->max_rssi = 127; /* FIXME: get a real value for this. */
> > sc = hw->priv;
> > sc->hw = hw;
> > + sc->pdev = pdev;
> >
> > /*
> > * Mark the device as detached to avoid processing
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
>
> thanks,

I've already fixed this on r2698 ;-)
http://madwifi.org/changeset/2698

--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick