2007-09-29 10:26:18

by Michael Büsch

Subject: [PATCH] z1211: Make the LEDs warning debug-only

This warning triggers now and then with an -ETIMEDOUT error.
Though the LEDs work fine.
Make this warning debug-only, as nobody is really interested
in a LED failure that happens only now and then.
If the LEDs don't work, one can easily enable debugging to see
what's going on.
This reduces dmesg spamming.

Signed-off-by: Michael Buesch <[email protected]>


Index: wireless-2.6/drivers/net/wireless/z1211/zd_mac.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/z1211/zd_mac.c 2007-09-25 22:51:28.000000000 +0200
+++ wireless-2.6/drivers/net/wireless/z1211/zd_mac.c 2007-09-29 12:19:54.000000000 +0200
@@ -922,7 +922,7 @@ static void link_led_handler(struct work
r = zd_chip_control_leds(chip,
is_associated ? LED_ASSOCIATED : LED_SCANNING);
if (r)
- dev_err(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
+ dev_dbg_f(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);

queue_delayed_work(zd_workqueue, &mac->housekeeping.link_led_work,
LINK_LED_WORK_DELAY);

--
Greetings Michael.

2007-10-02 16:35:21

by Daniel Drake

Subject: Re: [PATCH] z1211: Make the LEDs warning debug-only

Michael Buesch wrote:
> This warning triggers now and then with an -ETIMEDOUT error.
> Though the LEDs work fine.
> Make this warning debug-only, as nobody is really interested
> in a LED failure that happens only now and then.
> If the LEDs don't work, one can easily enable debugging to see
> what's going on.
> This reduces dmesg spamming.
>
> Signed-off-by: Michael Buesch <[email protected]>

Acked-by: Daniel Drake <[email protected]>

>
> Index: wireless-2.6/drivers/net/wireless/z1211/zd_mac.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/z1211/zd_mac.c 2007-09-25 22:51:28.000000000 +0200
> +++ wireless-2.6/drivers/net/wireless/z1211/zd_mac.c 2007-09-29 12:19:54.000000000 +0200
> @@ -922,7 +922,7 @@ static void link_led_handler(struct work
> r = zd_chip_control_leds(chip,
> is_associated ? LED_ASSOCIATED : LED_SCANNING);
> if (r)
> - dev_err(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
> + dev_dbg_f(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
>
> queue_delayed_work(zd_workqueue, &mac->housekeeping.link_led_work,
> LINK_LED_WORK_DELAY);
>