2007-10-15 23:03:56

by John Daiker

[permalink] [raw]
Subject: Ath5k compile error in wireless-2.6.git

John,

I just checked out the wireless-2.6.git tree from Kernel.org to test th=
e=20
new ath5k driver. I get the following compile error on a 'vanilla'=20
git-clone.

CC [M] drivers/net/wireless/ath5k/base.o
In file included from drivers/net/wireless/ath5k/base.h:49,
from drivers/net/wireless/ath5k/base.c:58:
drivers/net/wireless/ath5k/ath5k.h:213: error: redeclaration of=20
enumerator =91MODE_ATHEROS_TURBO=92
include/net/mac80211.h:105: error: previous definition of=20
=91MODE_ATHEROS_TURBO=92 was here
drivers/net/wireless/ath5k/ath5k.h:215: error: redeclaration of=20
enumerator =91MODE_ATHEROS_TURBOG=92
include/net/mac80211.h:107: error: previous definition of=20
=91MODE_ATHEROS_TURBOG=92 was here
drivers/net/wireless/ath5k/base.c: In function =91ath_configure_filter=92=
:
drivers/net/wireless/ath5k/base.c:1419: error: =91FIF_PROMISC_IN_BSS=92=
=20
undeclared (first use in this function)
drivers/net/wireless/ath5k/base.c:1419: error: (Each undeclared=20
identifier is reported only once
drivers/net/wireless/ath5k/base.c:1419: error: for each function it=20
appears in.)
drivers/net/wireless/ath5k/base.c:1419: error: =91FIF_ALLMULTI=92 undec=
lared=20
(first use in this function)
drivers/net/wireless/ath5k/base.c:1419: error: =91FIF_FCSFAIL=92 undecl=
ared=20
(first use in this function)
drivers/net/wireless/ath5k/base.c:1419: error: =91FIF_PLCPFAIL=92 undec=
lared=20
(first use in this function)
drivers/net/wireless/ath5k/base.c:1419: error: =91FIF_CONTROL=92 undecl=
ared=20
(first use in this function)
drivers/net/wireless/ath5k/base.c:1419: error: =91FIF_OTHER_BSS=92=20
undeclared (first use in this function)
drivers/net/wireless/ath5k/base.c:1419: error: =91FIF_BCN_PRBRESP_PROMI=
SC=92=20
undeclared (first use in this function)
drivers/net/wireless/ath5k/base.c: At top level:
drivers/net/wireless/ath5k/base.c:1479: warning: =91enum set_key_cmd=92=
=20
declared inside parameter list
drivers/net/wireless/ath5k/base.c:1479: warning: its scope is only this=
=20
definition or declaration, which is probably not what you want
drivers/net/wireless/ath5k/base.c:1477: error: parameter 2 (=91cmd=92) =
has=20
incomplete type
drivers/net/wireless/ath5k/base.c:1583: error: unknown field =91start=92=
=20
specified in initializer
drivers/net/wireless/ath5k/base.c:1584: warning: initialization from=20
incompatible pointer type
drivers/net/wireless/ath5k/base.c:1589: error: unknown field=20
=91configure_filter=92 specified in initializer
drivers/net/wireless/ath5k/base.c:1589: warning: initialization from=20
incompatible pointer type
drivers/net/wireless/ath5k/base.c:1590: warning: initialization from=20
incompatible pointer type
make[4]: *** [drivers/net/wireless/ath5k/base.o] Error 1
make[3]: *** [drivers/net/wireless/ath5k] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2


Maybe you can shed some light?

John


2007-10-16 18:38:54

by John W. Linville

[permalink] [raw]
Subject: Re: Ath5k compile error in wireless-2.6.git

On Tue, Oct 16, 2007 at 02:05:24PM -0400, Luis R. Rodriguez wrote:
> On 10/16/07, John W. Linville <[email protected]> wrote:

> > I think this has more to do with the git version (i.e. release) than
> > the architecture. "Approach 1" worked everywhere for a long time,
> > while I only became aware of "Approach 2" a few months ago.
>
> On my x86 box I have git 1.5.2.5
> On my PPC box have git 1.5.3.4
>
> And no dice on the PowerPC box. Maybe I have to do a new pull with the
> new release.. I'll try.

It might have to do with whether you started with "git clone" or by
simply rsync'ing the repository. In the latter case, "Approach 1"
probably works fine...?

Anyway, whatever works for you makes me happy. :-)

--
John W. Linville
[email protected]

2007-10-16 17:38:45

by John W. Linville

[permalink] [raw]
Subject: Re: Ath5k compile error in wireless-2.6.git

On Tue, Oct 16, 2007 at 12:14:17PM -0400, Luis R. Rodriguez wrote:
> On 10/15/07, John W. Linville <[email protected]> wrote:
> > On Mon, Oct 15, 2007 at 07:46:01PM -0400, John W. Linville wrote:
> > > On Mon, Oct 15, 2007 at 03:38:02PM -0700, John Daiker wrote:
> > > > John,
> > > >
> > > > I just checked out the wireless-2.6.git tree from Kernel.org to test the
> > > > new ath5k driver. I get the following compile error on a 'vanilla'
> > > > git-clone.
> > >
> > > Please use the 'everything' branch for development.
> > >
> > > git checkout everything
>
> Approach 1
>
> > Hmmm...maybe this instead:
> >
> > git checkout -b everything origin/everything
>
> Approach 2
>
> What's fun is that the above is approach 1 is actually necessary on
> PowerPC. It seems git for powerpc still uses the old branch stuff. For
> example I can't use approach 2. I'll add this to the wiki for ath5k,
> just a head up in case there's some PowerPC users out there.

I think this has more to do with the git version (i.e. release) than
the architecture. "Approach 1" worked everywhere for a long time,
while I only became aware of "Approach 2" a few months ago.

John
--
John W. Linville
[email protected]

2007-10-16 18:05:27

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Ath5k compile error in wireless-2.6.git

On 10/16/07, John W. Linville <[email protected]> wrote:
> On Tue, Oct 16, 2007 at 12:14:17PM -0400, Luis R. Rodriguez wrote:
> > On 10/15/07, John W. Linville <[email protected]> wrote:
> > > On Mon, Oct 15, 2007 at 07:46:01PM -0400, John W. Linville wrote:
> > > > On Mon, Oct 15, 2007 at 03:38:02PM -0700, John Daiker wrote:
> > > > > John,
> > > > >
> > > > > I just checked out the wireless-2.6.git tree from Kernel.org to test the
> > > > > new ath5k driver. I get the following compile error on a 'vanilla'
> > > > > git-clone.
> > > >
> > > > Please use the 'everything' branch for development.
> > > >
> > > > git checkout everything
> >
> > Approach 1
> >
> > > Hmmm...maybe this instead:
> > >
> > > git checkout -b everything origin/everything
> >
> > Approach 2
> >
> > What's fun is that the above is approach 1 is actually necessary on
> > PowerPC. It seems git for powerpc still uses the old branch stuff. For
> > example I can't use approach 2. I'll add this to the wiki for ath5k,
> > just a head up in case there's some PowerPC users out there.
>
> I think this has more to do with the git version (i.e. release) than
> the architecture. "Approach 1" worked everywhere for a long time,
> while I only became aware of "Approach 2" a few months ago.

On my x86 box I have git 1.5.2.5
On my PPC box have git 1.5.3.4

And no dice on the PowerPC box. Maybe I have to do a new pull with the
new release.. I'll try.

Luis

2007-10-16 00:27:41

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Ath5k compile error in wireless-2.6.git

On 10/15/07, John Daiker <[email protected]> wrote:
> John,
>
> I just checked out the wireless-2.6.git tree from Kernel.org to test the
> new ath5k driver. I get the following compile error on a 'vanilla'
> git-clone.
>
> CC [M] drivers/net/wireless/ath5k/base.o
> In file included from drivers/net/wireless/ath5k/base.h:49,
> from drivers/net/wireless/ath5k/base.c:58:
> drivers/net/wireless/ath5k/ath5k.h:213: error: redeclaration of
> enumerator 'MODE_ATHEROS_TURBO'
> include/net/mac80211.h:105: error: previous definition of
> 'MODE_ATHEROS_TURBO' was here
> drivers/net/wireless/ath5k/ath5k.h:215: error: redeclaration of
> enumerator 'MODE_ATHEROS_TURBOG'
> include/net/mac80211.h:107: error: previous definition of
> 'MODE_ATHEROS_TURBOG' was here
> drivers/net/wireless/ath5k/base.c: In function 'ath_configure_filter':
> drivers/net/wireless/ath5k/base.c:1419: error: 'FIF_PROMISC_IN_BSS'
> undeclared (first use in this function)
> drivers/net/wireless/ath5k/base.c:1419: error: (Each undeclared
> identifier is reported only once
> drivers/net/wireless/ath5k/base.c:1419: error: for each function it
> appears in.)
> drivers/net/wireless/ath5k/base.c:1419: error: 'FIF_ALLMULTI' undeclared
> (first use in this function)
> drivers/net/wireless/ath5k/base.c:1419: error: 'FIF_FCSFAIL' undeclared
> (first use in this function)
> drivers/net/wireless/ath5k/base.c:1419: error: 'FIF_PLCPFAIL' undeclared
> (first use in this function)
> drivers/net/wireless/ath5k/base.c:1419: error: 'FIF_CONTROL' undeclared
> (first use in this function)
> drivers/net/wireless/ath5k/base.c:1419: error: 'FIF_OTHER_BSS'
> undeclared (first use in this function)
> drivers/net/wireless/ath5k/base.c:1419: error: 'FIF_BCN_PRBRESP_PROMISC'
> undeclared (first use in this function)
> drivers/net/wireless/ath5k/base.c: At top level:
> drivers/net/wireless/ath5k/base.c:1479: warning: 'enum set_key_cmd'
> declared inside parameter list
> drivers/net/wireless/ath5k/base.c:1479: warning: its scope is only this
> definition or declaration, which is probably not what you want
> drivers/net/wireless/ath5k/base.c:1477: error: parameter 2 ('cmd') has
> incomplete type
> drivers/net/wireless/ath5k/base.c:1583: error: unknown field 'start'
> specified in initializer
> drivers/net/wireless/ath5k/base.c:1584: warning: initialization from
> incompatible pointer type
> drivers/net/wireless/ath5k/base.c:1589: error: unknown field
> 'configure_filter' specified in initializer
> drivers/net/wireless/ath5k/base.c:1589: warning: initialization from
> incompatible pointer type
> drivers/net/wireless/ath5k/base.c:1590: warning: initialization from
> incompatible pointer type
> make[4]: *** [drivers/net/wireless/ath5k/base.o] Error 1
> make[3]: *** [drivers/net/wireless/ath5k] Error 2
> make[2]: *** [drivers/net/wireless] Error 2
> make[1]: *** [drivers/net] Error 2
>
>
> Maybe you can shed some light?

Please use the 'everything' branch, not the 'ath5k' branch. This is
reflected on the wiki:

http://linuxwireless.org/en/users/Drivers/ath5k

Luis

2007-10-16 00:39:17

by John W. Linville

[permalink] [raw]
Subject: Re: Ath5k compile error in wireless-2.6.git

On Mon, Oct 15, 2007 at 07:46:01PM -0400, John W. Linville wrote:
> On Mon, Oct 15, 2007 at 03:38:02PM -0700, John Daiker wrote:
> > John,
> >
> > I just checked out the wireless-2.6.git tree from Kernel.org to test the
> > new ath5k driver. I get the following compile error on a 'vanilla'
> > git-clone.
>
> Please use the 'everything' branch for development.
>
> git checkout everything

Hmmm...maybe this instead:

git checkout -b everything origin/everything

John
--
John W. Linville
[email protected]

2007-10-16 00:39:12

by John W. Linville

[permalink] [raw]
Subject: Re: Ath5k compile error in wireless-2.6.git

On Mon, Oct 15, 2007 at 03:38:02PM -0700, John Daiker wrote:
> John,
>
> I just checked out the wireless-2.6.git tree from Kernel.org to test the
> new ath5k driver. I get the following compile error on a 'vanilla'
> git-clone.

Please use the 'everything' branch for development.

git checkout everything

Thanks,

John
--
John W. Linville
[email protected]

2007-10-16 16:14:20

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Ath5k compile error in wireless-2.6.git

On 10/15/07, John W. Linville <[email protected]> wrote:
> On Mon, Oct 15, 2007 at 07:46:01PM -0400, John W. Linville wrote:
> > On Mon, Oct 15, 2007 at 03:38:02PM -0700, John Daiker wrote:
> > > John,
> > >
> > > I just checked out the wireless-2.6.git tree from Kernel.org to test the
> > > new ath5k driver. I get the following compile error on a 'vanilla'
> > > git-clone.
> >
> > Please use the 'everything' branch for development.
> >
> > git checkout everything

Approach 1

> Hmmm...maybe this instead:
>
> git checkout -b everything origin/everything

Approach 2

What's fun is that the above is approach 1 is actually necessary on
PowerPC. It seems git for powerpc still uses the old branch stuff. For
example I can't use approach 2. I'll add this to the wiki for ath5k,
just a head up in case there's some PowerPC users out there.

Luis