2009-04-13 19:59:41

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: [PATCH] rtl8187: Remove the "8187B chip detected" message when probing RTL8187B cards




--- On Mon, 13/4/09, G=E1bor Stefanik <[email protected]> wrote:

> This message appears to be nothing
> more than a leftover of the
> experimental-8187B era. Also, we print the HW type in the
> hwaddr line,
> making this message reduntant. And it's definitely not
> important
> enough to be a KERN_WARNING.
>=20
> Signed-off-by: G=E1bor Stefanik <[email protected]>

Acked-by: Hin-Tak Leung <[email protected]>

Indeed - that printk doesn't really say anything useful.


=20


2009-04-13 20:05:36

by Gábor Stefanik

[permalink] [raw]
Subject: Re: [PATCH] rtl8187: Remove the "8187B chip detected" message when probing RTL8187B cards

On Mon, Apr 13, 2009 at 9:59 PM, Hin-Tak Leung
<[email protected]> wrote:
>
>
>
> --- On Mon, 13/4/09, G=E1bor Stefanik <[email protected]> wrote=
:
>
>> This message appears to be nothing
>> more than a leftover of the
>> experimental-8187B era. Also, we print the HW type in the
>> hwaddr line,
>> making this message reduntant. And it's definitely not
>> important
>> enough to be a KERN_WARNING.
>>
>> Signed-off-by: G=E1bor Stefanik <[email protected]>
>
> Acked-by: Hin-Tak Leung <[email protected]>
>
> Indeed - that printk doesn't really say anything useful.

=46or the record, I originally wanted to add an equivalent "8187L
detected" message, but then I noticed that the HW type is printed in
the hwaddr line, making any further printks redundant.

--=20
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)