2007-10-23 10:55:09

by Norbert Preining

[permalink] [raw]
Subject: Re: [ipw3945-devel] [RFC][PATCH] iwlwifi using mac80211_leds

Zhu Yi <yi.zhu@...> writes:
aven't have enough time to review this patch these days. Will
> try to do it next week. But any test are always welcome!

I would like to, is there a way to patch this into the git sources?

I am running 2.6.23 with latest iwlwifi git sources.

I patched the git sources and started compiling with -DCONFIG_IWLWIFI_LEDS=y but
the compile boiled out with:
/src/wlan/iwlwifi/foo/compatible/iwl3945-base.c:6218: error: implicit
declaration of function 'ieee80211_get_assoc_led_name'
(and some more warnings).

Is there anything I can do to test it?

Best wishes

Norbert



2007-10-23 11:40:59

by Ian Schram

[permalink] [raw]
Subject: Re: [ipw3945-devel] [RFC][PATCH] iwlwifi using mac80211_leds



Norbert Preining wrote:
> Zhu Yi <yi.zhu@...> writes:
> aven't have enough time to review this patch these days. Will
>> try to do it next week. But any test are always welcome!
>
> I would like to, is there a way to patch this into the git sources?
the intellinuxwireless.org gits? to make it work it would require an update
of the mac80211 package, and compatibility with older kernels is probably
pretty nasty.

>
> I am running 2.6.23 with latest iwlwifi git sources.
>
> I patched the git sources and started compiling with -DCONFIG_IWLWIFI_LEDS=y but
> the compile boiled out with:
> /src/wlan/iwlwifi/foo/compatible/iwl3945-base.c:6218: error: implicit
> declaration of function 'ieee80211_get_assoc_led_name'
> (and some more warnings).
>
the association led is only in the very latest git sources, i'm guessing only
wireless-2.6 for now.

(also i have learned that i forgot to ifdef the INIT_DELAYED_WORK, I must really try to
beat this inability of sending a patch right the first time round)

i bet an iwl_is_ready(priv) call in the delayed work wouldn't hurt either,
anyway. It works for me feel free to improve it. Or wait until one of
seasoned developers, has no higher priority items on their list.

> Is there anything I can do to test it?
>
> Best wishes
>
> Norbert
>

I'll try to send a patch a bit later today to fix a few of the outstanding issues.

2007-10-23 12:35:04

by Norbert Preining

[permalink] [raw]
Subject: Re: [ipw3945-devel] [RFC][PATCH] iwlwifi using mac80211_leds

On Di, 23 Okt 2007, Ian Schram wrote:
> > I would like to, is there a way to patch this into the git sources?

> the intellinuxwireless.org gits? to make it work it would require an update

Sorry for being unclear, I meant the iwlwifi git sources (so currently
the 1.1.18 one).

> of the mac80211 package, and compatibility with older kernels is probably
> pretty nasty.

Ah, ok, so I would have to use the mac80211.git source, too.

> the association led is only in the very latest git sources, i'm guessing only
> wireless-2.6 for now.

Ok, so 2.6.23-mm1 should do the trick, am I right?

> I'll try to send a patch a bit later today to fix a few of the outstanding issues.

Thanks.


Best wishes

Norbert

-------------------------------------------------------------------------------
Dr. Norbert Preining <[email protected]> Vienna University of Technology
Debian Developer <[email protected]> Debian TeX Group
gpg DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76 A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
EWELME (n.)
The smile bestowed on you by an air hostess.
--- Douglas Adams, The Meaning of Liff

2007-10-23 12:36:56

by maximilian attems

[permalink] [raw]
Subject: Re: [ipw3945-devel] [RFC][PATCH] iwlwifi using mac80211_leds

On Tue, Oct 23, 2007 at 01:43:18PM +0200, Norbert Preining wrote:
> Ok, so 2.6.23-mm1 should do the trick, am I right?
>
current git maybe better :P
but if you are lazy we have backports in 2.6.23 trunk snapshots
-> http://wiki.debian.org/DebianKernel

--
maks