2014-05-22 18:30:09

by John W. Linville

[permalink] [raw]
Subject: [PATCH] mwifiex: use 'const' qualifier for 2nd arg of mwifiex_tdls_add_ht_oper

Fixes the following warning:

CC drivers/net/wireless/mwifiex/tdls.o
drivers/net/wireless/mwifiex/tdls.c: In function ‘mwifiex_prep_tdls_encap_data’:
drivers/net/wireless/mwifiex/tdls.c:475:4: warning: passing argument 2 of ‘mwifiex_tdls_add_ht_oper’ discards ‘const’ qualifier from pointer target type [enabled by
default]
ret = mwifiex_tdls_add_ht_oper(priv, peer, 1, skb);
^
drivers/net/wireless/mwifiex/tdls.c:190:1: note: expected ‘u8 *’ but argument is of type ‘const u8 *’
mwifiex_tdls_add_ht_oper(struct mwifiex_private *priv, u8 *mac,
^
drivers/net/wireless/mwifiex/tdls.c:481:4: warning: passing argument 2 of ‘mwifiex_tdls_add_ht_oper’ discards ‘const’ qualifier from pointer target type [enabled by
default]
ret = mwifiex_tdls_add_ht_oper(priv, peer, 0, skb);
^
drivers/net/wireless/mwifiex/tdls.c:190:1: note: expected ‘u8 *’ but argument is of type ‘const u8 *’
mwifiex_tdls_add_ht_oper(struct mwifiex_private *priv, u8 *mac,
^

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/mwifiex/tdls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mwifiex/tdls.c b/drivers/net/wireless/mwifiex/tdls.c
index e14fbb5de49b..e73034fbbde9 100644
--- a/drivers/net/wireless/mwifiex/tdls.c
+++ b/drivers/net/wireless/mwifiex/tdls.c
@@ -187,7 +187,7 @@ static int mwifiex_tdls_add_vht_capab(struct mwifiex_private *priv,
}

static int
-mwifiex_tdls_add_ht_oper(struct mwifiex_private *priv, u8 *mac,
+mwifiex_tdls_add_ht_oper(struct mwifiex_private *priv, const u8 *mac,
u8 vht_enabled, struct sk_buff *skb)
{
struct ieee80211_ht_operation *ht_oper;
--
1.9.0



2014-05-22 18:57:49

by Bing Zhao

[permalink] [raw]
Subject: RE: [PATCH] mwifiex: use 'const' qualifier for 2nd arg of mwifiex_tdls_add_ht_oper

SGkgSm9obiwNCg0KPiBGaXhlcyB0aGUgZm9sbG93aW5nIHdhcm5pbmc6DQo+IA0KPiAgIENDICAg
ICAgZHJpdmVycy9uZXQvd2lyZWxlc3MvbXdpZmlleC90ZGxzLm8NCj4gZHJpdmVycy9uZXQvd2ly
ZWxlc3MvbXdpZmlleC90ZGxzLmM6IEluIGZ1bmN0aW9uIOKAmG13aWZpZXhfcHJlcF90ZGxzX2Vu
Y2FwX2RhdGHigJk6DQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZpZXgvdGRscy5jOjQ3NTo0
OiB3YXJuaW5nOiBwYXNzaW5nIGFyZ3VtZW50IDIgb2Yg4oCYbXdpZmlleF90ZGxzX2FkZF9odF9v
cGVy4oCZDQo+IGRpc2NhcmRzIOKAmGNvbnN04oCZIHF1YWxpZmllciBmcm9tIHBvaW50ZXIgdGFy
Z2V0IHR5cGUgW2VuYWJsZWQgYnkNCj4gZGVmYXVsdF0NCj4gICAgIHJldCA9IG13aWZpZXhfdGRs
c19hZGRfaHRfb3Blcihwcml2LCBwZWVyLCAxLCBza2IpOw0KPiAgICAgXg0KPiBkcml2ZXJzL25l
dC93aXJlbGVzcy9td2lmaWV4L3RkbHMuYzoxOTA6MTogbm90ZTogZXhwZWN0ZWQg4oCYdTggKuKA
mSBidXQgYXJndW1lbnQgaXMgb2YgdHlwZSDigJhjb25zdCB1OCAq4oCZDQo+ICBtd2lmaWV4X3Rk
bHNfYWRkX2h0X29wZXIoc3RydWN0IG13aWZpZXhfcHJpdmF0ZSAqcHJpdiwgdTggKm1hYywNCj4g
IF4NCj4gZHJpdmVycy9uZXQvd2lyZWxlc3MvbXdpZmlleC90ZGxzLmM6NDgxOjQ6IHdhcm5pbmc6
IHBhc3NpbmcgYXJndW1lbnQgMiBvZiDigJhtd2lmaWV4X3RkbHNfYWRkX2h0X29wZXLigJkNCj4g
ZGlzY2FyZHMg4oCYY29uc3TigJkgcXVhbGlmaWVyIGZyb20gcG9pbnRlciB0YXJnZXQgdHlwZSBb
ZW5hYmxlZCBieQ0KPiBkZWZhdWx0XQ0KPiAgICAgcmV0ID0gbXdpZmlleF90ZGxzX2FkZF9odF9v
cGVyKHByaXYsIHBlZXIsIDAsIHNrYik7DQo+ICAgICBeDQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNz
L213aWZpZXgvdGRscy5jOjE5MDoxOiBub3RlOiBleHBlY3RlZCDigJh1OCAq4oCZIGJ1dCBhcmd1
bWVudCBpcyBvZiB0eXBlIOKAmGNvbnN0IHU4ICrigJkNCj4gIG13aWZpZXhfdGRsc19hZGRfaHRf
b3BlcihzdHJ1Y3QgbXdpZmlleF9wcml2YXRlICpwcml2LCB1OCAqbWFjLA0KPiAgXg0KPiANCj4g
U2lnbmVkLW9mZi1ieTogSm9obiBXLiBMaW52aWxsZSA8bGludmlsbGVAdHV4ZHJpdmVyLmNvbT4N
Cg0KQWNrZWQtYnk6IEJpbmcgWmhhbyA8YnpoYW9AbWFydmVsbC5jb20+DQoNClJlZ2FyZHMsDQpC
aW5nDQoNCj4gLS0tDQo+ICBkcml2ZXJzL25ldC93aXJlbGVzcy9td2lmaWV4L3RkbHMuYyB8IDIg
Ky0NCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiAN
Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZpZXgvdGRscy5jIGIvZHJp
dmVycy9uZXQvd2lyZWxlc3MvbXdpZmlleC90ZGxzLmMNCj4gaW5kZXggZTE0ZmJiNWRlNDliLi5l
NzMwMzRmYmJkZTkgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZpZXgv
dGRscy5jDQo+ICsrKyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZpZXgvdGRscy5jDQo+IEBA
IC0xODcsNyArMTg3LDcgQEAgc3RhdGljIGludCBtd2lmaWV4X3RkbHNfYWRkX3ZodF9jYXBhYihz
dHJ1Y3QgbXdpZmlleF9wcml2YXRlICpwcml2LA0KPiAgfQ0KPiANCj4gIHN0YXRpYyBpbnQNCj4g
LW13aWZpZXhfdGRsc19hZGRfaHRfb3BlcihzdHJ1Y3QgbXdpZmlleF9wcml2YXRlICpwcml2LCB1
OCAqbWFjLA0KPiArbXdpZmlleF90ZGxzX2FkZF9odF9vcGVyKHN0cnVjdCBtd2lmaWV4X3ByaXZh
dGUgKnByaXYsIGNvbnN0IHU4ICptYWMsDQo+ICAJCQkgdTggdmh0X2VuYWJsZWQsIHN0cnVjdCBz
a19idWZmICpza2IpDQo+ICB7DQo+ICAJc3RydWN0IGllZWU4MDIxMV9odF9vcGVyYXRpb24gKmh0
X29wZXI7DQo+IC0tDQo+IDEuOS4wDQoNCg==