Hey All,
My first patch for the mrv8k driver. My machine locks up when I try to
load a firmware, so I'm not sure if this patch helps anybody or not.
John Daiker
Markus Becker wrote:
>
> On Wed, 14 May 2008, Pavel Roskin wrote:
>
>> On Tue, 2008-05-13 at 17:59 -0700, John Daiker wrote:
>>> Hey All,
>>>
>>> My first patch for the mrv8k driver. My machine locks up when I try to
>>> load a firmware, so I'm not sure if this patch helps anybody or not.
>>
>> I don't see any changes for mrv_reg_read32() claimed in the description.
>
> He is checking the return value to 0x5 instead of 5.
Right... the aim here is for some sort of code consistency. Makes
things easier to read, IMHO.
>
>> In fact, I don't see any changes to the code except comments and
>> messages. I don't see how it can help against lockups, unless you
>> missed some part of the patch.
>
> It does not. But I pushed the comment and indent fixes to mrv8k
> nevertheless.
Thanks. I guess I mentioned that to solicit input from others on ideas
for debugging.
>
>> You may want to spell check your patch, including the description,
>> especially if the patch is fixing spelling mistakes made by others.
Duly noted. I will keep an keen eye out next time for mistakes. :)
>>
>> --
>> Regards,
>> Pavel Roskin
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-wireless" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
On Wed, 2008-05-14 at 15:08 +0200, Markus Becker wrote:
> On Wed, 14 May 2008, Pavel Roskin wrote:
>
> > On Tue, 2008-05-13 at 17:59 -0700, John Daiker wrote:
> >> Hey All,
> >>
> >> My first patch for the mrv8k driver. My machine locks up when I try to
> >> load a firmware, so I'm not sure if this patch helps anybody or not.
> >
> > I don't see any changes for mrv_reg_read32() claimed in the description.
>
> He is checking the return value to 0x5 instead of 5.
You realise, of course, that those are the same number?
johannes
On Tue, 2008-05-13 at 17:59 -0700, John Daiker wrote:
> Hey All,
>
> My first patch for the mrv8k driver. My machine locks up when I try to
> load a firmware, so I'm not sure if this patch helps anybody or not.
I don't see any changes for mrv_reg_read32() claimed in the description.
In fact, I don't see any changes to the code except comments and
messages. I don't see how it can help against lockups, unless you
missed some part of the patch.
You may want to spell check your patch, including the description,
especially if the patch is fixing spelling mistakes made by others.
--
Regards,
Pavel Roskin
On Wed, 14 May 2008, Pavel Roskin wrote:
> On Tue, 2008-05-13 at 17:59 -0700, John Daiker wrote:
>> Hey All,
>>
>> My first patch for the mrv8k driver. My machine locks up when I try to
>> load a firmware, so I'm not sure if this patch helps anybody or not.
>
> I don't see any changes for mrv_reg_read32() claimed in the description.
He is checking the return value to 0x5 instead of 5.
> In fact, I don't see any changes to the code except comments and
> messages. I don't see how it can help against lockups, unless you
> missed some part of the patch.
It does not. But I pushed the comment and indent fixes to mrv8k
nevertheless.
> You may want to spell check your patch, including the description,
> especially if the patch is fixing spelling mistakes made by others.
>
> --
> Regards,
> Pavel Roskin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>