2008-06-28 10:24:47

by George Fong

[permalink] [raw]
Subject: Problem making compat-wireless-2.6

Hi guys

Not sure if this is a bug but I have not been able to make the compat wireless
drivers.

I am running off Fedora 9 (x86_64) with kernel 2.6.25.6-55.fc9.x86_64. I am
interested in the iwl4965 driver.

Everything goes OK until we hit the compilation of part of the b43 driver.
This is what I get:

/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:
In function ‘b43_rfkill_soft_toggle’:
/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:91:
error: ‘RFKILL_STATE_UNBLOCKED’ undeclared (first use in this function)
/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:91:
error: (Each undeclared identifier is reported only once
/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:91:
error: for each function it appears in.)
/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:101:
error: ‘RFKILL_STATE_SOFT_BLOCKED’ undeclared (first use in this function)
make[4]: ***
[/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.o]
Error 1
make[3]: ***
[/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43]
Error 2
make[2]: ***
[/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless] Error
2
make[1]: *** [_module_/home/george/Download/compat-wireless-2008-06-28] Error
2
make[1]: Leaving directory `/usr/src/kernels/2.6.25.6-55.fc9.x86_64'
make: *** [modules] Error 2

It is entirely likely that I am doing something wrong but I don't know what.

Hope this is all OK to report.

Cheers
G,


--
George Fong
Lateral Plains Pty Ltd
Tel: +61 3 53 302 880
Fax: +61 3 53 302 881
Just remember, wherever you go .... there you are.


Attachments:
(No filename) (1.74 kB)
signature.asc (197.00 B)
This is a digitally signed message part.
Download all attachments

2008-06-28 15:32:31

by Gábor Stefanik

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

On Sat, Jun 28, 2008 at 5:10 PM, John W. Linville
<[email protected]> wrote:
> On Sat, Jun 28, 2008 at 01:21:54PM +0200, Stefanik G=E1bor wrote:
>
>> Try editing drivers/net/wireless/b43/rfkill.c, and replacing
>> RFKILL_STATE_UNBLOCKED with RFKILL_STATE_ON and
>> RFKILL_STATE_SOFT_BLOCKED with RFKILL_STATE_OFF. Looks like rfkill i=
s
>> not part of the compat package, and no work has been done to match
>> compat-wireless to older RFKILLs.
>
> FWIW, rfkill probably _should_ be in compat-wireless. Luis?
>
> John
> --
> John W. Linville
> [email protected]
>

John's proposal Acked-by: G=E1bor Stefanik <[email protected]>

--=20
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2008-06-28 19:08:43

by Gábor Stefanik

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

On Sat, Jun 28, 2008 at 8:57 PM, Luis R. Rodriguez <[email protected]> w=
rote:
> On Sat, Jun 28, 2008 at 8:10 AM, John W. Linville
> <[email protected]> wrote:
>> On Sat, Jun 28, 2008 at 01:21:54PM +0200, Stefanik G=E1bor wrote:
>>
>>> Try editing drivers/net/wireless/b43/rfkill.c, and replacing
>>> RFKILL_STATE_UNBLOCKED with RFKILL_STATE_ON and
>>> RFKILL_STATE_SOFT_BLOCKED with RFKILL_STATE_OFF. Looks like rfkill =
is
>>> not part of the compat package, and no work has been done to match
>>> compat-wireless to older RFKILLs.
>>
>> FWIW, rfkill probably _should_ be in compat-wireless. Luis?
>
> I haven't had a chance to port rfkill yet down to 2.6.22. If someone
> is interested I'd be glad to accept patches.
>
> Luis
>

Right now, compat-wireless doesn't work even on 2.6.25, for this
reason. Even an implementation that requires 2.6.25 would be an
improvement from here.

--=20
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2008-06-28 19:50:38

by drago01

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

On Sat, Jun 28, 2008 at 9:08 PM, Stefanik G=E1bor <netrolller.3d@gmail.=
com> wrote:
> On Sat, Jun 28, 2008 at 8:57 PM, Luis R. Rodriguez <[email protected]>=
wrote:
>> On Sat, Jun 28, 2008 at 8:10 AM, John W. Linville
>> <[email protected]> wrote:
>>> On Sat, Jun 28, 2008 at 01:21:54PM +0200, Stefanik G=E1bor wrote:
>>>
>>>> Try editing drivers/net/wireless/b43/rfkill.c, and replacing
>>>> RFKILL_STATE_UNBLOCKED with RFKILL_STATE_ON and
>>>> RFKILL_STATE_SOFT_BLOCKED with RFKILL_STATE_OFF. Looks like rfkill=
is
>>>> not part of the compat package, and no work has been done to match
>>>> compat-wireless to older RFKILLs.
>>>
>>> FWIW, rfkill probably _should_ be in compat-wireless. Luis?
>>
>> I haven't had a chance to port rfkill yet down to 2.6.22. If someone
>> is interested I'd be glad to accept patches.
>>
>> Luis
>>
>
> Right now, compat-wireless doesn't work even on 2.6.25, for this
> reason. Even an implementation that requires 2.6.25 would be an
> improvement from here.

wouldn't simple defines fix it for now until someone backports the
rfkill patches?

2008-06-28 15:22:07

by John W. Linville

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

On Sat, Jun 28, 2008 at 01:21:54PM +0200, Stefanik G=E1bor wrote:

> Try editing drivers/net/wireless/b43/rfkill.c, and replacing
> RFKILL_STATE_UNBLOCKED with RFKILL_STATE_ON and
> RFKILL_STATE_SOFT_BLOCKED with RFKILL_STATE_OFF. Looks like rfkill is
> not part of the compat package, and no work has been done to match
> compat-wireless to older RFKILLs.

=46WIW, rfkill probably _should_ be in compat-wireless. Luis?

John
--=20
John W. Linville
[email protected]

2008-06-29 01:37:09

by George Fong

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

<snip>

Dang :-) This was the fix.

> Try editing drivers/net/wireless/b43/rfkill.c, and replacing
> RFKILL_STATE_UNBLOCKED with RFKILL_STATE_ON and
> RFKILL_STATE_SOFT_BLOCKED with RFKILL_STATE_OFF. Looks like rfkill is
> not part of the compat package, and no work has been done to match
> compat-wireless to older RFKILLs.

Thank you for such prompt responses. Although I did this for the b43 driver, I
ended up progressively having to do the same fix for the drivers for a couple
more, ie iwlwifi and rxt200

I am not concerned about the rxt200 but the driver I was interested in was the
iwl4965, so I am not sure that by changing the settings on iwl-rfkill.c I
have affected the driver I am using ....


Having said that... the email is brought to you courtesy of the iwl9645 wifi
device .. which has got to be a Good Thing ;-)

Agree about the proper way of doing things - should really install a newer
kernel, but I am strapped into an nVidia graphics card on my laptop and the
livna drivers keep pace well but I think I risk breaking these at the moment
with the newer kernel.

Thank you all for your prompt responses and asistance... on a weekend no
less :-) I'll monitor progress and contribute whatever little I can as I get
this new laptop settled.

Cheers
G.

--
George Fong
Lateral Plains Pty Ltd
Tel: +61 3 53 302 880
Fax: +61 3 53 302 881
Just remember, wherever you go .... there you are.


Attachments:
(No filename) (1.38 kB)
signature.asc (197.00 B)
This is a digitally signed message part.
Download all attachments

2008-06-30 08:21:14

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

On Sat, Jun 28, 2008 at 6:33 PM, George Fong <[email protected]> wrote:
> <snip>
>
> Dang :-) This was the fix.
>
>> Try editing drivers/net/wireless/b43/rfkill.c, and replacing
>> RFKILL_STATE_UNBLOCKED with RFKILL_STATE_ON and
>> RFKILL_STATE_SOFT_BLOCKED with RFKILL_STATE_OFF. Looks like rfkill is
>> not part of the compat package, and no work has been done to match
>> compat-wireless to older RFKILLs.
>
> Thank you for such prompt responses. Although I did this for the b43 driver, I
> ended up progressively having to do the same fix for the drivers for a couple
> more, ie iwlwifi and rxt200
>
> I am not concerned about the rxt200 but the driver I was interested in was the
> iwl4965, so I am not sure that by changing the settings on iwl-rfkill.c I
> have affected the driver I am using ....
>
>
> Having said that... the email is brought to you courtesy of the iwl9645 wifi
> device .. which has got to be a Good Thing ;-)
>
> Agree about the proper way of doing things - should really install a newer
> kernel, but I am strapped into an nVidia graphics card on my laptop and the
> livna drivers keep pace well but I think I risk breaking these at the moment
> with the newer kernel.
>
> Thank you all for your prompt responses and asistance... on a weekend no
> less :-) I'll monitor progress and contribute whatever little I can as I get
> this new laptop settled.

I've fixed this in compat-wireless, it should now compile fine for
kernels <= 2.6.26.

Luis

2008-06-28 11:21:56

by Gábor Stefanik

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

On Sat, Jun 28, 2008 at 11:53 AM, George Fong <[email protected]> wrote:
> Hi guys
>
> Not sure if this is a bug but I have not been able to make the compat wireless
> drivers.
>
> I am running off Fedora 9 (x86_64) with kernel 2.6.25.6-55.fc9.x86_64. I am
> interested in the iwl4965 driver.
>
> Everything goes OK until we hit the compilation of part of the b43 driver.
> This is what I get:
>
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:
> In function 'b43_rfkill_soft_toggle':
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:91:
> error: 'RFKILL_STATE_UNBLOCKED' undeclared (first use in this function)
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:91:
> error: (Each undeclared identifier is reported only once
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:91:
> error: for each function it appears in.)
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.c:101:
> error: 'RFKILL_STATE_SOFT_BLOCKED' undeclared (first use in this function)
> make[4]: ***
> [/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43/rfkill.o]
> Error 1
> make[3]: ***
> [/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless/b43]
> Error 2
> make[2]: ***
> [/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless] Error
> 2
> make[1]: *** [_module_/home/george/Download/compat-wireless-2008-06-28] Error
> 2
> make[1]: Leaving directory `/usr/src/kernels/2.6.25.6-55.fc9.x86_64'
> make: *** [modules] Error 2
>
> It is entirely likely that I am doing something wrong but I don't know what.
>
> Hope this is all OK to report.
>
> Cheers
> G,
>
>
> --
> George Fong
> Lateral Plains Pty Ltd
> Tel: +61 3 53 302 880
> Fax: +61 3 53 302 881
> Just remember, wherever you go .... there you are.
>

Try editing drivers/net/wireless/b43/rfkill.c, and replacing
RFKILL_STATE_UNBLOCKED with RFKILL_STATE_ON and
RFKILL_STATE_SOFT_BLOCKED with RFKILL_STATE_OFF. Looks like rfkill is
not part of the compat package, and no work has been done to match
compat-wireless to older RFKILLs.

--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2008-06-28 15:46:59

by John W. Linville

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

On Sat, Jun 28, 2008 at 07:53:13PM +1000, George Fong wrote:
> Hi guys
>
> Not sure if this is a bug but I have not been able to make the compat wireless
> drivers.
>
> I am running off Fedora 9 (x86_64) with kernel 2.6.25.6-55.fc9.x86_64. I am
> interested in the iwl4965 driver.

Do you absolutely need the stuff I merged to wireless-next-2.6
yesterday? If not, I think you will find these kernels from Koji to
otherwise be quite up-to-date:

http://koji.fedoraproject.org/koji/buildinfo?buildID=54043

Of course, the latest rawhide kernel (still building ATM) has the
latest wireless bits:

http://koji.fedoraproject.org/koji/buildinfo?buildID=54098

And if you don't want rawhide but still want the latest wireless bits,
there should be a new F9 kernel with those bits "soon" -- watch here:

http://koji.fedoraproject.org/koji/packageinfo?packageID=8

Hth!

John
--
John W. Linville
[email protected]

2008-06-28 18:57:33

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

T24gU2F0LCBKdW4gMjgsIDIwMDggYXQgODoxMCBBTSwgSm9obiBXLiBMaW52aWxsZQo8bGludmls
bGVAdHV4ZHJpdmVyLmNvbT4gd3JvdGU6Cj4gT24gU2F0LCBKdW4gMjgsIDIwMDggYXQgMDE6MjE6
NTRQTSArMDIwMCwgU3RlZmFuaWsgR8OhYm9yIHdyb3RlOgo+Cj4+IFRyeSBlZGl0aW5nIGRyaXZl
cnMvbmV0L3dpcmVsZXNzL2I0My9yZmtpbGwuYywgYW5kIHJlcGxhY2luZwo+PiBSRktJTExfU1RB
VEVfVU5CTE9DS0VEIHdpdGggUkZLSUxMX1NUQVRFX09OIGFuZAo+PiBSRktJTExfU1RBVEVfU09G
VF9CTE9DS0VEIHdpdGggUkZLSUxMX1NUQVRFX09GRi4gTG9va3MgbGlrZSByZmtpbGwgaXMKPj4g
bm90IHBhcnQgb2YgdGhlIGNvbXBhdCBwYWNrYWdlLCBhbmQgbm8gd29yayBoYXMgYmVlbiBkb25l
IHRvIG1hdGNoCj4+IGNvbXBhdC13aXJlbGVzcyB0byBvbGRlciBSRktJTExzLgo+Cj4gRldJVywg
cmZraWxsIHByb2JhYmx5IF9zaG91bGRfIGJlIGluIGNvbXBhdC13aXJlbGVzcy4gIEx1aXM/CgpJ
IGhhdmVuJ3QgaGFkIGEgY2hhbmNlIHRvIHBvcnQgcmZraWxsIHlldCBkb3duIHRvIDIuNi4yMi4g
SWYgc29tZW9uZQppcyBpbnRlcmVzdGVkIEknZCBiZSBnbGFkIHRvIGFjY2VwdCBwYXRjaGVzLgoK
ICBMdWlzCg==

2008-06-30 10:24:03

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

On Mon, Jun 30, 2008 at 1:21 AM, Luis R. Rodriguez <[email protected]> wrote:
> On Sat, Jun 28, 2008 at 6:33 PM, George Fong <[email protected]> wrote:
>> <snip>
>>
>> Dang :-) This was the fix.
>>
>>> Try editing drivers/net/wireless/b43/rfkill.c, and replacing
>>> RFKILL_STATE_UNBLOCKED with RFKILL_STATE_ON and
>>> RFKILL_STATE_SOFT_BLOCKED with RFKILL_STATE_OFF. Looks like rfkill is
>>> not part of the compat package, and no work has been done to match
>>> compat-wireless to older RFKILLs.
>>
>> Thank you for such prompt responses. Although I did this for the b43 driver, I
>> ended up progressively having to do the same fix for the drivers for a couple
>> more, ie iwlwifi and rxt200
>>
>> I am not concerned about the rxt200 but the driver I was interested in was the
>> iwl4965, so I am not sure that by changing the settings on iwl-rfkill.c I
>> have affected the driver I am using ....
>>
>>
>> Having said that... the email is brought to you courtesy of the iwl9645 wifi
>> device .. which has got to be a Good Thing ;-)
>>
>> Agree about the proper way of doing things - should really install a newer
>> kernel, but I am strapped into an nVidia graphics card on my laptop and the
>> livna drivers keep pace well but I think I risk breaking these at the moment
>> with the newer kernel.
>>
>> Thank you all for your prompt responses and asistance... on a weekend no
>> less :-) I'll monitor progress and contribute whatever little I can as I get
>> this new laptop settled.
>
> I've fixed this in compat-wireless, it should now compile fine for
> kernels <= 2.6.26.

Doh I had used < 2.6.26, I've now added this for <=. This RFKILL stuff
will be part of 2.6.27. Committed and pushed, in case you were trying
to compile compat-wireless on 2.6.26. New tarball will be generated
shortly.

Luis

2008-06-28 10:43:36

by Filippo Zangheri

[permalink] [raw]
Subject: Re: Problem making compat-wireless-2.6

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 28/06/2008 11:53, George Fong wrote:
> Hi guys
>=20
> Not sure if this is a bug but I have not been able to make the compat=
wireless=20
> drivers.
>=20
> I am running off Fedora 9 (x86_64) with kernel 2.6.25.6-55.fc9.x86_64=
=2E I am=20
> interested in the iwl4965 driver.

One simple solution would be to disable the building of unneeded
drivers by tuning your config.mk.

I suggest you to enable only the driver that you need.

Long answer, I don't know. Maybe some fix is needed to regain
compatibility. But, again, in your situation you can (and should for
efficienty's sake) forget about all the drivers that you don't care of.


> Everything goes OK until we hit the compilation of part of the b43 dr=
iver.=20
> This is what I get:
>=20
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless=
/b43/rfkill.c:=20
> In function =E2=80=98b43_rfkill_soft_toggle=E2=80=99:
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless=
/b43/rfkill.c:91:=20
> error: =E2=80=98RFKILL_STATE_UNBLOCKED=E2=80=99 undeclared (first use=
in this function)
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless=
/b43/rfkill.c:91:=20
> error: (Each undeclared identifier is reported only once
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless=
/b43/rfkill.c:91:=20
> error: for each function it appears in.)
> /home/george/Download/compat-wireless-2008-06-28/drivers/net/wireless=
/b43/rfkill.c:101:=20
> error: =E2=80=98RFKILL_STATE_SOFT_BLOCKED=E2=80=99 undeclared (first =
use in this function)
> make[4]: ***=20
> [/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireles=
s/b43/rfkill.o]=20
> Error 1
> make[3]: ***=20
> [/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireles=
s/b43]=20
> Error 2
> make[2]: ***=20
> [/home/george/Download/compat-wireless-2008-06-28/drivers/net/wireles=
s] Error=20
> 2
> make[1]: *** [_module_/home/george/Download/compat-wireless-2008-06-2=
8] Error=20
> 2
> make[1]: Leaving directory `/usr/src/kernels/2.6.25.6-55.fc9.x86_64'
> make: *** [modules] Error 2
>=20
> It is entirely likely that I am doing something wrong but I don't kno=
w what.
>=20
> Hope this is all OK to report.
>=20
> Cheers
> G,
>=20
>=20

Best regards.

- --
=46ilippo Zangheri

GPG key ID: 0x6C1F2F2F
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIZhXUjzxMG2wfLy8RArPXAKCE4whKT29GICQKZh92oXPGv3CVcACfZNPi
tdbmbFS9HLOuyYzo5jdvg2M=3D
=3De3gp
-----END PGP SIGNATURE-----