2008-07-01 20:22:13

by Larry Finger

[permalink] [raw]
Subject: Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA

After the latest wireless-testing update, b43 was unable to connect to
my WPA network. Bisection leads to the following commit as the culprit:

commit c4438fa71bf412862ed0b73111956b0ffd8209d3
Author: Harvey Harrison <[email protected]>
Date: Thu Jun 26 13:21:50 2008 -0700

mac80211: remove ieee80211_get_hdr_info

Move the address selection into the michale_mic header
calculation helper
and pass a pointer to the ieee80211_hdr directly.

Reorganize ccmp_special_blocks while eliminating the unneeded
sa/da/qos
variables.

Signed-off-by: Harvey Harrison <[email protected]>
Signed-off-by: John W. Linville <[email protected]>

:040000 040000 c77af99ab0477f3ec3159af8566fb1de61856ab8
7fa906d1d2acc6f9d88b923eed0990b9b14ea830 M net

This commit was confirmed as the problem by reverting it.

Larry


2008-07-01 20:47:03

by John W. Linville

[permalink] [raw]
Subject: Re: Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA

On Tue, Jul 01, 2008 at 03:23:36PM -0500, Larry Finger wrote:
> After the latest wireless-testing update, b43 was unable to connect to
> my WPA network. Bisection leads to the following commit as the culprit:
>
> commit c4438fa71bf412862ed0b73111956b0ffd8209d3
> Author: Harvey Harrison <[email protected]>
> Date: Thu Jun 26 13:21:50 2008 -0700
>
> mac80211: remove ieee80211_get_hdr_info
>
> Move the address selection into the michale_mic header calculation
> helper
> and pass a pointer to the ieee80211_hdr directly.
>
> Reorganize ccmp_special_blocks while eliminating the unneeded
> sa/da/qos
> variables.
>
> Signed-off-by: Harvey Harrison <[email protected]>
> Signed-off-by: John W. Linville <[email protected]>
>
> :040000 040000 c77af99ab0477f3ec3159af8566fb1de61856ab8
> 7fa906d1d2acc6f9d88b923eed0990b9b14ea830 M net
>
> This commit was confirmed as the problem by reverting it.

Luckily that is just in my "pending" stack. I'll revert it ASAP.
Harvey, you are welcome to resubmit if you can tell us what broke
things! :-)

John
--
John W. Linville
[email protected]

2008-07-01 21:14:00

by Harvey Harrison

[permalink] [raw]
Subject: Re: Commit c4438fa71bf412862ed0b73111956b0ffd8209d3 breaks WPA

On Tue, 2008-07-01 at 16:36 -0400, John W. Linville wrote:
> On Tue, Jul 01, 2008 at 03:23:36PM -0500, Larry Finger wrote:
> > 7fa906d1d2acc6f9d88b923eed0990b9b14ea830 M net
> >
> > This commit was confirmed as the problem by reverting it.
>
> Luckily that is just in my "pending" stack. I'll revert it ASAP.
> Harvey, you are welcome to resubmit if you can tell us what broke
> things! :-)
>

Will investigate it this evening.

Harvey