LinuxLists.cc - Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965

2008-07-22 10:49:17

Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965

(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).

On Tue, 22 Jul 2008 03:21:33 -0700 (PDT) [email protected] wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=11144
>
> Summary: dhcp doesn't work with iwl4965
> Product: Networking
> Version: 2.5
> KernelVersion: 2.6.26-git7
> Platform: All
> OS/Version: Linux
> Tree: Mainline
> Status: NEW
> Severity: normal
> Priority: P1
> Component: Wireless
> AssignedTo: [email protected]
> ReportedBy: [email protected]
>
>
> Latest working kernel version: 2.6.26-git6
> Earliest failing kernel version: 2.6.26-git7

A very fresh regression.

> Distribution: Gentoo
> Hardware Environment: Packard Bell MB86, iwl4965
> Software Environment: dhcpcd
> Problem Description:
> I can't get an IP address via DHCP with my wireless connection. I have an Intel
> Wireless 4965 card and I use WPA personal with AES encryption. After a
> git-bisect run, it seems the first bad commit is the following:
>
> commit 175f9c1bba9b825d22b142d183c9e175488b260c
> Author: Jussi Kivilinna <[email protected]>
> Date: Sun Jul 20 00:08:47 2008 -0700
>
> net_sched: Add size table for qdiscs
>
> Add size table functions for qdiscs and calculate packet size in
> qdisc_enqueue().
>
> Based on patch by Patrick McHardy
> http://marc.info/?l=linux-netdev&m=115201979221729&w=2
>
>

A whole pile of networking patches went into mainline about 12 hours
ago, one of which might have fixed this. Can you please test
2.6.26-git10 once it has appeared and let us know the result?

Thanks.

2008-07-23 15:18:54

by Patrick McHardy

[permalink] [raw]

Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965

diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 4dd3d93..e19815e 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -19,6 +19,7 @@
#include <linux/wireless.h>
#include <linux/device.h>
#include <linux/ieee80211.h>
+#include <net/sched_generic.h>
#include <net/wireless.h>
#include <net/cfg80211.h>

@@ -343,7 +344,10 @@ struct ieee80211_tx_info {

static inline struct ieee80211_tx_info *IEEE80211_SKB_CB(struct sk_buff *skb)
{
- return (struct ieee80211_tx_info *)skb->cb;
+ BUILD_BUG_ON(sizeof(skb->cb) <
+ sizeof(struct qdisc_skb_cb) +
+ sizeof(struct ieee80211_tx_info));
+ return (struct ieee80211_tx_info *)qdisc_skb_cb(skb)->data;
}

Attachments:

x (702.00 B)

2008-07-23 11:59:06

# Generated by iptables-save v1.3.8 on Sun May 4 17:48:03 2008
*filter
:INPUT ACCEPT [5:952]
:FORWARD ACCEPT [0:0]
:OUTPUT ACCEPT [1192099:595387635]

# accept all from localhost
-A INPUT -s 127.0.0.1 -j ACCEPT

# accept all previously established connections
-A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT

# ssh
-A INPUT -p tcp -m state --state NEW -m tcp --dport 22 -j ACCEPT

#web
-A INPUT -p tcp -m state --state NEW -m tcp --dport 80 -j ACCEPT

# ftp
-A INPUT -p tcp -m state --state NEW -m tcp --dport 20:21 -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 30000 -j ACCEPT

# Windows / Samba
-A INPUT -p tcp -m state --state NEW -m tcp --dport 137:139 -j ACCEPT
-A INPUT -p udp -m state --state NEW -m udp --dport 137:139 -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 426 -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 445 -j ACCEPT
#swat
-A INPUT -p tcp -m state --state NEW -m tcp --dport 902 -j ACCEPT

#aMule
-A INPUT -p tcp -m state --state NEW -m tcp --dport 4662 -j ACCEPT
-A INPUT -p udp -m state --state NEW -m udp --dport 4672 -j ACCEPT

#XDMCP
-A INPUT -p udp -m state --state NEW -m udp --dport 177 -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 6000 -j ACCEPT
-A INPUT -p udp -m state --state NEW -m udp --dport 41272 -j ACCEPT

#NFS server
-A INPUT -p tcp -m state --state NEW -m tcp --dport 111 -j ACCEPT
-A INPUT -p udp -m state --state NEW -m udp --dport 111 -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 2049 -j ACCEPT
-A INPUT -p udp -m state --state NEW -m udp --dport 2049 -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 4001 -j ACCEPT
-A INPUT -p udp -m state --state NEW -m udp --dport 4001 -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 4002 -j ACCEPT
-A INPUT -p udp -m state --state NEW -m udp --dport 4002 -j ACCEPT

#VNC server
-A INPUT -p tcp -m state --state NEW -m tcp --dport 5900:5901 -j ACCEPT

#CUPS server
-A INPUT -p tcp -m state --state NEW -m tcp --dport 631 -j ACCEPT

#distcc
-A INPUT -p tcp -m state --state NEW -m tcp --dport 3632 -j ACCEPT

#rsync
-A INPUT -p tcp -m state --state NEW -m tcp --dport 873 -j ACCEPT

#git
-A INPUT -p tcp -m state --state NEW -m tcp --dport 9418 -j ACCEPT

#ping
-A INPUT -p icmp -j ACCEPT

#IPSec
-A INPUT -p udp --dport 500 -m state --state NEW -j ACCEPT
-A OUTPUT -p udp --dport 500 -m state --state NEW -j ACCEPT

-A INPUT -p esp -j ACCEPT
-A OUTPUT -p esp -j ACCEPT

-A INPUT -p ah -j ACCEPT
-A OUTPUT -p ah -j ACCEPT

#reject everything else
-A INPUT -j REJECT --reject-with icmp-port-unreachable

COMMIT

Attachments:

iptables (2.55 kB)

2008-07-22 10:52:23

by Patrick McHardy

[permalink] [raw]

Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965

Andrew Morton wrote:
> (switched to email. Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
>
> On Tue, 22 Jul 2008 03:21:33 -0700 (PDT) [email protected] wrote:
>
>> http://bugzilla.kernel.org/show_bug.cgi?id=11144
>>
>> Summary: dhcp doesn't work with iwl4965

>> Latest working kernel version: 2.6.26-git6
>> Earliest failing kernel version: 2.6.26-git7
>
> A very fresh regression.
>
>> Distribution: Gentoo
>> Hardware Environment: Packard Bell MB86, iwl4965
>> Software Environment: dhcpcd
>> Problem Description:
>> I can't get an IP address via DHCP with my wireless connection. I have an Intel
>> Wireless 4965 card and I use WPA personal with AES encryption. After a
>> git-bisect run, it seems the first bad commit is the following:
>>
>> commit 175f9c1bba9b825d22b142d183c9e175488b260c
>> Author: Jussi Kivilinna <[email protected]>
>> Date: Sun Jul 20 00:08:47 2008 -0700
>>
>> net_sched: Add size table for qdiscs
>>
>> Add size table functions for qdiscs and calculate packet size in
>> qdisc_enqueue().
>>

This implies you're running shaping on your WLAN device. Please
post the rules you're using.

2008-07-30 18:04:36

by François Valenduc

[permalink] [raw]

Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965

Johannes Berg a =E9crit :
> On Thu, 2008-07-24 at 14:35 +0300, Tomas Winkler wrote:
>
> =20
>>>> Isn't this time to make 802.11 native?
>>>> =20
>>> You mean by making these things real skb members? I hope you're
>>> not talking about the entire 48 bytes? :)
>>> =20
>> I mean elevating 802.11 header to 802.3 level. Not doing 802.3 ->
>> 802.11 translation where not needed.
>> =20
>
>
> We've discussed that over and over and over and over again, and it's =
not
> going to fly since 802.11 throughout assumes that you have a two-addr=
ess
> data service to the upper layers.
>
> Besides, making it 802.11 native doesn't help with the control
> information at all.
>
> johannes
> =20
It seems the patch you made an available at=20
http://lkml.org/lkml/2008/7/29/153 solves my problem. DHCP works again=20
if I apply it on kernel 2.6.27-rc1.

=46ran=E7ois

2008-07-24 11:46:59

On Wed, 23 Jul 2008 09:58:21 +0200 Fran__ois Valenduc <[email protected]> wrote:

> P.S: why don't you want to use the bugzilla interface ?

Depends on the subsystem. ACPI is 100% bugzilla-based, net people
prefer email, others are in-between.

Plus for recently-occurring bugs it's best to knock them over via email
without getting into bugzilla bureaucracy. bugzilla is more
appropriate to longer-term bugs.

And when the bug affects multiple subsystems, multiple
developers and we don't even know which subsystem introduced it, it is
much better to perform the diagnosis and repair via email.

I make a judgement call on each report. Been doing it for a while,
don't get too many complaints ;)

2008-07-23 15:19:49

by Patrick McHardy

[permalink] [raw]

Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965

diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 4dd3d93..e19815e 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -19,6 +19,7 @@
#include <linux/wireless.h>
#include <linux/device.h>
#include <linux/ieee80211.h>
+#include <net/sch_generic.h>
#include <net/wireless.h>
#include <net/cfg80211.h>

@@ -343,7 +344,10 @@ struct ieee80211_tx_info {

static inline struct ieee80211_tx_info *IEEE80211_SKB_CB(struct sk_buff *skb)
{
- return (struct ieee80211_tx_info *)skb->cb;
+ BUILD_BUG_ON(sizeof(skb->cb) <
+ sizeof(struct qdisc_skb_cb) +
+ sizeof(struct ieee80211_tx_info));
+ return (struct ieee80211_tx_info *)qdisc_skb_cb(skb)->data;
}

Attachments:

x (700.00 B)

2008-07-23 12:36:44

Patrick McHardy a =E9crit :
> Fran=E7ois Valenduc wrote:
>> OK, thanks for the explanation. But do you have more ideas about the=
=20
>> problem ?
>
> I tested myself using dhcpcd 3.2.3 on an ethernet device and it
> works fine, so this appears to be driver related.
>
>

I also noticed that DHCP works without problem with my ethernet card=20
(using the sky2 driver), so there seems to be a problem or conflict wit=
h=20
the iwl4965 driver. However, if I use dhclient instead of dhcpcd, I can=
=20
get an IP adress with DHCP and the DNS servers are correctly written in=
=20
/etc/resolv.conf. Unfortunately, name resolution doesn't work, even if =
I=20
can ping the DNS server.

=20