2008-12-05 18:43:01

by Jouni Malinen

Subject: [PATCH] ath9k: Free Beacon skbs in AP mode

Fix a memory leak where AP mode did not free transmitted Beacon frame
skbs.

Signed-off-by: Jouni Malinen <[email protected]>

Index: wireless-testing/drivers/net/wireless/ath9k/beacon.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:37:37.000000000 +0200
+++ wireless-testing/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:38:41.000000000 +0200
@@ -167,6 +167,7 @@
pci_unmap_single(sc->pdev, bf->bf_dmacontext,
skb->len,
PCI_DMA_TODEVICE);
+ dev_kfree_skb_any(skb);
}

skb = ieee80211_beacon_get(sc->hw, vif);

--
Jouni Malinen PGP id EFC895FA

2008-12-06 03:07:54

by Pat Erley

Subject: Re: [PATCH] ath9k: Free Beacon skbs in AP mode

Jouni Malinen wrote:
> Fix a memory leak where AP mode did not free transmitted Beacon frame
> skbs.
>
> Signed-off-by: Jouni Malinen <[email protected]>
>
> Index: wireless-testing/drivers/net/wireless/ath9k/beacon.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:37:37.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/ath9k/beacon.c 2008-12-05 18:38:41.000000000 +0200
> @@ -167,6 +167,7 @@
> pci_unmap_single(sc->pdev, bf->bf_dmacontext,
> skb->len,
> PCI_DMA_TODEVICE);
> + dev_kfree_skb_any(skb);
> }
>
> skb = ieee80211_beacon_get(sc->hw, vif);
>

Acked-by: Pat Erley <[email protected]>

I've been using ath9k in master mode for a few weeks and
had noticed a severe memory leak (kill a gig of ram system in about a
day). Figured it was just in hostapd, and haven't had time to track it
down.