2009-04-13 20:29:26

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: [PATCH RFC] rtl8187: Call 8187L variants "RTL8187LvX" rather than "RTL8187vX"


--- On Mon, 13/4/09, G=E1bor Stefanik <[email protected]> wrote:

> We call RTL8187B chips "RTL8187BvX"
> (X is the revision), so we should
> call RTL8187L ones "RTL8187LvX", not "RTL8187vX".
>=20
> Signed-off-by: G=E1bor Stefanik <[email protected]>

Acked-by: Hin-Tak Leung <[email protected]>

I don't have a preference either way - if any, I would probably prefer =
without the change, or use a space for readability rather than 'L', bec=
ause the 'L' just isn't there most of the time, and there is B (which i=
s similiar but not the same) and SE (which is completely different). It=
might be worth also to put a space after the B's.

The way that string is currently done is largely inherited from the ven=
dor driver, I think.



=20


2009-04-14 00:43:41

by Gábor Stefanik

[permalink] [raw]
Subject: Re: [PATCH RFC] rtl8187: Call 8187L variants "RTL8187LvX" rather than "RTL8187vX"

2009/4/14 Larry Finger <[email protected]>:
> G=E1bor Stefanik wrote:
>> What do you mean by "the 'L' just isn't there most of the time"? AFA=
IK
>> there is no RTL8187 chip (without a letter suffix), only RTL8187L,
>> RTL8187B and RTL8187SE, and 8187L is not much more common that 8187B=
,
>> to warrant calling it "RTL8187" in any case.
>>
>
> For some reason, that is exactly what the vendor driver does. There a=
re several
> places that refer to RTL8187B, but nowhere do they talk about the RTL=
8187. They
> do, however, refer to the RTL8187L as the chip name on their Web pile=
=2E
>
> Larry

The actual chips also have RTL8187L printed on them.

--G=E1bor


--=20
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2009-04-13 23:49:21

by Gábor Stefanik

[permalink] [raw]
Subject: Re: [PATCH RFC] rtl8187: Call 8187L variants "RTL8187LvX" rather than "RTL8187vX"

On Mon, Apr 13, 2009 at 10:29 PM, Hin-Tak Leung
<[email protected]> wrote:
>
> --- On Mon, 13/4/09, G=E1bor Stefanik <[email protected]> wrote=
:
>
>> We call RTL8187B chips "RTL8187BvX"
>> (X is the revision), so we should
>> call RTL8187L ones "RTL8187LvX", not "RTL8187vX".
>>
>> Signed-off-by: G=E1bor Stefanik <[email protected]>
>
> Acked-by: Hin-Tak Leung <[email protected]>
>
> I don't have a preference either way - if any, I would probably prefe=
r without the change, or use a space for readability rather than 'L', b=
ecause the 'L' just isn't there most of the time, and there is B (which=
is similiar but not the same) and SE (which is completely different). =
It might be worth also to put a space after the B's.
>
> The way that string is currently done is largely inherited from the v=
endor driver, I think.

What do you mean by "the 'L' just isn't there most of the time"? AFAIK
there is no RTL8187 chip (without a letter suffix), only RTL8187L,
RTL8187B and RTL8187SE, and 8187L is not much more common that 8187B,
to warrant calling it "RTL8187" in any case.

--=20
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2009-04-14 00:25:31

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH RFC] rtl8187: Call 8187L variants "RTL8187LvX" rather than "RTL8187vX"

G=E1bor Stefanik wrote:
> What do you mean by "the 'L' just isn't there most of the time"? AFAI=
K
> there is no RTL8187 chip (without a letter suffix), only RTL8187L,
> RTL8187B and RTL8187SE, and 8187L is not much more common that 8187B,
> to warrant calling it "RTL8187" in any case.
>=20

=46or some reason, that is exactly what the vendor driver does. There a=
re several
places that refer to RTL8187B, but nowhere do they talk about the RTL81=
87. They
do, however, refer to the RTL8187L as the chip name on their Web pile.

Larry