--- On Fri, 17/4/09, Larry Finger <[email protected]> wrote:
> > You can add Signed-off-by: Herton Ronaldo Krzesinski
> <[email protected]>
>
> > to the patch (or Tested-by/Reviewed-by, what's more
> appropriate, now hopefully
> > we will have the last version of the patch :) )
>
> I think a signed-off-by is appropriate. I usually get it
> right in 4 tries. ;)
So there is going to be a V5? V4 tested ok here - I mean it doesn't break anything, since my device is built-in and doesn't have an LED. I'll have a tested-by or acked-by - I think acked-by is the minimal "okay, your e-mail didn't get lost" thing.
Hin-Tak Leung wrote:
>
> So there is going to be a V5? V4 tested ok here - I mean it doesn't break anything, since my device is built-in and doesn't have an LED. I'll have a tested-by or acked-by - I think acked-by is the minimal "okay, your e-mail didn't get lost" thing.
>
No, I think that it is ready to be submitted. I also checked that it compiles OK
when the conditions are such that CONFIG_RTL8187_LED is not defined.
Do we have any information on how that radio LED is activated on your device?
Presumably, that customer code of 0xo4 has some significance. Do you have a
radio on/off switch, or how is it activated. I know that Johannes is working on
the rfkill setup on Toshiba notebooks. Perhaps that will show something. When he
has that ready, I'll send you a patch to see if we get any events through a
radio LED when the radio is activated/deactivated.
Larry