2009-02-09 22:34:03

by Tobias Klauser

[permalink] [raw]
Subject: [PATCH] ath5k: Storage class should be before const qualifier

The C99 specification states in section 6.11.5:

The placement of a storage-class specifier other than at the beginning
of the declaration specifiers in a declaration is an obsolescent
feature.

Signed-off-by: Tobias Klauser <[email protected]>
---
drivers/net/wireless/ath5k/eeprom.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath5k/eeprom.c b/drivers/net/wireless/ath5k/eeprom.c
index 1cb7edf..c5e03a6 100644
--- a/drivers/net/wireless/ath5k/eeprom.c
+++ b/drivers/net/wireless/ath5k/eeprom.c
@@ -491,9 +491,9 @@ ath5k_eeprom_init_modes(struct ath5k_hw *ah)
static inline void
ath5k_get_pcdac_intercepts(struct ath5k_hw *ah, u8 min, u8 max, u8 *vp)
{
- const static u16 intercepts3[] =
+ static const u16 intercepts3[] =
{ 0, 5, 10, 20, 30, 50, 70, 85, 90, 95, 100 };
- const static u16 intercepts3_2[] =
+ static const u16 intercepts3_2[] =
{ 0, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100 };
const u16 *ip;
int i;
--
1.5.6.5



2009-02-09 22:09:17

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH] ath5k: Storage class should be before const qualifier

On 02/09/2009 11:05 PM, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <[email protected]>

Acked-by: Jiri Slaby <[email protected]>


2009-04-26 19:11:25

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH] ath5k: Storage class should be before const qualifier

On 04/26/2009 02:58 PM, Tobias Klauser wrote:
> commit 8e218fb24faef0bfe95bc91b3c05261e20439527 reverted the previous
> patch (commit 925be8a3077351edbf2b59ca689105df214a0792).

Ok, once again :):
Acked-by: Jiri Slaby <[email protected]>