2009-06-20 03:53:38

by Larry Finger

[permalink] [raw]
Subject: Question about rfkill

Johannes,

What is the reason that rfkill_get_global_sw_state() is not exported?
A call to this routine seems to be the ideal replacement for the
deprecated radio_enabled.

Larry


2009-06-20 12:59:16

by Larry Finger

[permalink] [raw]
Subject: Re: Question about rfkill

Johannes,

> No need, radio_enabled is intended to be removed, because if you rfkill
> now cfg80211 will force the interfaces down. Some time later way may
> need to add a way to disable just the radio again, but that will be
> different and for different purposes.

In b43/b43legacy, the driver can determine when the hw has required an
rfkill, but what is the "approved" method for determining if userspace
has killed it?

Larry


2009-06-20 13:14:40

by Johannes Berg

[permalink] [raw]
Subject: Re: Question about rfkill

On Sat, 2009-06-20 at 07:59 -0500, Larry Finger wrote:
> Johannes,
>
> > No need, radio_enabled is intended to be removed, because if you rfkill
> > now cfg80211 will force the interfaces down. Some time later way may
> > need to add a way to disable just the radio again, but that will be
> > different and for different purposes.
>
> In b43/b43legacy, the driver can determine when the hw has required an
> rfkill, but what is the "approved" method for determining if userspace
> has killed it?

That isn't necessary. In that case, cfg80211 notices that it was killed,
and (via mac80211) ends up calling the ->stop() callback.

johannes


Attachments:
signature.asc (801.00 B)
This is a digitally signed message part

2009-06-20 11:34:13

by Johannes Berg

[permalink] [raw]
Subject: Re: Question about rfkill

Larry,

> What is the reason that rfkill_get_global_sw_state() is not exported?
> A call to this routine seems to be the ideal replacement for the
> deprecated radio_enabled.

No need, radio_enabled is intended to be removed, because if you rfkill
now cfg80211 will force the interfaces down. Some time later way may
need to add a way to disable just the radio again, but that will be
different and for different purposes.

johannes


Attachments:
signature.asc (801.00 B)
This is a digitally signed message part