2009-07-16 23:16:07

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [KARMIC] review these for rt2x00 (adds rt2800pci)

On Thu, Jul 16, 2009 at 9:56 AM, Stefan Bader<[email protected]> wrote:
> At least this seems to be material for 3 or 4 patches
> - adapt the rfkill stuff
> - some documentation update
> - add the new pci version of the 2800 (with that rt2x00soc lib
>   which might be another patch)
> - and some fixes...

Not only that but this driver is not yet merged upstream, there should
be a good reason for that.

Ivo, what's the status on rt2800pci? Some users have been asking about it.

Luis


2009-07-17 16:36:09

by Ivo Van Doorn

[permalink] [raw]
Subject: Re: [KARMIC] review these for rt2x00 (adds rt2800pci)

On Friday 17 July 2009, Luis R. Rodriguez wrote:
> On Fri, Jul 17, 2009 at 1:00 AM, Stefan Bader<[email protected]> wrote:
> > Ivo Van Doorn wrote:
> >>
> >> On Fri, Jul 17, 2009 at 1:15 AM, Luis R. Rodriguez<[email protected]>
> >> wrote:
> >>>
> >>> On Thu, Jul 16, 2009 at 9:56 AM, Stefan Bader<[email protected]>
> >>> wrote:
> >>>>
> >>>> At least this seems to be material for 3 or 4 patches
> >>>> - adapt the rfkill stuff
> >>>> - some documentation update
> >>>> - add the new pci version of the 2800 (with that rt2x00soc lib
> >>>>  which might be another patch)
> >>>> - and some fixes...
> >>>
> >>> Not only that but this driver is not yet merged upstream, there should
> >>> be a good reason for that.
> >>>
> >>> Ivo, what's the status on rt2800pci? Some users have been asking about
> >>> it.
> >>
> >> The status is that it is not functioning correctly, during boot it
> >> will print out
> >> tons of errors about the device not being ready, and afterward it cannot
> >> scan,
> >> connect or do anything useful.
> >>
> >> And I think those problems can be considered enough reasons for not
> >> merging
> >> the driver upstream yet. ;)
> >>
> >> Ivo
> >
> > I would say so. :) Assuming there is a bit of truth in those claims of that
> > tarball working better than the current kernel code, we might take away all
> > the new driver bloat and see what remains (which might be the part Ivo has
> > anyways in wireless testing...)
>
> Its not part of wireless-testing.

Well any patches in rt2x00.git which I have not send to linux-wireless yet
should _not_ be merged to anywhere since they are often incomplete,
incorrect or plain broken.

Ivo

2009-07-17 16:00:59

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [KARMIC] review these for rt2x00 (adds rt2800pci)

On Fri, Jul 17, 2009 at 1:00 AM, Stefan Bader<[email protected]> wrote:
> Ivo Van Doorn wrote:
>>
>> On Fri, Jul 17, 2009 at 1:15 AM, Luis R. Rodriguez<[email protected]>
>> wrote:
>>>
>>> On Thu, Jul 16, 2009 at 9:56 AM, Stefan Bader<[email protected]>
>>> wrote:
>>>>
>>>> At least this seems to be material for 3 or 4 patches
>>>> - adapt the rfkill stuff
>>>> - some documentation update
>>>> - add the new pci version of the 2800 (with that rt2x00soc lib
>>>>  which might be another patch)
>>>> - and some fixes...
>>>
>>> Not only that but this driver is not yet merged upstream, there should
>>> be a good reason for that.
>>>
>>> Ivo, what's the status on rt2800pci? Some users have been asking about
>>> it.
>>
>> The status is that it is not functioning correctly, during boot it
>> will print out
>> tons of errors about the device not being ready, and afterward it cannot
>> scan,
>> connect or do anything useful.
>>
>> And I think those problems can be considered enough reasons for not
>> merging
>> the driver upstream yet. ;)
>>
>> Ivo
>
> I would say so. :) Assuming there is a bit of truth in those claims of that
> tarball working better than the current kernel code, we might take away all
> the new driver bloat and see what remains (which might be the part Ivo has
> anyways in wireless testing...)

Its not part of wireless-testing.

Luis

2009-07-17 08:01:00

by Stefan Bader

[permalink] [raw]
Subject: Re: [KARMIC] review these for rt2x00 (adds rt2800pci)

Ivo Van Doorn wrote:
> On Fri, Jul 17, 2009 at 1:15 AM, Luis R. Rodriguez<[email protected]> wrote:
>> On Thu, Jul 16, 2009 at 9:56 AM, Stefan Bader<[email protected]> wrote:
>>> At least this seems to be material for 3 or 4 patches
>>> - adapt the rfkill stuff
>>> - some documentation update
>>> - add the new pci version of the 2800 (with that rt2x00soc lib
>>> which might be another patch)
>>> - and some fixes...
>> Not only that but this driver is not yet merged upstream, there should
>> be a good reason for that.
>>
>> Ivo, what's the status on rt2800pci? Some users have been asking about it.
>
> The status is that it is not functioning correctly, during boot it
> will print out
> tons of errors about the device not being ready, and afterward it cannot scan,
> connect or do anything useful.
>
> And I think those problems can be considered enough reasons for not merging
> the driver upstream yet. ;)
>
> Ivo

I would say so. :) Assuming there is a bit of truth in those claims of that
tarball working better than the current kernel code, we might take away all the
new driver bloat and see what remains (which might be the part Ivo has anyways
in wireless testing...)

Stefan

--

When all other means of communication fail, try words!



2009-07-17 07:11:16

by Ivo Van Doorn

[permalink] [raw]
Subject: Re: [KARMIC] review these for rt2x00 (adds rt2800pci)

On Fri, Jul 17, 2009 at 1:15 AM, Luis R. Rodriguez<[email protected]> wrote:
> On Thu, Jul 16, 2009 at 9:56 AM, Stefan Bader<[email protected]> wrote:
>> At least this seems to be material for 3 or 4 patches
>> - adapt the rfkill stuff
>> - some documentation update
>> - add the new pci version of the 2800 (with that rt2x00soc lib
>> ? which might be another patch)
>> - and some fixes...
>
> Not only that but this driver is not yet merged upstream, there should
> be a good reason for that.
>
> Ivo, what's the status on rt2800pci? Some users have been asking about it.

The status is that it is not functioning correctly, during boot it
will print out
tons of errors about the device not being ready, and afterward it cannot scan,
connect or do anything useful.

And I think those problems can be considered enough reasons for not merging
the driver upstream yet. ;)

Ivo

2009-07-17 16:54:15

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [KARMIC] review these for rt2x00 (adds rt2800pci)

On Fri, Jul 17, 2009 at 9:36 AM, Ivo van Doorn<[email protected]> wrote:
> On Friday 17 July 2009, Luis R. Rodriguez wrote:
>> On Fri, Jul 17, 2009 at 1:00 AM, Stefan Bader<[email protected]> wrote:
>> > Ivo Van Doorn wrote:
>> >>
>> >> On Fri, Jul 17, 2009 at 1:15 AM, Luis R. Rodriguez<[email protected]>
>> >> wrote:
>> >>>
>> >>> On Thu, Jul 16, 2009 at 9:56 AM, Stefan Bader<[email protected]>
>> >>> wrote:
>> >>>>
>> >>>> At least this seems to be material for 3 or 4 patches
>> >>>> - adapt the rfkill stuff
>> >>>> - some documentation update
>> >>>> - add the new pci version of the 2800 (with that rt2x00soc lib
>> >>>>  which might be another patch)
>> >>>> - and some fixes...
>> >>>
>> >>> Not only that but this driver is not yet merged upstream, there should
>> >>> be a good reason for that.
>> >>>
>> >>> Ivo, what's the status on rt2800pci? Some users have been asking about
>> >>> it.
>> >>
>> >> The status is that it is not functioning correctly, during boot it
>> >> will print out
>> >> tons of errors about the device not being ready, and afterward it cannot
>> >> scan,
>> >> connect or do anything useful.
>> >>
>> >> And I think those problems can be considered enough reasons for not
>> >> merging
>> >> the driver upstream yet. ;)
>> >>
>> >> Ivo
>> >
>> > I would say so. :) Assuming there is a bit of truth in those claims of that
>> > tarball working better than the current kernel code, we might take away all
>> > the new driver bloat and see what remains (which might be the part Ivo has
>> > anyways in wireless testing...)
>>
>> Its not part of wireless-testing.
>
> Well any patches in rt2x00.git which I have not send to linux-wireless yet
> should _not_ be merged to anywhere since they are often incomplete,
> incorrect or plain broken.

Thanks Ivo -- that is what I suspected. Please do not merge wireless
shit into karmic unless upstream. If its really shit then please push
to staging.

Luis