2009-08-10 22:54:28

by Gábor Stefanik

Subject: [PATCH] b43: Fix a typo in the sync_stx routine

I completely missed the "one's complement" instruction from the specs.

Signed-off-by: Gábor Stefanik <[email protected]>
---
drivers/net/wireless/b43/phy_lp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c
index 46fe476..34ad738 100644
--- a/drivers/net/wireless/b43/phy_lp.c
+++ b/drivers/net/wireless/b43/phy_lp.c
@@ -578,7 +578,7 @@ static void lpphy_sync_stx(struct b43_wldev *dev)
tmp >>= e->rf_shift;
tmp <<= e->phy_shift;
b43_phy_maskset(dev, B43_PHY_OFDM(0xF2 + e->phy_offset),
- e->mask << e->phy_shift, tmp);
+ ~(e->mask << e->phy_shift), tmp);
}
}

--
1.6.2.4

2009-08-10 23:14:32

by Larry Finger

Subject: Re: [PATCH] b43: Fix a typo in the sync_stx routine

Gábor Stefanik wrote:
> I completely missed the "one's complement" instruction from the specs.
>
> Signed-off-by: Gábor Stefanik <[email protected]>
> ---
> drivers/net/wireless/b43/phy_lp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/b43/phy_lp.c
> b/drivers/net/wireless/b43/phy_lp.c
> index 46fe476..34ad738 100644
> --- a/drivers/net/wireless/b43/phy_lp.c
> +++ b/drivers/net/wireless/b43/phy_lp.c
> @@ -578,7 +578,7 @@ static void lpphy_sync_stx(struct b43_wldev *dev)
> tmp >>= e->rf_shift;
> tmp <<= e->phy_shift;
> b43_phy_maskset(dev, B43_PHY_OFDM(0xF2 + e->phy_offset),
> - e->mask << e->phy_shift, tmp);
> + ~(e->mask << e->phy_shift), tmp);
> }
> }
>

I should have caught that one.

When debugging gets started, it might be useful to add a statement

WARN_ON(mask & set);

at the start of b43_radio_maskset() and b43_phy_maskset(). That way
these kind of mistakes will be caught early.

Larry