2009-08-15 05:46:47

by Philip Prindeville

[permalink] [raw]
Subject: [PATCH] Don't build PCMCIA modules when PCMCIA isn't present

From: Philip A Prindeville <[email protected]>

If you're building for a platform that has (for example) no PCMCIA/
Cardbus, then having a single knob to turn to disable this is a
major win. Especially if more devices get add later that are
PCMCIA-based.

Tested.

Signed-off-by: Philip A Prindeville <[email protected]>
---
config.mk | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/config.mk b/config.mk
index 0c3ea98..a24b7bd 100644
--- a/config.mk
+++ b/config.mk
@@ -191,7 +191,9 @@ CONFIG_B43=m
CONFIG_B43_HWRNG=y
CONFIG_B43_PCI_AUTOSELECT=y
CONFIG_B43_PCICORE_AUTOSELECT=y
+ifneq ($(CONFIG_PCMCIA),)
CONFIG_B43_PCMCIA=y
+endif
CONFIG_B43_PIO=y
CONFIG_B43_LEDS=y
CONFIG_B43_RFKILL=y
@@ -242,8 +244,10 @@ CONFIG_SSB_BLOCKIO=y
CONFIG_SSB_PCIHOST_POSSIBLE=y
CONFIG_SSB_PCIHOST=y
CONFIG_SSB_B43_PCI_BRIDGE=y
+ifneq ($(CONFIG_PCMCIA),)
CONFIG_SSB_PCMCIAHOST_POSSIBLE=y
CONFIG_SSB_PCMCIAHOST=y
+endif
# CONFIG_SSB_DEBUG=y
CONFIG_SSB_DRIVER_PCICORE_POSSIBLE=y
CONFIG_SSB_DRIVER_PCICORE=y
@@ -258,7 +262,9 @@ CONFIG_B44_PCI=y
CONFIG_RTL8180=m

CONFIG_ADM8211=m
+ifneq ($(CONFIG_PCMCIA),)
CONFIG_PCMCIA_ATMEL=m
+endif

CONFIG_RT2X00_LIB_PCI=m
CONFIG_RT2400PCI=m



2009-08-18 23:34:44

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [PATCH] Don't build PCMCIA modules when PCMCIA isn't present

On Fri, Aug 14, 2009 at 10:46 PM, Philip A.
Prindeville<[email protected]> wrote:
> From: Philip A Prindeville <[email protected]>
>
> If you're building for a platform that has (for example) no PCMCIA/
> Cardbus, then having a single knob to turn to disable this is a
> major win.  Especially if more devices get add later that are
> PCMCIA-based.

Applied, thanks Phillip.

Luis