2009-09-30 12:36:38

by Daniel J Blueman

[permalink] [raw]
Subject: Re: ath5k suspend

Hi Gonsolo,

On Tue, Sep 29, 2009 at 4:44 PM, Gonsolo <[email protected]> wrote:
> Hi!
>
> Is it possible to add
> http://patchwork.kernel.org/patch/38550/
> to karmic? Otherwise karmic would be broken for me/my notebook/my
> wireless pccard.

Since Karmic tracks the 2.6.31 -stable kernels, it's worth reporting
this upstream (CC'd) instead, particularly if it's a regression from a
previous kernel version, using the same ath5k driver...?

Then, it'll be in Karmic in ~ a few weeks.

Daniel
--
Daniel J Blueman


2009-09-30 13:26:59

by Gonsolo

[permalink] [raw]
Subject: Re: ath5k suspend

>> Is it possible to add
>> http://patchwork.kernel.org/patch/38550/
>> to karmic? Otherwise karmic would be broken for me/my notebook/my
>> wireless pccard.
>
> Since Karmic tracks the 2.6.31 -stable kernels, it's worth reporting
> this upstream (CC'd) instead, particularly if it's a regression from a
> previous kernel version, using the same ath5k driver...?

I did that, too. ;) Hopefully it will be in 2.6.31.2.

g

2009-09-30 14:15:52

by John W. Linville

[permalink] [raw]
Subject: Re: ath5k suspend

On Wed, Sep 30, 2009 at 03:26:56PM +0200, Gonsolo wrote:
>>> Is it possible to add
>>> http://patchwork.kernel.org/patch/38550/
>>> to karmic? Otherwise karmic would be broken for me/my notebook/my
>>> wireless pccard.
>>
>> Since Karmic tracks the 2.6.31 -stable kernels, it's worth reporting
>> this upstream (CC'd) instead, particularly if it's a regression from a
>> previous kernel version, using the same ath5k driver...?
>
> I did that, too. ;) Hopefully it will be in 2.6.31.2.

Maybe I missed it, but did you actually request the -stable team to
take the patch? -stable helps more than just Ubuntu... :-)

Greg (or Chris or...), the patch in question is here:

commit edd7fc7003f31da48d06e215a93ea966a22c2a03
Author: Nick Kossifidis <[email protected]>
Date: Mon Aug 10 03:29:02 2009 +0300

ath5k: Wakeup fixes

* Don't put chip to full sleep because there are problems during
wakeup. Instead hold MAC/Baseband on warm reset state via a new
function ath5k_hw_on_hold.

* Minor cleanups

Signed-off-by: Nick Kossifidis <[email protected]>
Tested-by: Ben Greear <[email protected]>
Tested-by: Johannes Stezenbach <[email protected]>
Signed-off-by: John W. Linville <[email protected]>

--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2009-09-30 14:30:51

by John W. Linville

[permalink] [raw]
Subject: Re: ath5k suspend

On Wed, Sep 30, 2009 at 04:25:10PM +0200, Gonsolo wrote:
> Am 30.09.2009 16:09, schrieb John W. Linville:
>> On Wed, Sep 30, 2009 at 03:26:56PM +0200, Gonsolo wrote:
>>>>> Is it possible to add
>>>>> http://patchwork.kernel.org/patch/38550/
>>>>> to karmic? Otherwise karmic would be broken for me/my notebook/my
>>>>> wireless pccard.
>>>>
>>>> Since Karmic tracks the 2.6.31 -stable kernels, it's worth reporting
>>>> this upstream (CC'd) instead, particularly if it's a regression from a
>>>> previous kernel version, using the same ath5k driver...?
>>>
>>> I did that, too. ;) Hopefully it will be in 2.6.31.2.
>>
>> Maybe I missed it, but did you actually request the -stable team to
>> take the patch? -stable helps more than just Ubuntu... :-)
>
> I requested it in Ubuntu and stable in two separate emails, just to be
> sure it will be there when I am going to upgrade. ;)
> I apologize if I caused confusion or doubled your amount of work.
> Maybe I should have done this in one email to both parties.

Not really a big deal -- still, one email would tend to reduce confusion. :-)

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2009-09-30 14:25:12

by Gonsolo

[permalink] [raw]
Subject: Re: ath5k suspend

Am 30.09.2009 16:09, schrieb John W. Linville:
> On Wed, Sep 30, 2009 at 03:26:56PM +0200, Gonsolo wrote:
>>>> Is it possible to add
>>>> http://patchwork.kernel.org/patch/38550/
>>>> to karmic? Otherwise karmic would be broken for me/my notebook/my
>>>> wireless pccard.
>>>
>>> Since Karmic tracks the 2.6.31 -stable kernels, it's worth reporting
>>> this upstream (CC'd) instead, particularly if it's a regression from a
>>> previous kernel version, using the same ath5k driver...?
>>
>> I did that, too. ;) Hopefully it will be in 2.6.31.2.
>
> Maybe I missed it, but did you actually request the -stable team to
> take the patch? -stable helps more than just Ubuntu... :-)

I requested it in Ubuntu and stable in two separate emails, just to be
sure it will be there when I am going to upgrade. ;)
I apologize if I caused confusion or doubled your amount of work.
Maybe I should have done this in one email to both parties.

g