2009-11-02 17:15:13

by Luis R. Rodriguez

Subject: [PATCH] wl1271: use __dev_alloc_skb() on RX

RX is handled in a workqueue therefore allocating for GFP_ATOMIC
is overkill and not required.

Signed-off-by: Luis R. Rodriguez <[email protected]>
Acked-by: Luciano Coelho <[email protected]>
---
drivers/net/wireless/wl12xx/wl1271_rx.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/wl1271_rx.c b/drivers/net/wireless/wl12xx/wl1271_rx.c
index 37d81ab..ca645f3 100644
--- a/drivers/net/wireless/wl12xx/wl1271_rx.c
+++ b/drivers/net/wireless/wl12xx/wl1271_rx.c
@@ -159,7 +159,7 @@ static void wl1271_rx_handle_data(struct wl1271 *wl, u32 length)
u8 *buf;
u8 beacon = 0;

- skb = dev_alloc_skb(length);
+ skb = __dev_alloc_skb(length, GFP_KERNEL);
if (!skb) {
wl1271_error("Couldn't allocate RX frame");
return;
--
1.6.0.4

2009-11-02 17:16:33

by Luciano Coelho

Subject: Re: [PATCH] wl1271: use __dev_alloc_skb() on RX

ext Luis R. Rodriguez wrote:
> RX is handled in a workqueue therefore allocating for GFP_ATOMIC
> is overkill and not required.
>
> Signed-off-by: Luis R. Rodriguez <[email protected]>
> Acked-by: Luciano Coelho <[email protected]>
> ---

Thank you very much, Luis!

--
Cheers,
Luca.