Follow the precepts of the ralink drivers.
(0x050d, 0x7050) is only found in:
RT25USB-SRC-V2.0.8.0/rt2570sw.h:#define RTVID8 0x050D //ralink
RT25USB-SRC-V2.0.8.0/rt2570sw.h:#define RTPID8 0x7050
RT25USB-SRC-V2.0.8.0/rt2570sw.h: {USB_DEVICE(RTVID8,RTPID8)},
and (0x050d, 0x705a) (0x1371, 0x9022) (0x148f, 0x2573) are only in:
2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x050d,0x705a)}, /* Belkin */
2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x1371,0x9022)}, /* CNet */
2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x148f,0x2573)}, /* Ralink */
Signed-off-by: Xose Vazquez Perez <[email protected]>
---
drivers/net/wireless/rt2x00/rt2500usb.c | 4 ----
drivers/net/wireless/rt2x00/rt73usb.c | 1 -
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
index 13444b6..c7f6fa6 100644
--- a/drivers/net/wireless/rt2x00/rt2500usb.c
+++ b/drivers/net/wireless/rt2x00/rt2500usb.c
@@ -1849,13 +1849,10 @@ static struct usb_device_id rt2500usb_device_table[] = {
/* Belkin */
{ USB_DEVICE(0x050d, 0x7050), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x050d, 0x7051), USB_DEVICE_DATA(&rt2500usb_ops) },
- { USB_DEVICE(0x050d, 0x705a), USB_DEVICE_DATA(&rt2500usb_ops) },
/* Cisco Systems */
{ USB_DEVICE(0x13b1, 0x000d), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x13b1, 0x0011), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x13b1, 0x001a), USB_DEVICE_DATA(&rt2500usb_ops) },
- /* CNet */
- { USB_DEVICE(0x1371, 0x9022), USB_DEVICE_DATA(&rt2500usb_ops) },
/* Conceptronic */
{ USB_DEVICE(0x14b2, 0x3c02), USB_DEVICE_DATA(&rt2500usb_ops) },
/* D-LINK */
@@ -1878,7 +1875,6 @@ static struct usb_device_id rt2500usb_device_table[] = {
/* Ralink */
{ USB_DEVICE(0x148f, 0x1706), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x148f, 0x2570), USB_DEVICE_DATA(&rt2500usb_ops) },
- { USB_DEVICE(0x148f, 0x2573), USB_DEVICE_DATA(&rt2500usb_ops) },
{ USB_DEVICE(0x148f, 0x9020), USB_DEVICE_DATA(&rt2500usb_ops) },
/* Sagem */
{ USB_DEVICE(0x079b, 0x004b), USB_DEVICE_DATA(&rt2500usb_ops) },
diff --git a/drivers/net/wireless/rt2x00/rt73usb.c b/drivers/net/wireless/rt2x00/rt73usb.c
index 290d70b..3e30ccf 100644
--- a/drivers/net/wireless/rt2x00/rt73usb.c
+++ b/drivers/net/wireless/rt2x00/rt73usb.c
@@ -2339,7 +2339,6 @@ static struct usb_device_id rt73usb_device_table[] = {
{ USB_DEVICE(0x0b05, 0x1723), USB_DEVICE_DATA(&rt73usb_ops) },
{ USB_DEVICE(0x0b05, 0x1724), USB_DEVICE_DATA(&rt73usb_ops) },
/* Belkin */
- { USB_DEVICE(0x050d, 0x7050), USB_DEVICE_DATA(&rt73usb_ops) },
{ USB_DEVICE(0x050d, 0x705a), USB_DEVICE_DATA(&rt73usb_ops) },
{ USB_DEVICE(0x050d, 0x905b), USB_DEVICE_DATA(&rt73usb_ops) },
{ USB_DEVICE(0x050d, 0x905c), USB_DEVICE_DATA(&rt73usb_ops) },
--
1.6.6.1
On Tuesday 06 April 2010, Xose Vazquez Perez wrote:
> Follow the precepts of the ralink drivers.
>
> (0x050d, 0x7050) is only found in:
>
> RT25USB-SRC-V2.0.8.0/rt2570sw.h:#define RTVID8 0x050D //ralink
> RT25USB-SRC-V2.0.8.0/rt2570sw.h:#define RTPID8 0x7050
> RT25USB-SRC-V2.0.8.0/rt2570sw.h: {USB_DEVICE(RTVID8,RTPID8)},
>
> and (0x050d, 0x705a) (0x1371, 0x9022) (0x148f, 0x2573) are only in:
>
> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x050d,0x705a)}, /* Belkin */
> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x1371,0x9022)}, /* CNet */
> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x148f,0x2573)}, /* Ralink */
>
> Signed-off-by: Xose Vazquez Perez <[email protected]>
I have my doubts about this one.
Gertjan, do you consider it wise to remove these ID's?
Ivo
On Tue, Apr 6, 2010 at 11:28 PM, Ivo van Doorn <[email protected]> wrote:
> On Tuesday 06 April 2010, Xose Vazquez Perez wrote:
>> Follow the precepts of the ralink drivers.
>>
>> (0x050d, 0x7050) is only found in:
>>
>> RT25USB-SRC-V2.0.8.0/rt2570sw.h:#define RTVID8 ? ? ? ? ? ? ? ? ?0x050D //ralink
>> RT25USB-SRC-V2.0.8.0/rt2570sw.h:#define RTPID8 ? ? ? ? ? ? ? ? ?0x7050
>> RT25USB-SRC-V2.0.8.0/rt2570sw.h: {USB_DEVICE(RTVID8,RTPID8)},
>>
>> and (0x050d, 0x705a) (0x1371, 0x9022) (0x148f, 0x2573) are only in:
>>
>> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x050d,0x705a)}, /* Belkin */
>> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x1371,0x9022)}, /* CNet */
>> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x148f,0x2573)}, /* Ralink */
>>
>> Signed-off-by: Xose Vazquez Perez <[email protected]>
>
> I have my doubts about this one.
> Gertjan, do you consider it wise to remove these ID's?
>
Yes, I have my doubts here as well. We know about overlap in USB IDs
between rt2500 and rt73 devices,
and these could very well be these devices.
However, if Ralink doesn't have this overlap in their devices, then
why should we care.
Xose, can you verify with the Windows drivers whether the situation on
the USB IDs is the same as for the
Ralink Linux drivers?
---
Gertjan.
On 04/07/2010 12:06 AM, Gertjan van Wingerde wrote:
> On Tue, Apr 6, 2010 at 11:28 PM, Ivo van Doorn <[email protected]> wrote:
>> On Tuesday 06 April 2010, Xose Vazquez Perez wrote:
>>> Follow the precepts of the ralink drivers.
>>>
>>> (0x050d, 0x7050) is only found in:
>>>
>>> RT25USB-SRC-V2.0.8.0/rt2570sw.h:#define RTVID8 0x050D //ralink
>>> RT25USB-SRC-V2.0.8.0/rt2570sw.h:#define RTPID8 0x7050
>>> RT25USB-SRC-V2.0.8.0/rt2570sw.h: {USB_DEVICE(RTVID8,RTPID8)},
>>>
>>> and (0x050d, 0x705a) (0x1371, 0x9022) (0x148f, 0x2573) are only in:
>>>
>>> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x050d,0x705a)}, /* Belkin */
>>> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x1371,0x9022)}, /* CNet */
>>> 2009_0713_RT73_Linux_STA_Drv1.1.0.3/Module/rtmp_def.h: {USB_DEVICE(0x148f,0x2573)}, /* Ralink */
>>>
>>> Signed-off-by: Xose Vazquez Perez <[email protected]>
>>
>> I have my doubts about this one.
>> Gertjan, do you consider it wise to remove these ID's?
>>
>
> Yes, I have my doubts here as well. We know about overlap in USB IDs
> between rt2500 and rt73 devices,
> and these could very well be these devices.
>
> However, if Ralink doesn't have this overlap in their devices, then
> why should we care.
>
> Xose, can you verify with the Windows drivers whether the situation on
> the USB IDs is the same as for the
> Ralink Linux drivers?
OK, here it goes:
W = Windows:ralink_driver
L = Linux:ralink_driver
USB_IDs W_73 W_2500 L_73 L_2500
============= ==== ====== ==== ======
0x050d,0x7050 - - - YES
0x050d,0x705a - - YES -
0x1371,0x9022 - YES YES -
0x148f,0x2573 YES - YES -
--
?All? muevan feroz guerra, ciegos reyes por un palmo m?s de tierra;
que yo aqu? tengo por m?o cuanto abarca el mar brav?o, a quien nadie
impuso leyes. Y no hay playa, sea cualquiera, ni bandera de esplendor,
que no sienta mi derecho y d? pecho a mi valor.?