2010-06-06 17:47:25

by Sid Hayn

[permalink] [raw]
Subject: compat-wireless 2.6.35_rc2 build errors

I realize we are still pretty early in the rc process but there are some
seemingly significant problems building compat-wireless 2.6.35_rc2
(which should be very close if not identical to the linus tree). I have
copied the rt2x00 team because of the first error and Luiz for the second.

First and foremost this won't build at all:

/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/rt2x00/rt2800pci.c:
In function 'rt2800pci_read_eeprom_soc':
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/rt2x00/rt2800pci.c:91:
error: implicit declaration of function 'KSEG1ADDR'
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/rt2x00/rt2800pci.c:91:
warning: cast to pointer from integer of different size
make[4]: ***
[/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/rt2x00/rt2800pci.o]
Error 1


Additionally but likely less important this driver seems to be defining
variables overriding kernel headers, I can't imagine that is good. Not
sure if this is something that the driver needs to fix or needs to be
fixed in compat-wireless but here it is:

/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/main.c:10:1:
warning: "pr_fmt" redefined
In file included from include/linux/skbuff.h:17,
from include/linux/if_ether.h:124,
from include/linux/netdevice.h:29,
from
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.29.h:5,
from
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.h:24,
from <command-line>:0:
include/linux/kernel.h:376:1: warning: this is the location of the
previous definition
CC [M]
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/orinoco/main.o
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/main.c:10:1:
warning: "pr_fmt" redefined
In file included from include/linux/skbuff.h:17,
from include/linux/if_ether.h:124,
from include/linux/netdevice.h:29,
from
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.29.h:5,
from
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.h:24,
from <command-line>:0:
include/linux/kernel.h:376:1: warning: this is the location of the
previous definition
CC [M]
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/cmd.o
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/cmd.c:10:1:
warning: "pr_fmt" redefined
In file included from include/linux/skbuff.h:17,
from include/linux/if_ether.h:124,
from include/linux/netdevice.h:29,
from
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.29.h:5,
from
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.h:24,
from <command-line>:0:
include/linux/kernel.h:376:1: warning: this is the location of the
previous definition
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/cmd.c:10:1:
warning: "pr_fmt" redefined
In file included from include/linux/skbuff.h:17,
from include/linux/if_ether.h:124,
from include/linux/netdevice.h:29,
from
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.29.h:5,
from
/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.h:24,
from <command-line>:0:

I'll try to build the rc2 kernel and see if these errors are the same.

Thanks,
Rick Farina


2010-06-06 18:41:17

by Sid Hayn

[permalink] [raw]
Subject: Re: compat-wireless 2.6.35_rc2 build errors

Richard Farina wrote:
> I realize we are still pretty early in the rc process but there are
> some seemingly significant problems building compat-wireless
> 2.6.35_rc2 (which should be very close if not identical to the linus
> tree). I have copied the rt2x00 team because of the first error and
> Luiz for the second.
>
> First and foremost this won't build at all:
>
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/rt2x00/rt2800pci.c:
> In function 'rt2800pci_read_eeprom_soc':
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/rt2x00/rt2800pci.c:91:
> error: implicit declaration of function 'KSEG1ADDR'
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/rt2x00/rt2800pci.c:91:
> warning: cast to pointer from integer of different size
> make[4]: ***
> [/var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/rt2x00/rt2800pci.o]
> Error 1
>
>
After talking to Hauke2 on irc it seems that this outcome is very
expected when you try to build a mips driver for x86_64. I shouldn't be
trying to build this at all. Compat-wireless has a bunch of ifneq
statements which seem to be how this type of stupidity is prevented,
however, I can't exactly grok how to make this work. I know this driver
should dep RALINK_RT288X || RALINK_RT305X but I can't figure out how to
modify the section of config.mk to do that properly:

ifneq ($(CONFIG_CRC_CCITT),)
CONFIG_RT2800PCI=m
CONFIG_RT2800PCI_PCI=y
CONFIG_RT2800PCI_RT30XX=y
CONFIG_RT2800PCI_RT35XX=y
# CONFIG_RT2800PCI_SOC=y
endif
NEED_RT2X00=y

Currently it is just commented out which allows me to build but really
it should be uncommented and have a proper check to see if it should be
built or not. Luiz can you do this? Or someone hint me on how in the
world I would do it? I'd spend more time trying to figure this out but
the grass isn't going to cut itself.

Thanks,
Rick Farina

> Additionally but likely less important this driver seems to be
> defining variables overriding kernel headers, I can't imagine that is
> good. Not sure if this is something that the driver needs to fix or
> needs to be fixed in compat-wireless but here it is:
>
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/main.c:10:1:
> warning: "pr_fmt" redefined
> In file included from include/linux/skbuff.h:17,
> from include/linux/if_ether.h:124,
> from include/linux/netdevice.h:29,
> from
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.29.h:5,
>
> from
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.h:24,
>
> from <command-line>:0:
> include/linux/kernel.h:376:1: warning: this is the location of the
> previous definition
> CC [M]
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/orinoco/main.o
>
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/main.c:10:1:
> warning: "pr_fmt" redefined
> In file included from include/linux/skbuff.h:17,
> from include/linux/if_ether.h:124,
> from include/linux/netdevice.h:29,
> from
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.29.h:5,
>
> from
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.h:24,
>
> from <command-line>:0:
> include/linux/kernel.h:376:1: warning: this is the location of the
> previous definition
> CC [M]
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/cmd.o
>
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/cmd.c:10:1:
> warning: "pr_fmt" redefined
> In file included from include/linux/skbuff.h:17,
> from include/linux/if_ether.h:124,
> from include/linux/netdevice.h:29,
> from
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.29.h:5,
>
> from
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.h:24,
>
> from <command-line>:0:
> include/linux/kernel.h:376:1: warning: this is the location of the
> previous definition
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/drivers/net/wireless/libertas_tf/cmd.c:10:1:
> warning: "pr_fmt" redefined
> In file included from include/linux/skbuff.h:17,
> from include/linux/if_ether.h:124,
> from include/linux/netdevice.h:29,
> from
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.29.h:5,
>
> from
> /var/tmp/portage/net-wireless/compat-wireless-2.6.35_rc2/work/compat-wireless-2.6.35-rc2/include/linux/compat-2.6.h:24,
>
> from <command-line>:0:
>
> I'll try to build the rc2 kernel and see if these errors are the same.
>
> Thanks,
> Rick Farina
>