2010-06-19 13:28:24

by Larry Finger

Subject: [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

The message following fatal DMA errors fails to indicate properly that the
driver has switched to PIO mode.

Signed-off-by: Larry Finger <[email protected]>
---

Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/main.c
+++ wireless-testing/drivers/net/wireless/b43/main.c
@@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
dma_reason[2], dma_reason[3],
dma_reason[4], dma_reason[5]);
b43err(dev->wl, "This device does not support DMA "
- "on your system. Please use PIO instead.\n");
+ "on your system. It will now be switched to PIO.\n");
/* Fall back to PIO transfers if we get fatal DMA errors! */
dev->use_pio = 1;
b43_controller_restart(dev, "DMA error");

2010-06-19 14:37:55

by Michael Büsch

Subject: Re: [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode

On 06/19/2010 03:29 PM, Larry Finger wrote:
> The message following fatal DMA errors fails to indicate properly that the
> driver has switched to PIO mode.
>
> Signed-off-by: Larry Finger<[email protected]>
> ---
>
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
> dma_reason[2], dma_reason[3],
> dma_reason[4], dma_reason[5]);
> b43err(dev->wl, "This device does not support DMA "
> - "on your system. Please use PIO instead.\n");
> + "on your system. It will now be switched to PIO.\n");
> /* Fall back to PIO transfers if we get fatal DMA errors! */
> dev->use_pio = 1;
> b43_controller_restart(dev, "DMA error");
>

Ack.

But what's the current status of the debugging of the PCI-core code
w.r.t DMA?

--
Greetings Michael.