2011-03-01 07:27:03

by Ozan Çağlayan

Subject: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning

The TX queues are allocated inside register_netdev.
It doesn't make any sense to stop the queue before
allocation.

Signed-off-by: Ozan Çağlayan <[email protected]>
---
drivers/staging/rtl8192e/r8192E_core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/rtl8192e/r8192E_core.c b/drivers/staging/rtl8192e/r8192E_core.c
index fac4eee..08af4fa 100644
--- a/drivers/staging/rtl8192e/r8192E_core.c
+++ b/drivers/staging/rtl8192e/r8192E_core.c
@@ -6006,7 +6006,6 @@ static int __devinit rtl8192_pci_probe(struct pci_dev *pdev,
}

netif_carrier_off(dev);
- netif_stop_queue(dev);

register_netdev(dev);
RT_TRACE(COMP_INIT, "dev name=======> %s\n",dev->name);
--
1.7.3.4

2011-03-01 21:19:39

by Greg KH

Subject: Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning

On Tue, Mar 01, 2011 at 09:23:12AM +0200, Ozan Çağlayan wrote:
> The TX queues are allocated inside register_netdev.
> It doesn't make any sense to stop the queue before
> allocation.
>
> Signed-off-by: Ozan Çağlayan <[email protected]>
> ---
> drivers/staging/rtl8192e/r8192E_core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)

This patch doesn't apply, what tree did you make it against?

thanks,

greg k-h

2011-03-01 21:43:40

by Ozan Çağlayan

Subject: Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning

On 01.03.2011 23:15, Greg KH wrote:
> On Tue, Mar 01, 2011 at 09:23:12AM +0200, Ozan Çağlayan wrote:
>> The TX queues are allocated inside register_netdev.
>> It doesn't make any sense to stop the queue before
>> allocation.
>>
>> Signed-off-by: Ozan Çağlayan<[email protected]>
>> ---
>> drivers/staging/rtl8192e/r8192E_core.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> This patch doesn't apply, what tree did you make it against?

hmm, weird it was on top of an up-to-date linux-2.6 tree.

--
Pardus Linux
http://www.pardus.org.tr/eng

2011-03-01 22:04:45

by Ozan Çağlayan

Subject: Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning

On 02.03.2011 00:01, Greg KH wrote:

> That's why it doesn't apply, I need patches against the linux-next tree
> for stuff to go into the .39 kernel version. Care to rediff this
> against that one and resend it?

Oh I didn't know that, sorry. I'll refresh and send it tomorrow.

Thanks.


--
Pardus Linux
http://www.pardus.org.tr/eng

2011-03-03 12:41:34

by Ozan Çağlayan

Subject: Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning

02-03-2011 00:04 tarihinde, Ozan Çağlayan yazdı:
> On 02.03.2011 00:01, Greg KH wrote:
>
>> That's why it doesn't apply, I need patches against the linux-next tree
>> for stuff to go into the .39 kernel version. Care to rediff this
>> against that one and resend it?

OK this was already fixed with

commit 6376f210aeca59c89c67efe8ccf28c36bb98b832
Author: Mike McCormack <[email protected]>
Date: Mon Jan 31 22:09:15 2011 +0900

Staging: rtl8192e: Don't mess with carrier before registering device

Signed-off-by: Mike McCormack <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

in linux-next. Sorry :)

Regards,
Ozan Caglayan


--
Pardus Linux
http://www.pardus.org.tr/eng

2011-03-01 22:01:04

by Greg KH

Subject: Re: [PATCH] staging: rtl8192e: Fix incorrect netif_stop_queue usage warning

On Tue, Mar 01, 2011 at 11:43:40PM +0200, Ozan Çağlayan wrote:
> On 01.03.2011 23:15, Greg KH wrote:
> >On Tue, Mar 01, 2011 at 09:23:12AM +0200, Ozan Çağlayan wrote:
> >>The TX queues are allocated inside register_netdev.
> >>It doesn't make any sense to stop the queue before
> >>allocation.
> >>
> >>Signed-off-by: Ozan Çağlayan<[email protected]>
> >>---
> >> drivers/staging/rtl8192e/r8192E_core.c | 1 -
> >> 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> >This patch doesn't apply, what tree did you make it against?
>
> hmm, weird it was on top of an up-to-date linux-2.6 tree.

That's why it doesn't apply, I need patches against the linux-next tree
for stuff to go into the .39 kernel version. Care to rediff this
against that one and resend it?

thanks,

greg k-h