2011-03-15 15:41:21

by Joe Gunn

Subject: [PATCH 2.6.38-rc8-wl 1/1] orinoco: Maintain lock until entry removed from list

Removing an entry from the scan_list should be performed while holding the lock.
Signed-off-by: Joseph J. Gunn <[email protected]>
---
diff --git a/drivers/net/wireless/orinoco/main.c b/drivers/net/wireless/orinoco/main.c
index f3d396e..62c6b2b 100644
--- a/drivers/net/wireless/orinoco/main.c
+++ b/drivers/net/wireless/orinoco/main.c
@@ -1376,13 +1376,13 @@ static void orinoco_process_scan_results(struct work_struct *work)

spin_lock_irqsave(&priv->scan_lock, flags);
list_for_each_entry_safe(sd, temp, &priv->scan_list, list) {
- spin_unlock_irqrestore(&priv->scan_lock, flags);

buf = sd->buf;
len = sd->len;
type = sd->type;

list_del(&sd->list);
+ spin_unlock_irqrestore(&priv->scan_lock, flags);
kfree(sd);

if (len > 0) {

2011-03-17 00:38:19

by Dave Kilroy

Subject: Re: [Orinoco-devel] [PATCH 2.6.38-rc8-wl 1/1] orinoco: Maintain lock until entry removed from list

On 15/03/2011 15:41, Joe Gunn wrote:
> Removing an entry from the scan_list should be performed while holding the lock.
> Signed-off-by: Joseph J. Gunn<[email protected]>
> ---

Agreed. Thanks,

Dave.