Larry Finger wrote:
> There are three USB IDs supported by staging/rt2870sta that are not in the
> mainline driver rt2800usb.
>
> Signed-off-by: Larry Finger <[email protected]>
> Cc: Stable <[email protected]>
> ---
>
> Index: wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/rt2x00/rt2800usb.c
> +++ wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
> @@ -758,6 +758,8 @@ static struct usb_device_id rt2800usb_de
> { USB_DEVICE(0x07d1, 0x3c0f), USB_DEVICE_DATA(&rt2800usb_ops) },
> { USB_DEVICE(0x07d1, 0x3c11), USB_DEVICE_DATA(&rt2800usb_ops) },
> { USB_DEVICE(0x07d1, 0x3c16), USB_DEVICE_DATA(&rt2800usb_ops) },
> + { USB_DEVICE(0x2001, 0x3c09), USB_DEVICE_DATA(&rt2800usb_ops) },
> + { USB_DEVICE(0x2001, 0x3c0a), USB_DEVICE_DATA(&rt2800usb_ops) },
> /* Draytek */
> { USB_DEVICE(0x07fa, 0x7712), USB_DEVICE_DATA(&rt2800usb_ops) },
> /* Edimax */
> @@ -828,6 +830,7 @@ static struct usb_device_id rt2800usb_de
> /* Planex */
> { USB_DEVICE(0x2019, 0xab25), USB_DEVICE_DATA(&rt2800usb_ops) },
> { USB_DEVICE(0x2019, 0xed06), USB_DEVICE_DATA(&rt2800usb_ops) },
> + { USB_DEVICE(0x2019, 0xed14), USB_DEVICE_DATA(&rt2800usb_ops) },
> /* Quanta */
> { USB_DEVICE(0x1a32, 0x0304), USB_DEVICE_DATA(&rt2800usb_ops) },
> /* Ralink */
NACK, unless they also be in the windows driver.
They were eliminated in recent versions of ralink LiNUX drivers.
On 04/12/2011 06:53 AM, Xose Vazquez Perez wrote:
> On 04/11/2011 07:58 PM, John W. Linville wrote:
>
>> On Sun, Apr 10, 2011 at 07:12:13PM +0200, Xose Vazquez Perez wrote:
>>> Larry Finger wrote:
>>>
>>>> There are three USB IDs supported by staging/rt2870sta that are not in the
>>>> mainline driver rt2800usb.
>>>>
>>>> Signed-off-by: Larry Finger<[email protected]>
>>>> Cc: Stable<[email protected]>
>>>> ---
>>>>
>>>> Index: wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> ===================================================================
>>>> --- wireless-testing.orig/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> +++ wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> @@ -758,6 +758,8 @@ static struct usb_device_id rt2800usb_de
>>>> { USB_DEVICE(0x07d1, 0x3c0f), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> { USB_DEVICE(0x07d1, 0x3c11), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> { USB_DEVICE(0x07d1, 0x3c16), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> + { USB_DEVICE(0x2001, 0x3c09), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> + { USB_DEVICE(0x2001, 0x3c0a), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> /* Draytek */
>>>> { USB_DEVICE(0x07fa, 0x7712), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> /* Edimax */
>>>> @@ -828,6 +830,7 @@ static struct usb_device_id rt2800usb_de
>>>> /* Planex */
>>>> { USB_DEVICE(0x2019, 0xab25), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> { USB_DEVICE(0x2019, 0xed06), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> + { USB_DEVICE(0x2019, 0xed14), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> /* Quanta */
>>>> { USB_DEVICE(0x1a32, 0x0304), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> /* Ralink */
>>>
>>> NACK, unless they also be in the windows driver.
>>> They were eliminated in recent versions of ralink LiNUX drivers.
>>
>> OK, I already had this merged since Ivo and Gertjan had ACKed it.
>>
>> I need to rebase wireless-2.6 anyway, so I'll drop this one too
>> for now. Please come to a consensus on whether or not these should
>> be included and let me know...
>
> I did a search of 0x2001,0x3c09 0x2001,0x3c0a and 0x2019,0xed14 in
> latest windows drivers:
> USB (RT2870 /RT2770 /RT307X /RT2070 /RT357X /RT3370 /RT8070 /RT5370) 12/31/2010
> 3.1.8.0
> IS_AP_STA_RT2870_D-3.1.8.0_VA-3.1.8.0_W7-3.1.8.0_RU-4.0.4.0_AU-4.0.4.0_123110_1.5.11.0WP_Free.exe
>
> and I didn't find any of them
>
> Also I checked latest linux drivers:
> 2010_0709_RT2870_Linux_STA_v2.4.0.1.tar.bz2
> 2010_1215_RT3572_Linux_STA_v2.5.0.0.DPO.bz2
> 2011_0107_RT3070_RT3370_Linux_STA_v2.5.0.1_DPO.tar.bz2
> and there is no vestige of any of them.
>
> NACK.
John,
Kill the patch. It appears these are phantom devices, or their original
inclusion was a mistake.
Thanks,
Larry
On Tue, Apr 12, 2011 at 1:53 PM, Xose Vazquez Perez
<[email protected]> wrote:
> On 04/11/2011 07:58 PM, John W. Linville wrote:
>
>> On Sun, Apr 10, 2011 at 07:12:13PM +0200, Xose Vazquez Perez wrote:
>>>
>>> Larry Finger wrote:
>>>
>>>> There are three USB IDs supported by staging/rt2870sta that are not in
>>>> the
>>>> mainline driver rt2800usb.
>>>>
>>>> Signed-off-by: Larry Finger<[email protected]>
>>>> Cc: Stable<[email protected]>
>>>> ---
>>>>
>>>> Index: wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> ===================================================================
>>>> --- wireless-testing.orig/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> +++ wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
>>>> @@ -758,6 +758,8 @@ static struct usb_device_id rt2800usb_de
>>>> ? ? ? ?{ USB_DEVICE(0x07d1, 0x3c0f), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> ? ? ? ?{ USB_DEVICE(0x07d1, 0x3c11), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> ? ? ? ?{ USB_DEVICE(0x07d1, 0x3c16), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> + ? ? ? { USB_DEVICE(0x2001, 0x3c09), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> + ? ? ? { USB_DEVICE(0x2001, 0x3c0a), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> ? ? ? ?/* Draytek */
>>>> ? ? ? ?{ USB_DEVICE(0x07fa, 0x7712), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> ? ? ? ?/* Edimax */
>>>> @@ -828,6 +830,7 @@ static struct usb_device_id rt2800usb_de
>>>> ? ? ? ?/* Planex */
>>>> ? ? ? ?{ USB_DEVICE(0x2019, 0xab25), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> ? ? ? ?{ USB_DEVICE(0x2019, 0xed06), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> + ? ? ? { USB_DEVICE(0x2019, 0xed14), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> ? ? ? ?/* Quanta */
>>>> ? ? ? ?{ USB_DEVICE(0x1a32, 0x0304), USB_DEVICE_DATA(&rt2800usb_ops) },
>>>> ? ? ? ?/* Ralink */
>>>
>>> NACK, unless they also be in the windows driver.
>>> They were eliminated in recent versions of ralink LiNUX drivers.
>>
>> OK, I already had this merged since Ivo and Gertjan had ACKed it.
>>
>> I need to rebase wireless-2.6 anyway, so I'll drop this one too
>> for now. ?Please come to a consensus on whether or not these should
>> be included and let me know...
>
> I did a search of 0x2001,0x3c09 0x2001,0x3c0a and 0x2019,0xed14 in
> latest windows drivers:
> USB (RT2870 /RT2770 /RT307X /RT2070 /RT357X /RT3370 /RT8070 /RT5370)
> 12/31/2010 3.1.8.0
> IS_AP_STA_RT2870_D-3.1.8.0_VA-3.1.8.0_W7-3.1.8.0_RU-4.0.4.0_AU-4.0.4.0_123110_1.5.11.0WP_Free.exe
> and I didn't find any of them
>
> Also I checked latest linux drivers:
> 2010_0709_RT2870_Linux_STA_v2.4.0.1.tar.bz2
> 2010_1215_RT3572_Linux_STA_v2.5.0.0.DPO.bz2
> 2011_0107_RT3070_RT3370_Linux_STA_v2.5.0.1_DPO.tar.bz2
> and there is no vestige of any of them.
>
> NACK.
>
OK. I hadn't imagined that Ralink would remove hardware ID's from
later versions of their drivers.
If these devices are not supported anymore by any of the later Ralink
drivers (neither Linux drivers nor Windows drivers),
as seems to be the case, then I have to agree that there is no point
in adding these USB IDs to
rt2800usb.
---
Gertjan
On Sun, Apr 10, 2011 at 07:12:13PM +0200, Xose Vazquez Perez wrote:
> Larry Finger wrote:
>
> > There are three USB IDs supported by staging/rt2870sta that are not in the
> > mainline driver rt2800usb.
> >
> > Signed-off-by: Larry Finger <[email protected]>
> > Cc: Stable <[email protected]>
> > ---
> >
> > Index: wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
> > ===================================================================
> > --- wireless-testing.orig/drivers/net/wireless/rt2x00/rt2800usb.c
> > +++ wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
> > @@ -758,6 +758,8 @@ static struct usb_device_id rt2800usb_de
> > { USB_DEVICE(0x07d1, 0x3c0f), USB_DEVICE_DATA(&rt2800usb_ops) },
> > { USB_DEVICE(0x07d1, 0x3c11), USB_DEVICE_DATA(&rt2800usb_ops) },
> > { USB_DEVICE(0x07d1, 0x3c16), USB_DEVICE_DATA(&rt2800usb_ops) },
> > + { USB_DEVICE(0x2001, 0x3c09), USB_DEVICE_DATA(&rt2800usb_ops) },
> > + { USB_DEVICE(0x2001, 0x3c0a), USB_DEVICE_DATA(&rt2800usb_ops) },
> > /* Draytek */
> > { USB_DEVICE(0x07fa, 0x7712), USB_DEVICE_DATA(&rt2800usb_ops) },
> > /* Edimax */
> > @@ -828,6 +830,7 @@ static struct usb_device_id rt2800usb_de
> > /* Planex */
> > { USB_DEVICE(0x2019, 0xab25), USB_DEVICE_DATA(&rt2800usb_ops) },
> > { USB_DEVICE(0x2019, 0xed06), USB_DEVICE_DATA(&rt2800usb_ops) },
> > + { USB_DEVICE(0x2019, 0xed14), USB_DEVICE_DATA(&rt2800usb_ops) },
> > /* Quanta */
> > { USB_DEVICE(0x1a32, 0x0304), USB_DEVICE_DATA(&rt2800usb_ops) },
> > /* Ralink */
>
> NACK, unless they also be in the windows driver.
> They were eliminated in recent versions of ralink LiNUX drivers.
OK, I already had this merged since Ivo and Gertjan had ACKed it.
I need to rebase wireless-2.6 anyway, so I'll drop this one too
for now. Please come to a consensus on whether or not these should
be included and let me know...
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On 04/12/2011 04:34 PM, Larry Finger wrote:
> Kill the patch. It appears these are phantom devices, or their original
> inclusion was a mistake.
More ids. But no time for a patch, sorry.
missing, taken from ralink windows driver. And the identified ones come
from ralink linux drivers:
0x04bb,0x094b I-O
0x050d,0x1003 Belkin
0x0586,0x343e RT3070 Zyxel
0x0789,0x0168 Logitec
0x0789,0x0169 Logitec
0x07b8,0x3073 AboCom
0x07b8,0x3074 AboCom
0x08b9,0x1197 RadioShack
0x0b05,0x166a PEGATRON
0x0b05,0x179d ASUS
0x0df6,0x003c Sitecom
0x0df6,0x004a Sitecom
0x0df6,0x004d Sitecom
0x0df6,0x0051 Sitecom
0x0df6,0x0053 Sitecom
0x0df6,0x005f RT3070 Sitecom 3072
0x0df6,0x0060 Sitecom
0x0df6,0x0062 Sitecom
0x13d3,0x3329 AzureWave
0x13d3,0x3365 RT5370 Azurewave
0x148f,0x3573 Ralink
0x148f,0x5370 RT5370 Ralink 5370
0x148f,0x5372 RT5370 Ralink 5370
0x148f,0xf101 Huawei
0x1eda,0x2012 RT3070 Airties
0x2001,0x3c17 Alpha
0x7392,0x7722 Edimax
already at rt2800usb.c, identified from ralink RT3070_RT3370 linux
driver. I believe 8070 == RT33XX :-?
0x07d1,0x3c17 D-Link 8070
0x7392,0x4085 2L Central Europe BV 8070
0x2019,0x5201 Planex Communications, Inc. RT8070
On 04/11/2011 07:58 PM, John W. Linville wrote:
> On Sun, Apr 10, 2011 at 07:12:13PM +0200, Xose Vazquez Perez wrote:
>> Larry Finger wrote:
>>
>>> There are three USB IDs supported by staging/rt2870sta that are not in the
>>> mainline driver rt2800usb.
>>>
>>> Signed-off-by: Larry Finger<[email protected]>
>>> Cc: Stable<[email protected]>
>>> ---
>>>
>>> Index: wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
>>> ===================================================================
>>> --- wireless-testing.orig/drivers/net/wireless/rt2x00/rt2800usb.c
>>> +++ wireless-testing/drivers/net/wireless/rt2x00/rt2800usb.c
>>> @@ -758,6 +758,8 @@ static struct usb_device_id rt2800usb_de
>>> { USB_DEVICE(0x07d1, 0x3c0f), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> { USB_DEVICE(0x07d1, 0x3c11), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> { USB_DEVICE(0x07d1, 0x3c16), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> + { USB_DEVICE(0x2001, 0x3c09), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> + { USB_DEVICE(0x2001, 0x3c0a), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> /* Draytek */
>>> { USB_DEVICE(0x07fa, 0x7712), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> /* Edimax */
>>> @@ -828,6 +830,7 @@ static struct usb_device_id rt2800usb_de
>>> /* Planex */
>>> { USB_DEVICE(0x2019, 0xab25), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> { USB_DEVICE(0x2019, 0xed06), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> + { USB_DEVICE(0x2019, 0xed14), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> /* Quanta */
>>> { USB_DEVICE(0x1a32, 0x0304), USB_DEVICE_DATA(&rt2800usb_ops) },
>>> /* Ralink */
>>
>> NACK, unless they also be in the windows driver.
>> They were eliminated in recent versions of ralink LiNUX drivers.
>
> OK, I already had this merged since Ivo and Gertjan had ACKed it.
>
> I need to rebase wireless-2.6 anyway, so I'll drop this one too
> for now. Please come to a consensus on whether or not these should
> be included and let me know...
I did a search of 0x2001,0x3c09 0x2001,0x3c0a and 0x2019,0xed14 in
latest windows drivers:
USB (RT2870 /RT2770 /RT307X /RT2070 /RT357X /RT3370 /RT8070 /RT5370)
12/31/2010 3.1.8.0
IS_AP_STA_RT2870_D-3.1.8.0_VA-3.1.8.0_W7-3.1.8.0_RU-4.0.4.0_AU-4.0.4.0_123110_1.5.11.0WP_Free.exe
and I didn't find any of them
Also I checked latest linux drivers:
2010_0709_RT2870_Linux_STA_v2.4.0.1.tar.bz2
2010_1215_RT3572_Linux_STA_v2.5.0.0.DPO.bz2
2011_0107_RT3070_RT3370_Linux_STA_v2.5.0.1_DPO.tar.bz2
and there is no vestige of any of them.
NACK.
-thanks-