2011-07-10 09:28:32

by Joe Perches

[permalink] [raw]
Subject: [PATCH 0/5] treewide: Add missing breaks in switch/case

Found by grep. Uncompiled/untested.

Joe Perches (5):
gpio-tps65910.c: Add missing breaks in switch/case
tps65910-irq: Add missing breaks in switch/case
ath5k: Add missing breaks in switch/case
fusb300_udc: Add missing breaks in switch/case
dbri: Add missing breaks in switch/case

drivers/gpio/gpio-tps65910.c | 2 ++
drivers/mfd/tps65910-irq.c | 2 ++
drivers/net/wireless/ath/ath5k/desc.c | 3 +++
drivers/usb/gadget/fusb300_udc.c | 3 +++
sound/sparc/dbri.c | 5 +++++
5 files changed, 15 insertions(+), 0 deletions(-)

--
1.7.6.131.g99019



2011-07-11 21:24:07

by Nick Kossifidis

[permalink] [raw]
Subject: Re: [PATCH 3/5] ath5k: Add missing breaks in switch/case

MjAxMS83LzEwIEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hlcy5jb20+Ogo+IFNpZ25lZC1vZmYtYnk6
IEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hlcy5jb20+Cj4gLS0tCj4gwqBkcml2ZXJzL25ldC93aXJl
bGVzcy9hdGgvYXRoNWsvZGVzYy5jIHwgwqAgwqAzICsrKwo+IMKgMSBmaWxlcyBjaGFuZ2VkLCAz
IGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9u
ZXQvd2lyZWxlc3MvYXRoL2F0aDVrL2Rlc2MuYyBiL2RyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC9h
dGg1ay9kZXNjLmMKPiBpbmRleCA2MjE3MmQ1Li5mODIzODNiIDEwMDY0NAo+IC0tLSBhL2RyaXZl
cnMvbmV0L3dpcmVsZXNzL2F0aC9hdGg1ay9kZXNjLmMKPiArKysgYi9kcml2ZXJzL25ldC93aXJl
bGVzcy9hdGgvYXRoNWsvZGVzYy5jCj4gQEAgLTEwNywxMCArMTA3LDEzIEBAIGF0aDVrX2h3X3Nl
dHVwXzJ3b3JkX3R4X2Rlc2Moc3RydWN0IGF0aDVrX2h3ICphaCwgc3RydWN0IGF0aDVrX2Rlc2Mg
KmRlc2MsCj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBjYXNlIEFSNUtfUEtUX1RZUEVfQkVBQ09O
Ogo+IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgY2FzZSBBUjVLX1BLVF9UWVBFX1BST0JFX1JFU1A6
Cj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBmcmFtZV90eXBlID0gQVI1S19B
UjUyMTBfVFhfREVTQ19GUkFNRV9UWVBFX05PX0RFTEFZOwo+ICsgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgwqAgwqAgwqAgwqAgYnJlYWs7Cj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBjYXNlIEFSNUtf
UEtUX1RZUEVfUElGUzoKPiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGZyYW1l
X3R5cGUgPSBBUjVLX0FSNTIxMF9UWF9ERVNDX0ZSQU1FX1RZUEVfUElGUzsKPiArIMKgIMKgIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGJyZWFrOwo+IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
ZGVmYXVsdDoKPiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGZyYW1lX3R5cGUg
PSB0eXBlOwo+ICsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgYnJlYWs7Cj4gwqAg
wqAgwqAgwqAgwqAgwqAgwqAgwqB9Cj4KPiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHR4X2N0bC0+
dHhfY29udHJvbF8wIHw9CgpBY2tlZC1ieTogTmljayBLb3NzaWZpZGlzIDxtaWNrZmxlbW1AZ21h
aWwuY29tPgoKCgotLSAKR1BHIElEOiAweEQyMURCMkRCCkFzIHlvdSByZWFkIHRoaXMgcG9zdCBn
bG9iYWwgZW50cm9weSByaXNlcy4gSGF2ZSBGdW4gOy0pCk5pY2sK

2011-07-11 15:50:35

by Pavel Roskin

[permalink] [raw]
Subject: Re: [ath5k-devel] [PATCH 3/5] ath5k: Add missing breaks in switch/case

On 07/10/2011 05:28 AM, Joe Perches wrote:
> Signed-off-by: Joe Perches<[email protected]>

Acked-by: Pavel Roskin <[email protected]>

> ---
> drivers/net/wireless/ath/ath5k/desc.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/desc.c b/drivers/net/wireless/ath/ath5k/desc.c
> index 62172d5..f82383b 100644
> --- a/drivers/net/wireless/ath/ath5k/desc.c
> +++ b/drivers/net/wireless/ath/ath5k/desc.c
> @@ -107,10 +107,13 @@ ath5k_hw_setup_2word_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc,
> case AR5K_PKT_TYPE_BEACON:
> case AR5K_PKT_TYPE_PROBE_RESP:
> frame_type = AR5K_AR5210_TX_DESC_FRAME_TYPE_NO_DELAY;
> + break;
> case AR5K_PKT_TYPE_PIFS:
> frame_type = AR5K_AR5210_TX_DESC_FRAME_TYPE_PIFS;
> + break;
> default:
> frame_type = type;
> + break;
> }

The intention here is to replace frame types from enum ath5k_pkt_type
with their AR5210-specific counterparts. So the intention is definitely
to have breaks here.

Unfortunately, AR5210 cards are extremely rare these days. I have one,
but it only works with old motherboards. It would take me half a day to
dust off that system, compile the kernel and check the patch. But I
assume your patch is fine. At least it's very unlikely to break anything.

--
Regards,
Pavel Roskin

2011-07-10 09:28:35

by Joe Perches

[permalink] [raw]
Subject: [PATCH 3/5] ath5k: Add missing breaks in switch/case

Signed-off-by: Joe Perches <[email protected]>
---
drivers/net/wireless/ath/ath5k/desc.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/desc.c b/drivers/net/wireless/ath/ath5k/desc.c
index 62172d5..f82383b 100644
--- a/drivers/net/wireless/ath/ath5k/desc.c
+++ b/drivers/net/wireless/ath/ath5k/desc.c
@@ -107,10 +107,13 @@ ath5k_hw_setup_2word_tx_desc(struct ath5k_hw *ah, struct ath5k_desc *desc,
case AR5K_PKT_TYPE_BEACON:
case AR5K_PKT_TYPE_PROBE_RESP:
frame_type = AR5K_AR5210_TX_DESC_FRAME_TYPE_NO_DELAY;
+ break;
case AR5K_PKT_TYPE_PIFS:
frame_type = AR5K_AR5210_TX_DESC_FRAME_TYPE_PIFS;
+ break;
default:
frame_type = type;
+ break;
}

tx_ctl->tx_control_0 |=
--
1.7.6.131.g99019