2011-07-13 08:41:32

by Johannes Berg

[permalink] [raw]
Subject: [PATCH 06/11] b43legacy: remove wireless extensions inclusions

From: Johannes Berg <[email protected]>

linux/wireless.h and net/iw_handler.h headers are
for wireless extensions only, so mac80211 drivers
shouldn't be including them.

Signed-off-by: Johannes Berg <[email protected]>
---
drivers/net/wireless/b43legacy/b43legacy.h | 1 -
drivers/net/wireless/b43legacy/main.c | 1 -
2 files changed, 2 deletions(-)

--- a/drivers/net/wireless/b43legacy/b43legacy.h 2011-07-13 10:10:08.000000000 +0200
+++ b/drivers/net/wireless/b43legacy/b43legacy.h 2011-07-13 10:10:12.000000000 +0200
@@ -14,7 +14,6 @@
#include <linux/ssb/ssb.h>
#include <linux/ssb/ssb_driver_chipcommon.h>

-#include <linux/wireless.h>
#include <net/mac80211.h>

#include "debugfs.h"
--- a/drivers/net/wireless/b43legacy/main.c 2011-07-13 10:10:08.000000000 +0200
+++ b/drivers/net/wireless/b43legacy/main.c 2011-07-13 10:10:14.000000000 +0200
@@ -35,7 +35,6 @@
#include <linux/if_arp.h>
#include <linux/etherdevice.h>
#include <linux/firmware.h>
-#include <linux/wireless.h>
#include <linux/workqueue.h>
#include <linux/sched.h>
#include <linux/skbuff.h>




2011-07-13 14:03:04

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH 06/11] b43legacy: remove wireless extensions inclusions

On 07/13/2011 03:39 AM, Johannes Berg wrote:
> From: Johannes Berg<[email protected]>
>
> linux/wireless.h and net/iw_handler.h headers are
> for wireless extensions only, so mac80211 drivers
> shouldn't be including them.
>
> Signed-off-by: Johannes Berg<[email protected]>
> ---
> drivers/net/wireless/b43legacy/b43legacy.h | 1 -
> drivers/net/wireless/b43legacy/main.c | 1 -
> 2 files changed, 2 deletions(-)

ACKed-by: Larry Finger <[email protected]>