When rtlwifi is built for the sh4 architecture, build errors of the following
type occur. An explicit reference to <linux/io.h> should fix these. I have not
setup the cross-build environment, thus this patch is untested on that platform.
It does not cause any problems on i386 or x86_64.
v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:290: error: implicit declaration of function 'outl': 4 errors in 2 logs
v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:295: error: implicit declaration of function 'outb': 4 errors in 2 logs
v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:300: error: implicit declaration of function 'inb': 4 errors in 2 logs
v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:305: error: implicit declaration of function 'inw': 4 errors in 2 logs
Signed-off-by: Larry Finger <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
---
John,
I'm not sure where this goes. I guess that 3.2 would be OK, unless someone
actually tries to build it on sh4. The only time I have seen the errors is
in Geert's listing of errors and warnings.
Larry
---
Index: linux-2.6/drivers/net/wireless/rtlwifi/pci.h
===================================================================
--- linux-2.6.orig/drivers/net/wireless/rtlwifi/pci.h
+++ linux-2.6/drivers/net/wireless/rtlwifi/pci.h
@@ -31,6 +31,7 @@
#define __RTL_PCI_H__
#include <linux/pci.h>
+#include <linux/io.h>
/*
1: MSDU packet queue,
2: Rx Command Queue
On 08/02/2011 03:20 PM, Felix Fietkau wrote:
> On 2011-08-02 9:54 PM, Larry Finger wrote:
>> When rtlwifi is built for the sh4 architecture, build errors of the following
>> type occur. An explicit reference to<linux/io.h> should fix these. I have not
>> setup the cross-build environment, thus this patch is untested on that platform.
>> It does not cause any problems on i386 or x86_64.
>>
>> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
>> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:290: error: implicit
>> declaration of function 'outl': 4 errors in 2 logs
>> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
>> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:295: error: implicit
>> declaration of function 'outb': 4 errors in 2 logs
>> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
>> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:300: error: implicit
>> declaration of function 'inb': 4 errors in 2 logs
>> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
>> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:305: error: implicit
>> declaration of function 'inw': 4 errors in 2 logs
>>
>> Signed-off-by: Larry Finger<[email protected]>
>> Cc: Geert Uytterhoeven<[email protected]>
>> ---
>>
>> John,
>>
>> I'm not sure where this goes. I guess that 3.2 would be OK, unless someone
>> actually tries to build it on sh4. The only time I have seen the errors is
>> in Geert's listing of errors and warnings.
> I looked at the code that uses raw port access, and it looks to me like this is
> just a bunch of x86 specific hacks to mess with the ASPM settings of the PCI
> bridge. This code should probably be either #ifdef'd, removed or rewritten. I
> doubt it'll work properly on other architectures.
Thanks Felix.
John,
I'll take another look at this. Please drop the patch.
Larry
On 2011-08-02 9:54 PM, Larry Finger wrote:
> When rtlwifi is built for the sh4 architecture, build errors of the following
> type occur. An explicit reference to<linux/io.h> should fix these. I have not
> setup the cross-build environment, thus this patch is untested on that platform.
> It does not cause any problems on i386 or x86_64.
>
> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:290: error: implicit declaration of function 'outl': 4 errors in 2 logs
> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:295: error: implicit declaration of function 'outb': 4 errors in 2 logs
> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:300: error: implicit declaration of function 'inb': 4 errors in 2 logs
> v3.0/sh4/sh-allmodconfig v3.0/sh4/sh-allyesconfig
> src/drivers/net/wireless/rtlwifi/rtl8192c/../pci.h:305: error: implicit declaration of function 'inw': 4 errors in 2 logs
>
> Signed-off-by: Larry Finger<[email protected]>
> Cc: Geert Uytterhoeven<[email protected]>
> ---
>
> John,
>
> I'm not sure where this goes. I guess that 3.2 would be OK, unless someone
> actually tries to build it on sh4. The only time I have seen the errors is
> in Geert's listing of errors and warnings.
I looked at the code that uses raw port access, and it looks to me like
this is just a bunch of x86 specific hacks to mess with the ASPM
settings of the PCI bridge. This code should probably be either
#ifdef'd, removed or rewritten. I doubt it'll work properly on other
architectures.
- Felix