Subject: [PATCH] ath6kl: Include scatterlist.h in hif.h to fix compilation error

drivers/net/wireless/ath/ath6kl/hif.h:194: error: array type has incomplete element type
commit b7f080cfe223b3b7424872639d153695615a9255 exposes this issue. scatterlist.h used to
get included from dma-mapping.h<-dmaengine.h<-skbuff.h.

Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
---
drivers/net/wireless/ath/ath6kl/hif.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/hif.h b/drivers/net/wireless/ath/ath6kl/hif.h
index 465876f..abd8798 100644
--- a/drivers/net/wireless/ath/ath6kl/hif.h
+++ b/drivers/net/wireless/ath/ath6kl/hif.h
@@ -19,6 +19,7 @@

#include "common.h"
#include "core.h"
+#include <linux/scatterlist.h>

#define BUS_REQUEST_MAX_NUM 64
#define HIF_MBOX_BLOCK_SIZE 128
--
1.7.0.4



2011-08-09 13:58:32

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath6kl: Include scatterlist.h in hif.h to fix compilation error

On 08/09/2011 02:27 PM, Vasanthakumar Thiagarajan wrote:
> drivers/net/wireless/ath/ath6kl/hif.h:194: error: array type has incomplete element type
> commit b7f080cfe223b3b7424872639d153695615a9255 exposes this issue. scatterlist.h used to
> get included from dma-mapping.h<-dmaengine.h<-skbuff.h.

Thanks for the patch. I noticed the same when creating the ath6kl git
tree and I have fixed with a similar patch there. I'm planning to make
that tree available later today.

Kalle