2011-11-15 08:45:16

by Raja Mani

Subject: [PATCH] ath6kl: Clear WPS ctrl flag if zero length IE is received from CFG

Connect control flag CONNECT_WPS_FLAG has to be cleared
by default even if the driver receives zero length IE
from CFG.

Otherwise this flag would be always set after WPS exchange
which would lead wpa_supplicant to fail to connect with
the received WPS credentials. This issue is observed only
in OPEN security.

Signed-off-by: Raja Mani <[email protected]>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 6da5c9e..b99cdc9 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -427,7 +427,8 @@ static int ath6kl_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
status = ath6kl_set_assoc_req_ies(vif, sme->ie, sme->ie_len);
if (status)
return status;
- }
+ } else
+ ar->connect_ctrl_flags &= ~CONNECT_WPS_FLAG;

if (test_bit(CONNECTED, &vif->flags) &&
vif->ssid_len == sme->ssid_len &&
--
1.7.0.4

2011-11-16 08:45:10

by Kalle Valo

Subject: Re: [PATCH] ath6kl: Clear WPS ctrl flag if zero length IE is received from CFG

On 11/15/2011 10:44 AM, Raja Mani wrote:
> Connect control flag CONNECT_WPS_FLAG has to be cleared
> by default even if the driver receives zero length IE
> from CFG.
>
> Otherwise this flag would be always set after WPS exchange
> which would lead wpa_supplicant to fail to connect with
> the received WPS credentials. This issue is observed only
> in OPEN security.

Thanks, applied. But I did a s/CFG/cfg80211/ in the commit log.

Kalle