2012-04-24 09:20:18

by Jonathan Bither

Subject: [PATCH V2] ath5k: add missing iounmap to AHB probe removal

When our driver device is removed on the AHB bus, our IO memory is never unmapped.

Signed-off-by: Jonathan Bither <[email protected]>

diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
index 8c50d9d..aec33cc 100644
--- a/drivers/net/wireless/ath/ath5k/ahb.c
+++ b/drivers/net/wireless/ath/ath5k/ahb.c
@@ -220,6 +220,7 @@ static int ath_ahb_remove(struct platform_device *pdev)
}

ath5k_deinit_ah(ah);
+ iounmap(ah->iobase);
platform_set_drvdata(pdev, NULL);
ieee80211_free_hw(hw);

2012-04-24 21:05:12

by Pavel Roskin

Subject: Re: [PATCH V2] ath5k: add missing iounmap to AHB probe removal

On Tue, 24 Apr 2012 05:20:15 -0400
Jonathan Bither <[email protected]> wrote:

> When our driver device is removed on the AHB bus, our IO memory is
> never unmapped.
>
> Signed-off-by: Jonathan Bither <[email protected]>
>
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c
> b/drivers/net/wireless/ath/ath5k/ahb.c index 8c50d9d..aec33cc 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -220,6 +220,7 @@ static int ath_ahb_remove(struct platform_device
> *pdev) }
>
> ath5k_deinit_ah(ah);
> + iounmap(ah->iobase);
> platform_set_drvdata(pdev, NULL);
> ieee80211_free_hw(hw);

Reviewed-by: Pavel Roskin <[email protected]>

--
Regards,
Pavel Roskin