Due to a missing header include, sparse generates the following warnings:
CHECK drivers/net/wireless/rtl818x/rtl8187_rfkill.c
warning: symbol 'rtl8187_rfkill_init' was not declared. Should it be static?
warning: symbol 'rtl8187_rfkill_poll' was not declared. Should it be static?
warning: symbol 'rtl8187_rfkill_exit' was not declared. Should it be static?
Signed-off-by: Larry Finger <[email protected]>
---
John,
This is 2.6.33 material.
Larry
---
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
@@ -18,6 +18,7 @@
#include <net/mac80211.h>
#include "rtl8187.h"
+#include "rtl8187_rfkill.h"
static bool rtl8187_is_radio_enabled(struct rtl8187_priv *priv)
{
--- On Mon, 9/11/09, Larry Finger <[email protected]> wrote:
> Due to a missing header include,
> sparse generates the following warnings:
>
>
> CHECK drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> warning: symbol 'rtl8187_rfkill_init' was not declared.
> Should it be static?
> warning: symbol 'rtl8187_rfkill_poll' was not declared.
> Should it be static?
> warning: symbol 'rtl8187_rfkill_exit' was not declared.
> Should it be static?
>
> Signed-off-by: Larry Finger <[email protected]>
Acked-by: Hin-Tak Leung <[email protected]>
Looks straight-forward.
> ---
>
> John,
>
> This is 2.6.33 material.
>
> Larry
> ---
>
> Index:
> wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> ===================================================================
> ---
> wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> +++
> wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> @@ -18,6 +18,7 @@
> #include <net/mac80211.h>
>
> #include "rtl8187.h"
> +#include "rtl8187_rfkill.h"
>
> static bool rtl8187_is_radio_enabled(struct rtl8187_priv
> *priv)
> {
>
Em Seg 09 Nov 2009, ?s 20:56:06, Larry Finger escreveu:
> Due to a missing header include, sparse generates the following warnings:
>
> CHECK drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> warning: symbol 'rtl8187_rfkill_init' was not declared. Should it be static?
> warning: symbol 'rtl8187_rfkill_poll' was not declared. Should it be static?
> warning: symbol 'rtl8187_rfkill_exit' was not declared. Should it be static?
>
> Signed-off-by: Larry Finger <[email protected]>
Acked-by: Herton Ronaldo Krzesinski <[email protected]>
> ---
>
> John,
>
> This is 2.6.33 material.
>
> Larry
> ---
>
> Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> +++ wireless-testing/drivers/net/wireless/rtl818x/rtl8187_rfkill.c
> @@ -18,6 +18,7 @@
> #include <net/mac80211.h>
>
> #include "rtl8187.h"
> +#include "rtl8187_rfkill.h"
>
> static bool rtl8187_is_radio_enabled(struct rtl8187_priv *priv)
> {
>
--
[]'s
Herton