When building rtl8180, the following warning occurs:
CC [M] drivers/net/wireless/rtl818x/rtl8180_dev.o
drivers/net/wireless/rtl818x/rtl8180_dev.c: In function ‘rtl8180_handle_rx’:
drivers/net/wireless/rtl818x/rtl8180_dev.c:135: warning: ‘qual’ is deprecated
(declared at include/net/mac80211.h:562)
Signed-off-by: Larry Finger <[email protected]>
---
John,
This patch has very low priority.
Larry
---
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8180_dev.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8180_dev.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8180_dev.c
@@ -132,7 +132,6 @@ static void rtl8180_handle_rx(struct iee
rx_status.antenna = (flags2 >> 15) & 1;
/* TODO: improve signal/rssi reporting */
- rx_status.qual = flags2 & 0xFF;
rx_status.signal = (flags2 >> 8) & 0x7F;
/* XXX: is this correct? */
rx_status.rate_idx = (flags >> 20) & 0xF;
On Sat, Dec 12, 2009 at 06:04:46PM -0600, Larry Finger wrote:
> When building rtl8180, the following warning occurs:
>
> CC [M] drivers/net/wireless/rtl818x/rtl8180_dev.o
> drivers/net/wireless/rtl818x/rtl8180_dev.c: In function ‘rtl8180_handle_rx’:
> drivers/net/wireless/rtl818x/rtl8180_dev.c:135: warning: ‘qual’ is deprecated
> (declared at include/net/mac80211.h:562)
>
> Signed-off-by: Larry Finger <[email protected]>
FWIW, I think Johannes has a hunk like this in his patch to finally
remove qual.
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Sat, 2009-12-12 at 20:22 -0500, John W. Linville wrote:
> On Sat, Dec 12, 2009 at 06:04:46PM -0600, Larry Finger wrote:
> > When building rtl8180, the following warning occurs:
> >
> > CC [M] drivers/net/wireless/rtl818x/rtl8180_dev.o
> > drivers/net/wireless/rtl818x/rtl8180_dev.c: In function ‘rtl8180_handle_rx’:
> > drivers/net/wireless/rtl818x/rtl8180_dev.c:135: warning: ‘qual’ is deprecated
> > (declared at include/net/mac80211.h:562)
> >
> > Signed-off-by: Larry Finger <[email protected]>
>
> FWIW, I think Johannes has a hunk like this in his patch to finally
> remove qual.
I do, but feel free to take Larry's patch first and then ignore the hunk
in mine.
johannes