2010-02-20 19:49:12

by Larry Finger

[permalink] [raw]
Subject: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling

Some of the N PHYs need a revision in the handling of the PMU.

Signed-off-by: Larry Finger <[email protected]>
---

John,

This will be needed for some of the N PHY devices - 2.6.34 amterial.

Larry
---

V2 - Fix typo in subject line of commit message.

Index: wireless-testing/drivers/ssb/driver_chipcommon_pmu.c
===================================================================
--- wireless-testing.orig/drivers/ssb/driver_chipcommon_pmu.c
+++ wireless-testing/drivers/ssb/driver_chipcommon_pmu.c
@@ -332,6 +332,12 @@ static void ssb_pmu_pll_init(struct ssb_
case 0x5354:
ssb_pmu0_pllinit_r0(cc, crystalfreq);
break;
+ case 0x4322:
+ if (cc->pmu.rev == 2) {
+ chipco_write32(cc, SSB_CHIPCO_PLLCTL_ADDR, 0x0000000A);
+ chipco_write32(cc, SSB_CHIPCO_PLLCTL_DATA, 0x380005C0);
+ }
+ break;
default:
ssb_printk(KERN_ERR PFX
"ERROR: PLL init unknown for device %04X\n",
@@ -417,6 +423,7 @@ static void ssb_pmu_resources_init(struc

switch (bus->chip_id) {
case 0x4312:
+ case 0x4322:
/* We keep the default settings:
* min_msk = 0xCBB
* max_msk = 0x7FFFF


2010-02-21 10:49:30

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling

2010/2/20 Larry Finger <[email protected]>:
> Some of the N PHYs need a revision in the handling of the PMU.
>
> Signed-off-by: Larry Finger <[email protected]>
> ---
>
> John,
>
> This will be needed for some of the N PHY devices - 2.6.34 amterial.
>
> Larry
> ---
>
> V2 - Fix typo in subject line of commit message.

amterial you say? ;)

--
Rafał

2010-02-22 22:59:27

by Rafał Miłecki

[permalink] [raw]
Subject: Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling

2010/2/21 Larry Finger <[email protected]>:
> On 02/21/2010 04:55 AM, Johannes Berg wrote:
>> On Sun, 2010-02-21 at 11:53 +0100, Gábor Stefanik wrote:
>>> 2010/2/21 Rafał Miłecki <[email protected]>:
>>>> 2010/2/20 Larry Finger <[email protected]>:
>>>>> Some of the N PHYs need a revision in the handling of the PMU.
>>>>>
>>>>> Signed-off-by: Larry Finger <[email protected]>
>>>>> ---
>>>>>
>>>>> John,
>>>>>
>>>>> This will be needed for some of the N PHY devices - 2.6.34
>>> amterial.
>>>>>
>>>>> Larry
>>>>> ---
>>>>>
>>>>> V2 - Fix typo in subject line of commit message.
>>>>
>>>> amterial you say? ;)
>>>
>>> Taht's not prat of the cimmot megasse, it is olny a ntoe to Jhon.
>>> Deons't mtater eevn if it is cmolpelety jmulbed up.
>>
>> Geez. The patch is already in the tree anyway, with the original typo.
>
> I may be getting old and decrepit, but it's OK if the boys just want to have fun
> with me.

And now when typo-ed patch gone git... everyone will see it for ever ;) :P

--
Rafał

2010-02-21 17:12:41

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling

On 02/21/2010 04:55 AM, Johannes Berg wrote:
> On Sun, 2010-02-21 at 11:53 +0100, Gábor Stefanik wrote:
>> 2010/2/21 Rafał Miłecki <[email protected]>:
>>> 2010/2/20 Larry Finger <[email protected]>:
>>>> Some of the N PHYs need a revision in the handling of the PMU.
>>>>
>>>> Signed-off-by: Larry Finger <[email protected]>
>>>> ---
>>>>
>>>> John,
>>>>
>>>> This will be needed for some of the N PHY devices - 2.6.34
>> amterial.
>>>>
>>>> Larry
>>>> ---
>>>>
>>>> V2 - Fix typo in subject line of commit message.
>>>
>>> amterial you say? ;)
>>
>> Taht's not prat of the cimmot megasse, it is olny a ntoe to Jhon.
>> Deons't mtater eevn if it is cmolpelety jmulbed up.
>
> Geez. The patch is already in the tree anyway, with the original typo.

I may be getting old and decrepit, but it's OK if the boys just want to have fun
with me.

Larry

2010-02-21 10:53:53

by Gábor Stefanik

[permalink] [raw]
Subject: Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling

2010/2/21 Rafał Miłecki <[email protected]>:
> 2010/2/20 Larry Finger <[email protected]>:
>> Some of the N PHYs need a revision in the handling of the PMU.
>>
>> Signed-off-by: Larry Finger <[email protected]>
>> ---
>>
>> John,
>>
>> This will be needed for some of the N PHY devices - 2.6.34 amterial.
>>
>> Larry
>> ---
>>
>> V2 - Fix typo in subject line of commit message.
>
> amterial you say? ;)

Taht's not prat of the cimmot megasse, it is olny a ntoe to Jhon.
Deons't mtater eevn if it is cmolpelety jmulbed up.

>
> --
> Rafał
> _______________________________________________
> Bcm43xx-dev mailing list
> [email protected]
> https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
>



--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2010-02-21 10:55:24

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH V2] ssb: Add PCI ID 0x4322 to PMU handling

On Sun, 2010-02-21 at 11:53 +0100, Gábor Stefanik wrote:
> 2010/2/21 Rafał Miłecki <[email protected]>:
> > 2010/2/20 Larry Finger <[email protected]>:
> >> Some of the N PHYs need a revision in the handling of the PMU.
> >>
> >> Signed-off-by: Larry Finger <[email protected]>
> >> ---
> >>
> >> John,
> >>
> >> This will be needed for some of the N PHY devices - 2.6.34
> amterial.
> >>
> >> Larry
> >> ---
> >>
> >> V2 - Fix typo in subject line of commit message.
> >
> > amterial you say? ;)
>
> Taht's not prat of the cimmot megasse, it is olny a ntoe to Jhon.
> Deons't mtater eevn if it is cmolpelety jmulbed up.

Geez. The patch is already in the tree anyway, with the original typo.

johannes


Attachments:
signature.asc (801.00 B)
This is a digitally signed message part