2011-12-15 02:23:07

by Larry Finger

Subject: [PATCH] brcmsmac: Replace kmalloc/memset with kzalloc

In ai_attach(), space is allocated for an si_info struct. Immediately
after the allocation, routine ai_doattach() is called and that allocated
space is set to zero. As no other routine calls ai_doattach(), kzalloc()
can be utilized.

Signed-off-by: Larry Finger <[email protected]>
---

John,

This is 3.3 material.

Larry
---

Index: wireless-testing-new/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
===================================================================
--- wireless-testing-new.orig/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
+++ wireless-testing-new/drivers/net/wireless/brcm80211/brcmsmac/aiutils.c
@@ -565,8 +565,6 @@ static struct si_info *ai_doattach(struc
struct bcma_device *cc;
uint socitype;

- memset((unsigned char *) sii, 0, sizeof(struct si_info));
-
savewin = 0;

sii->icbus = pbus;
@@ -677,7 +675,7 @@ ai_attach(struct bcma_bus *pbus)
struct si_info *sii;

/* alloc struct si_info */
- sii = kmalloc(sizeof(struct si_info), GFP_ATOMIC);
+ sii = kzalloc(sizeof(struct si_info), GFP_ATOMIC);
if (sii == NULL)
return NULL;

2011-12-15 11:45:34

by Arend van Spriel

Subject: Re: [PATCH] brcmsmac: Replace kmalloc/memset with kzalloc

On 12/15/2011 03:23 AM, Larry Finger wrote:
> In ai_attach(), space is allocated for an si_info struct. Immediately
> after the allocation, routine ai_doattach() is called and that allocated
> space is set to zero. As no other routine calls ai_doattach(), kzalloc()
> can be utilized.
>

Acked-by: Arend van Spriel <[email protected]>

> Signed-off-by: Larry Finger <[email protected]>
> ---
>
> John,
>
> This is 3.3 material.
>
> Larry

Thanks, Larry

Gr. AvS