From: Janakiram Sistla <[email protected]>
Adding radio type FM in RFKILL_TYPE_.FM belongs to
same class of with both TX/RX capability
Signed-off-by: Janakiram Sistla <[email protected]>
---
include/linux/rfkill.h | 2 ++
net/rfkill/core.c | 2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..7ae75ef 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -35,6 +35,7 @@
* @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
* @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
* @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
+ * @RFKILL_TYPE_FM: switch is on a wireless FM device.
* @NUM_RFKILL_TYPES: number of defined rfkill types
*/
enum rfkill_type {
@@ -44,6 +45,7 @@ enum rfkill_type {
RFKILL_TYPE_UWB,
RFKILL_TYPE_WIMAX,
RFKILL_TYPE_WWAN,
+ RFKILL_TYPE_FM,
RFKILL_TYPE_GPS,
NUM_RFKILL_TYPES,
};
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ba2efb9..61b716e 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum rfkill_type type)
return "wimax";
case RFKILL_TYPE_WWAN:
return "wwan";
+ case RFKILL_TYPE_FM:
+ return "fm";
case RFKILL_TYPE_GPS:
return "gps";
default:
--
1.5.4.3
I will be resending this patch ...sorry subjet line missing in this
sorry about that
Regards,
Ram.
On Wed, Nov 18, 2009 at 7:20 AM, Janakiram Sistla
<[email protected]> wrote:
> From: Janakiram Sistla <[email protected]>
>
> Adding radio type FM in RFKILL_TYPE_.FM belongs to
> same class of with both TX/RX capability
>
> Signed-off-by: Janakiram Sistla <[email protected]>
> ---
> ?include/linux/rfkill.h | ? ?2 ++
> ?net/rfkill/core.c ? ? ?| ? ?2 ++
> ?2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..7ae75ef 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -35,6 +35,7 @@
> ?* @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
> ?* @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> ?* @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
> ?* @NUM_RFKILL_TYPES: number of defined rfkill types
> ?*/
> ?enum rfkill_type {
> @@ -44,6 +45,7 @@ enum rfkill_type {
> ? ? ? ?RFKILL_TYPE_UWB,
> ? ? ? ?RFKILL_TYPE_WIMAX,
> ? ? ? ?RFKILL_TYPE_WWAN,
> + ? ? ? RFKILL_TYPE_FM,
> ? ? ? ?RFKILL_TYPE_GPS,
> ? ? ? ?NUM_RFKILL_TYPES,
> ?};
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index ba2efb9..61b716e 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum rfkill_type type)
> ? ? ? ? ? ? ? ?return "wimax";
> ? ? ? ?case RFKILL_TYPE_WWAN:
> ? ? ? ? ? ? ? ?return "wwan";
> + ? ? ? case RFKILL_TYPE_FM:
> + ? ? ? ? ? ? ? return "fm";
> ? ? ? ?case RFKILL_TYPE_GPS:
> ? ? ? ? ? ? ? ?return "gps";
> ? ? ? ?default:
> --
> 1.5.4.3
>
>
On Wed, Nov 18, 2009 at 07:49:30PM +0530, Janakiram Sistla wrote:
> On Wed, Nov 18, 2009 at 7:14 PM, John W. Linville
> > P.S. ?Hmmm...anyone want to add a kerneldoc entry for RFKILL_TYPE_GPS?
> Can i add this ???
Sure, but please do a different patch for that. Make it the first
one, so that it can be applied even if there is still a problem with
the other patch.
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Wed, Nov 18, 2009 at 11:53:51AM +0100, Johannes Berg wrote:
> On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
>
> > ---
> > include/linux/rfkill.h | 2 ++
> > net/rfkill/core.c | 2 ++
> > 2 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > index 3392c59..7ae75ef 100644
> > --- a/include/linux/rfkill.h
> > +++ b/include/linux/rfkill.h
> > @@ -35,6 +35,7 @@
> > * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
> > * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> > * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> > + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
> > * @NUM_RFKILL_TYPES: number of defined rfkill types
> > */
> > enum rfkill_type {
> > @@ -44,6 +45,7 @@ enum rfkill_type {
> > RFKILL_TYPE_UWB,
> > RFKILL_TYPE_WIMAX,
> > RFKILL_TYPE_WWAN,
> > + RFKILL_TYPE_FM,
> > RFKILL_TYPE_GPS,
> > NUM_RFKILL_TYPES,
> > };
>
> Nice try, but no fly. This struct is ABI, you cannot add in the middle.
Ah, good point -- I think I may have inadvertently encourage this
order. :-(
It looks like you'll need the other order -- be mindful of the
BUILD_BUG_ON I pointed-out in the previous email!
John
P.S. Hmmm...anyone want to add a kerneldoc entry for RFKILL_TYPE_GPS?
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.
On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
> ---
> include/linux/rfkill.h | 2 ++
> net/rfkill/core.c | 2 ++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..7ae75ef 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -35,6 +35,7 @@
> * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
> * @NUM_RFKILL_TYPES: number of defined rfkill types
> */
> enum rfkill_type {
> @@ -44,6 +45,7 @@ enum rfkill_type {
> RFKILL_TYPE_UWB,
> RFKILL_TYPE_WIMAX,
> RFKILL_TYPE_WWAN,
> + RFKILL_TYPE_FM,
> RFKILL_TYPE_GPS,
> NUM_RFKILL_TYPES,
> };
Nice try, but no fly. This struct is ABI, you cannot add in the middle.
johannes
On Wed, Nov 18, 2009 at 4:23 PM, Johannes Berg
<[email protected]> wrote:
> On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
>
>> ---
>> ?include/linux/rfkill.h | ? ?2 ++
>> ?net/rfkill/core.c ? ? ?| ? ?2 ++
>> ?2 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> index 3392c59..7ae75ef 100644
>> --- a/include/linux/rfkill.h
>> +++ b/include/linux/rfkill.h
>> @@ -35,6 +35,7 @@
>> ? * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
>> ? * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> ? * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
>> ? * @NUM_RFKILL_TYPES: number of defined rfkill types
>> ? */
>> ?enum rfkill_type {
>> @@ -44,6 +45,7 @@ enum rfkill_type {
>> ? ? ? RFKILL_TYPE_UWB,
>> ? ? ? RFKILL_TYPE_WIMAX,
>> ? ? ? RFKILL_TYPE_WWAN,
>> + ? ? RFKILL_TYPE_FM,
>> ? ? ? RFKILL_TYPE_GPS,
>> ? ? ? NUM_RFKILL_TYPES,
>> ?};
>
> Nice try, but no fly. This struct is ABI, you cannot add in the middle.
Is it ok if i can add my change after RFKILL_TYPE_GPS.But with respect
to the change i made i also made the necessary changes in core.c.
>
> johannes
>
On Wed, Nov 18, 2009 at 7:14 PM, John W. Linville
<[email protected]> wrote:
> On Wed, Nov 18, 2009 at 11:53:51AM +0100, Johannes Berg wrote:
>> On Wed, 2009-11-18 at 07:20 +0530, Janakiram Sistla wrote:
>>
>> > ---
>> > ?include/linux/rfkill.h | ? ?2 ++
>> > ?net/rfkill/core.c ? ? ?| ? ?2 ++
>> > ?2 files changed, 4 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> > index 3392c59..7ae75ef 100644
>> > --- a/include/linux/rfkill.h
>> > +++ b/include/linux/rfkill.h
>> > @@ -35,6 +35,7 @@
>> > ? * @RFKILL_TYPE_UWB: switch is on a ultra wideband device.
>> > ? * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> > ? * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> > + * @RFKILL_TYPE_FM: switch is on a wireless FM device.
>> > ? * @NUM_RFKILL_TYPES: number of defined rfkill types
>> > ? */
>> > ?enum rfkill_type {
>> > @@ -44,6 +45,7 @@ enum rfkill_type {
>> > ? ? RFKILL_TYPE_UWB,
>> > ? ? RFKILL_TYPE_WIMAX,
>> > ? ? RFKILL_TYPE_WWAN,
>> > + ? RFKILL_TYPE_FM,
>> > ? ? RFKILL_TYPE_GPS,
>> > ? ? NUM_RFKILL_TYPES,
>> > ?};
>>
>> Nice try, but no fly. This struct is ABI, you cannot add in the middle.
>
> Ah, good point -- I think I may have inadvertently encourage this
> order. :-(
>
> It looks like you'll need the other order -- be mindful of the
> BUILD_BUG_ON I pointed-out in the previous email!
>
> John
>
> P.S. ?Hmmm...anyone want to add a kerneldoc entry for RFKILL_TYPE_GPS?
Can i add this ???
> --
> John W. Linville ? ? ? ? ? ? ? ?Someday the world will need a hero, and you
> [email protected] ? ? ? ? ? ? ? ? ?might be all we have. ?Be ready.
>
Reinette,
Thanks a lot for directing me to the right place. I will open up a new
bugreport right away!
Have a good weekend!
Vasil
===
Vasil Lalov
Sr. Systems Administrator
Chicago Public Library
On Fri, Mar 19, 2010 at 12:10 PM, reinette chatre
<[email protected]> wrote:
> On Fri, 2010-03-19 at 09:49 -0700, Vasil Lalov wrote:
>> Thanks for responding to this. I also noticed other things. It seems
>> that this Microcode SW error occurs because the wifi card is
>> overheating. When used in n-mode and there is a large file transfer,
>> the temperature of the card rises to over 62C. Soon after this, the
>> microcode error occurs and the card gets disassociated.
>>
>> Doing more research on the power vs temperature problem, I discovered
>> that other users are seeing this as well. Some have solved their
>> problem by enabling the power management for the wifi card by issuing
>
> I am not familiar with these workarounds. Could you please submit a new
> bug at http://bugzilla.intellinuxwireless.org/ or add your information
> to a bug in this system if you find one that is related?
>
> Reinette
>
>
>
>