2012-11-15 23:05:48

by Johannes Berg

[permalink] [raw]
Subject: [PATCH] lib80211: hide Kconfig symbol

From: Johannes Berg <[email protected]>

There's no need to ask the user about lib80211
since it will be selected by drivers requiring
it, hide it from Kconfig.

Signed-off-by: Johannes Berg <[email protected]>
---
net/wireless/Kconfig | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/wireless/Kconfig b/net/wireless/Kconfig
index fe4adb1..16d08b3 100644
--- a/net/wireless/Kconfig
+++ b/net/wireless/Kconfig
@@ -140,14 +140,13 @@ config CFG80211_WEXT
extensions with cfg80211-based drivers.

config LIB80211
- tristate "Common routines for IEEE802.11 drivers"
+ tristate
default n
help
This options enables a library of common routines used
by IEEE802.11 wireless LAN drivers.

- Drivers should select this themselves if needed. Say Y if
- you want this built into your kernel.
+ Drivers should select this themselves if needed.

config LIB80211_CRYPT_WEP
tristate
--
1.8.0



2012-11-16 19:01:33

by John W. Linville

[permalink] [raw]
Subject: Re: [PATCH] lib80211: hide Kconfig symbol

On Fri, Nov 16, 2012 at 12:06:20AM +0100, Johannes Berg wrote:
> From: Johannes Berg <[email protected]>
>
> There's no need to ask the user about lib80211
> since it will be selected by drivers requiring
> it, hide it from Kconfig.
>
> Signed-off-by: Johannes Berg <[email protected]>

ACK -- I'll merge it...sorry that we still have to deal with this eyesore!

--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.

2012-11-16 19:07:44

by Arend van Spriel

[permalink] [raw]
Subject: Re: [PATCH] lib80211: hide Kconfig symbol

On 11/16/2012 07:57 PM, John W. Linville wrote:
> On Fri, Nov 16, 2012 at 12:06:20AM +0100, Johannes Berg wrote:
>> From: Johannes Berg <[email protected]>
>>
>> There's no need to ask the user about lib80211
>> since it will be selected by drivers requiring
>> it, hide it from Kconfig.
>>
>> Signed-off-by: Johannes Berg <[email protected]>
>
> ACK -- I'll merge it...sorry that we still have to deal with this eyesore!
>

Now that it is hidden, it does not hurt so much :-) At least it does not
give you "eyeball cancer" (my favorite quote when going down memory lane).

Gr. AvS