2013-04-22 20:35:19

by Han Shen(沈涵)

Subject: [PATCH v2] rtl8192c:dm: Properly initialize local array and set value.

GCC 4.8 is spitting out uninitialized-variable warnings against
"drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c". This patch adds
initialization to the variable and properly sets its value.

Signed-off-by: Han Shen ([email protected])

---
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
index b793a65..34150de 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
@@ -669,7 +669,7 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
u8 thermalvalue, delta, delta_lck, delta_iqk;
long ele_a, ele_d, temp_cck, val_x, value32;
long val_y, ele_c = 0;
- u8 ofdm_index[2], ofdm_index_old[2], cck_index_old = 0;
+ u8 ofdm_index[2], ofdm_index_old[2] = {0, 0}, cck_index_old = 0;
s8 cck_index = 0;
int i;
bool is2t = IS_92C_SERIAL(rtlhal->version);
@@ -717,7 +717,7 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
for (i = 0; i < OFDM_TABLE_LENGTH; i++) {
if (ele_d == (ofdmswing_table[i] &
MASKOFDM_D)) {
-
+ ofdm_index_old[1] = (u8) i;
RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
DBG_LOUD,
"Initial pathB ele_d reg0x%x = 0x%lx, ofdm_index=0x%x\n",
--
1.8.2.1

2013-04-22 21:44:32

by Larry Finger

Subject: Re: [PATCH v2] rtl8192c:dm: Properly initialize local array and set value.

On 04/22/2013 03:35 PM, Han Shen wrote:
> GCC 4.8 is spitting out uninitialized-variable warnings against
> "drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c". This patch adds
> initialization to the variable and properly sets its value.
>
> Signed-off-by: Han Shen ([email protected])
>
> ---
> drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Larry Finger <[email protected]>

Thanks,

Larry

>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> index b793a65..34150de 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
> @@ -669,7 +669,7 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
> u8 thermalvalue, delta, delta_lck, delta_iqk;
> long ele_a, ele_d, temp_cck, val_x, value32;
> long val_y, ele_c = 0;
> - u8 ofdm_index[2], ofdm_index_old[2], cck_index_old = 0;
> + u8 ofdm_index[2], ofdm_index_old[2] = {0, 0}, cck_index_old = 0;
> s8 cck_index = 0;
> int i;
> bool is2t = IS_92C_SERIAL(rtlhal->version);
> @@ -717,7 +717,7 @@ static void rtl92c_dm_txpower_tracking_callback_thermalmeter(struct ieee80211_hw
> for (i = 0; i < OFDM_TABLE_LENGTH; i++) {
> if (ele_d == (ofdmswing_table[i] &
> MASKOFDM_D)) {
> -
> + ofdm_index_old[1] = (u8) i;
> RT_TRACE(rtlpriv, COMP_POWER_TRACKING,
> DBG_LOUD,
> "Initial pathB ele_d reg0x%x = 0x%lx, ofdm_index=0x%x\n",
>