2024-02-11 15:12:52

by Nicolas Escande

Subject: [PATCH] wifi: ath12k: remove the unused scan_events from ath12k_wmi_scan_req_arg

As done for ath11k, lets keep on cleaning up struct ath12k_wmi_scan_req_arg by
removing the unused scan_events. Also remove the underlying union & struct
construct as it isn't needed anymore. No functionnal changes.

Signed-off-by: Nicolas Escande <[email protected]>
---
drivers/net/wireless/ath/ath12k/wmi.h | 31 +++++++++++----------------
1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
index 892f21f95ee5..103462feb935 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.h
+++ b/drivers/net/wireless/ath/ath12k/wmi.h
@@ -3281,24 +3281,19 @@ struct ath12k_wmi_scan_req_arg {
u32 vdev_id;
u32 pdev_id;
enum wmi_scan_priority scan_priority;
- union {
- struct {
- u32 scan_ev_started:1,
- scan_ev_completed:1,
- scan_ev_bss_chan:1,
- scan_ev_foreign_chan:1,
- scan_ev_dequeued:1,
- scan_ev_preempted:1,
- scan_ev_start_failed:1,
- scan_ev_restarted:1,
- scan_ev_foreign_chn_exit:1,
- scan_ev_invalid:1,
- scan_ev_gpio_timeout:1,
- scan_ev_suspended:1,
- scan_ev_resumed:1;
- };
- u32 scan_events;
- };
+ u32 scan_ev_started:1,
+ scan_ev_completed:1,
+ scan_ev_bss_chan:1,
+ scan_ev_foreign_chan:1,
+ scan_ev_dequeued:1,
+ scan_ev_preempted:1,
+ scan_ev_start_failed:1,
+ scan_ev_restarted:1,
+ scan_ev_foreign_chn_exit:1,
+ scan_ev_invalid:1,
+ scan_ev_gpio_timeout:1,
+ scan_ev_suspended:1,
+ scan_ev_resumed:1;
u32 dwell_time_active;
u32 dwell_time_active_2g;
u32 dwell_time_passive;
--
2.43.0

2024-02-12 19:15:02

by Jeff Johnson

Subject: Re: [PATCH] wifi: ath12k: remove the unused scan_events from ath12k_wmi_scan_req_arg

On 2/11/2024 7:11 AM, Nicolas Escande wrote:
> As done for ath11k, lets keep on cleaning up struct ath12k_wmi_scan_req_arg by
> removing the unused scan_events. Also remove the underlying union & struct
> construct as it isn't needed anymore. No functionnal changes.
>
> Signed-off-by: Nicolas Escande <[email protected]>
Acked-by: Jeff Johnson <[email protected]>

2024-02-14 08:18:31

by Kalle Valo

Subject: Re: [PATCH] wifi: ath12k: remove the unused scan_events from ath12k_wmi_scan_req_arg

Nicolas Escande <[email protected]> wrote:

> As done for ath11k, lets keep on cleaning up struct ath12k_wmi_scan_req_arg by
> removing the unused scan_events. Also remove the underlying union & struct
> construct as it isn't needed anymore. No functionnal changes.
>
> Signed-off-by: Nicolas Escande <[email protected]>
> Acked-by: Jeff Johnson <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

f0024c980df2 wifi: ath12k: remove the unused scan_events from ath12k_wmi_scan_req_arg

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches