2013-11-14 05:54:29

by Kevin Lo

Subject: [PATCH] rt2x00: rt2800lib: no need to write RF register 3 twice for RT5592

In rt2800_init_rfcsr_5592(), there's no need to write RF register 3 twice.

Signed-off-by: Kevin Lo <[email protected]>
---

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 776aff3..18506f8 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -6602,7 +6602,6 @@ static void rt2800_init_rfcsr_5592(struct rt2x00_dev *rt2x00dev)

rt2800_rfcsr_write(rt2x00dev, 1, 0x3F);
rt2800_rfcsr_write(rt2x00dev, 3, 0x08);
- rt2800_rfcsr_write(rt2x00dev, 3, 0x08);
rt2800_rfcsr_write(rt2x00dev, 5, 0x10);
rt2800_rfcsr_write(rt2x00dev, 6, 0xE4);
rt2800_rfcsr_write(rt2x00dev, 7, 0x00);

2013-11-14 16:42:37

by Gertjan van Wingerde

Subject: Re: [rt2x00-users] [PATCH] rt2x00: rt2800lib: no need to write RF register 3 twice for RT5592

On 11/14/13 06:53, Kevin Lo wrote:
> In rt2800_init_rfcsr_5592(), there's no need to write RF register 3 twice.
>
> Signed-off-by: Kevin Lo <[email protected]>

Acked-by: Gertjan van Wingerde <[email protected]>

> ---
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 776aff3..18506f8 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -6602,7 +6602,6 @@ static void rt2800_init_rfcsr_5592(struct rt2x00_dev *rt2x00dev)
>
> rt2800_rfcsr_write(rt2x00dev, 1, 0x3F);
> rt2800_rfcsr_write(rt2x00dev, 3, 0x08);
> - rt2800_rfcsr_write(rt2x00dev, 3, 0x08);
> rt2800_rfcsr_write(rt2x00dev, 5, 0x10);
> rt2800_rfcsr_write(rt2x00dev, 6, 0xE4);
> rt2800_rfcsr_write(rt2x00dev, 7, 0x00);
>
> _______________________________________________
> users mailing list
> [email protected]
> http://rt2x00.serialmonkey.com/mailman/listinfo/users_rt2x00.serialmonkey.com
>


--
---
Gertjan