2014-01-25 23:23:47

by Connor Behan

[permalink] [raw]
Subject: [PATCH] Remove executable permissions from firmware files

We should change these permissions unless there is a reason to keep them
executable.

Signed-off-by: Connor Behan <[email protected]>
---
ar3k/AthrBT_0x41020000.dfu | Bin
ar3k/ramps_0x41020000_40.dfu | Bin
ar5523.bin | Bin
carl9170fw/carlfw/src/printf.c | 0
rtlwifi/rtl8723fw.bin | Bin
rtlwifi/rtl8723fw_B.bin | Bin
6 files changed, 0 insertions(+), 0 deletions(-)
mode change 100755 => 100644 ar3k/AthrBT_0x41020000.dfu
mode change 100755 => 100644 ar3k/ramps_0x41020000_40.dfu
mode change 100755 => 100644 ar5523.bin
mode change 100755 => 100644 carl9170fw/carlfw/src/printf.c
mode change 100755 => 100644 rtlwifi/rtl8723fw.bin
mode change 100755 => 100644 rtlwifi/rtl8723fw_B.bin

diff --git a/ar3k/AthrBT_0x41020000.dfu b/ar3k/AthrBT_0x41020000.dfu
old mode 100755
new mode 100644
diff --git a/ar3k/ramps_0x41020000_40.dfu b/ar3k/ramps_0x41020000_40.dfu
old mode 100755
new mode 100644
diff --git a/ar5523.bin b/ar5523.bin
old mode 100755
new mode 100644
diff --git a/carl9170fw/carlfw/src/printf.c b/carl9170fw/carlfw/src/printf.c
old mode 100755
new mode 100644
diff --git a/rtlwifi/rtl8723fw.bin b/rtlwifi/rtl8723fw.bin
old mode 100755
new mode 100644
diff --git a/rtlwifi/rtl8723fw_B.bin b/rtlwifi/rtl8723fw_B.bin
old mode 100755
new mode 100644
--
1.8.5.2



2014-01-26 00:13:13

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] Remove executable permissions from firmware files

On 01/25/2014 05:19 PM, Connor Behan wrote:
> We should change these permissions unless there is a reason to keep them
> executable.
>
> Signed-off-by: Connor Behan <[email protected]>
> ---

I have no problem with making this change. I had not done so for the rtlwifi
files as it just looks like churning the firmware.

A bigger problem is that this is not the correct place to submit patches for
linux-firmware. I do Cc linux-wireless, but the patches should also be sent to
David Woodhouse <[email protected]>, and Ben Hutchings <[email protected]>
with a Cc to [email protected].

Larry