2014-05-20 19:45:12

by John W. Linville

[permalink] [raw]
Subject: [PATCH] ath9k: fixup "ath9k_htc: fix build with disabled debug"

Apparently Oleksij's compile testing was no better than mine initially
was... :-(

Cc: Oleksij Rempel <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/ath/ath9k/htc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/htc.h b/drivers/net/wireless/ath/ath9k/htc.h
index ca801a0130e1..09a5d72f3ff5 100644
--- a/drivers/net/wireless/ath/ath9k/htc.h
+++ b/drivers/net/wireless/ath/ath9k/htc.h
@@ -378,7 +378,7 @@ void ath9k_htc_get_et_stats(struct ieee80211_hw *hw,
#define TX_QSTAT_INC(c) do { } while (0)

static inline void ath9k_htc_err_stat_rx(struct ath9k_htc_priv *priv,
- struct ath_rx_status *rs);
+ struct ath_rx_status *rs)
{
}

--
1.9.0



2014-05-20 20:26:25

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH] ath9k: fixup "ath9k_htc: fix build with disabled debug"

Am 20.05.2014 21:38, schrieb John W. Linville:
> Apparently Oleksij's compile testing was no better than mine initially
> was... :-(

Face palm. There is really no excuse for me :(

--
Regards,
Oleksij


Attachments:
signature.asc (278.00 B)
OpenPGP digital signature

2014-05-21 05:17:50

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH] ath9k: fixup "ath9k_htc: fix build with disabled debug"

Am 20.05.2014 22:26, schrieb Oleksij Rempel:
> Am 20.05.2014 21:38, schrieb John W. Linville:
>> Apparently Oleksij's compile testing was no better than mine initially
>> was... :-(
>
> Face palm. There is really no excuse for me :(

Hi John,

i won't to create my testsystem to make at least good compile tests. Can
you share your experience? Do you use some thing like
http://jenkins-ci.org/ or have your own scripts? If scripts, can you
please share them?

--
Regards,
Oleksij


Attachments:
signature.asc (278.00 B)
OpenPGP digital signature

2014-05-22 18:00:13

by John W. Linville

[permalink] [raw]
Subject: Re: [PATCH] ath9k: fixup "ath9k_htc: fix build with disabled debug"

On Wed, May 21, 2014 at 07:17:32AM +0200, Oleksij Rempel wrote:
> Am 20.05.2014 22:26, schrieb Oleksij Rempel:
> > Am 20.05.2014 21:38, schrieb John W. Linville:
> >> Apparently Oleksij's compile testing was no better than mine initially
> >> was... :-(
> >
> > Face palm. There is really no excuse for me :(
>
> Hi John,
>
> i won't to create my testsystem to make at least good compile tests. Can
> you share your experience? Do you use some thing like
> http://jenkins-ci.org/ or have your own scripts? If scripts, can you
> please share them?

I'm not sure I have much to offer. I usually build with an
'allyesconfig' in the wireless and wireless-next trees, and with a
Fedora-like config in wireless-testing. The combination seems to
catch some things, but I'm sure there are other bad combinations that
slip through...

John
--
John W. Linville Someday the world will need a hero, and you
[email protected] might be all we have. Be ready.