2014-11-04 19:38:46

by C. McPherson

[permalink] [raw]
Subject: Vendor Namespace Question

Hello all:
I was just trying to use the latest stable backports-3.18-rc1-1 and I
noticed that there is no longer structure members in the
ieee80211_rx_status structure for Vendor namespace information? In my
backports 3.14 version I used them to add some register information to
the radiotap header in the lab. How does one use the vendor name space
without those structure members?

Thanks for you assistance
Clyde




2014-11-04 19:48:00

by Johannes Berg

[permalink] [raw]
Subject: Re: Vendor Namespace Question

On Tue, 2014-11-04 at 13:37 -0500, C. McPherson wrote:
> Hello all:
> I was just trying to use the latest stable backports-3.18-rc1-1 and I
> noticed that there is no longer structure members in the
> ieee80211_rx_status structure for Vendor namespace information? In my
> backports 3.14 version I used them to add some register information to
> the radiotap header in the lab. How does one use the vendor name space
> without those structure members?

We removed this from the Linux kernel because there was no driver using
it and we needed the space for other purposes. That said, it shouldn't
be too difficult to put it back by keeping the OUI/subtype also in the
skb->data rather than the rx_status (which is now full enough to no
longer have space for it, I believe)

johannes


2014-11-04 21:19:10

by C. McPherson

[permalink] [raw]
Subject: Re: Vendor Namespace Question

Thanks so much for the info Johannes. I did notice that rx_status was
getting full. I'll go ahead and put it in skb->data, that's a good idea.
Clyde

On 11/04/2014 02:47 PM, Johannes Berg wrote:
> On Tue, 2014-11-04 at 13:37 -0500, C. McPherson wrote:
>> Hello all:
>> I was just trying to use the latest stable backports-3.18-rc1-1 and I
>> noticed that there is no longer structure members in the
>> ieee80211_rx_status structure for Vendor namespace information? In my
>> backports 3.14 version I used them to add some register information to
>> the radiotap header in the lab. How does one use the vendor name space
>> without those structure members?
> We removed this from the Linux kernel because there was no driver using
> it and we needed the space for other purposes. That said, it shouldn't
> be too difficult to put it back by keeping the OUI/subtype also in the
> skb->data rather than the rx_status (which is now full enough to no
> longer have space for it, I believe)
>
> johannes
>
>


2014-11-06 22:31:13

by Johannes Berg

[permalink] [raw]
Subject: Re: Vendor Namespace Question

On Tue, 2014-11-04 at 15:18 -0500, C. McPherson wrote:
> Thanks so much for the info Johannes. I did notice that rx_status was
> getting full. I'll go ahead and put it in skb->data, that's a good idea.

I just sent a patch to restore vendor radiotap stuff in mac80211.

Works for me, and I might actually have a use case for it, but please
tell me if you have issues with it.

johannes


2014-11-12 20:55:34

by C. McPherson

[permalink] [raw]
Subject: Re: Vendor Namespace Question

I've been off for a while, but I will download it and use it. Thanks
Johannes!!


On 11/06/2014 05:31 PM, Johannes Berg wrote:
> On Tue, 2014-11-04 at 15:18 -0500, C. McPherson wrote:
>> Thanks so much for the info Johannes. I did notice that rx_status was
>> getting full. I'll go ahead and put it in skb->data, that's a good idea.
> I just sent a patch to restore vendor radiotap stuff in mac80211.
>
> Works for me, and I might actually have a use case for it, but please
> tell me if you have issues with it.
>
> johannes
>
>