2015-01-02 16:40:07

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] drivers:net:wireless: Add proper locking for the function, b43_op_beacon_set_tim in main.c

On 01/02/2015 01:34 AM, Nicholas Krause wrote:
> This adds proper locking for the function, b43_op_beacon_set_tim in main.c by using the mutex lock
> in the structure pointer wl, as embedded into this pointer as a mutex in order to protect against
> multiple access to the pointer wl when updating the templates for this pointer in the function,
> b43_update_templates internally in the function, b43_op_beacon_set_tim.
>
> Signed-off-by: Nicholas Krause <[email protected]>

Although this patch has already been rejected, I want to comment on the subject
you have chosen. As you are submitting it to the maintainer of
drivers/net/wireless/, there is no need to place those entities in the subject.
A better subject would have been "b43: Add proper locking for
b43_op_beacon_set_tim()".

Larry