From: Johannes Berg <[email protected]>
This patch adds fix to set carrier state off during ndo_open.
Carrier should be set to ON when device is ready to send data.
In case of station/adhoc interface device is able to transfer
data after successful association/join operation.
For AP this would be after bss_active event.
Signed-off-by: Johannes Berg <[email protected]>
Signed-off-by: Avinash Patil <[email protected]>
---
drivers/net/wireless/mwifiex/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
index effea6e..48e7c63 100644
--- a/drivers/net/wireless/mwifiex/main.c
+++ b/drivers/net/wireless/mwifiex/main.c
@@ -562,7 +562,8 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
static int
mwifiex_open(struct net_device *dev)
{
- netif_tx_start_all_queues(dev);
+ netif_carrier_off(dev);
+
return 0;
}
--
1.8.1.4
Hi Kalle,
Could you please mark this patch for stable as well?
Thanks,
Avinash
On Mon, 2015-01-12 at 04:24 -0800, Avinash Patil wrote:
> From: Johannes Berg <[email protected]>
>
> This patch adds fix to set carrier state off during ndo_open.
> Carrier should be set to ON when device is ready to send data.
> In case of station/adhoc interface device is able to transfer
> data after successful association/join operation.
> For AP this would be after bss_active event.
>
> Signed-off-by: Johannes Berg <[email protected]>
> Signed-off-by: Avinash Patil <[email protected]>
> ---
> drivers/net/wireless/mwifiex/main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mwifiex/main.c b/drivers/net/wireless/mwifiex/main.c
> index effea6e..48e7c63 100644
> --- a/drivers/net/wireless/mwifiex/main.c
> +++ b/drivers/net/wireless/mwifiex/main.c
> @@ -562,7 +562,8 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
> static int
> mwifiex_open(struct net_device *dev)
> {
> - netif_tx_start_all_queues(dev);
> + netif_carrier_off(dev);
> +
> return 0;
> }
>
Hi Wim,
Mwifiex is FullMac driver; we have our own thick FW for managing MLME. This is reason why we do not use mac80211.
Mwifiex is very much located under drivers/net/wireless; its not in net/wireless. net/wireless has cfg80211 driver.
Thanks,
Avinash.
________________________________________
From: [email protected] [[email protected]] On Behalf Of wim torfs [[email protected]]
Sent: Tuesday, January 13, 2015 7:04 PM
To: [email protected]
Subject: mwifiex - question
Hi,
I just noticed - from the mails passing through - that mwifiex is
located in net/wireless and that it contains its own functions besides
those of mac80211, while the description on the wiki mentions that it is
a driver for Marvell SDIO chips.
Is there any specific reason why it is not using mac80211 and why it is
located in net/wireless instead of drivers/net/wireless, or is this an
artifact of past choices that need to be cleaned up?
Thanks,
Wim.
Hi,
I just noticed - from the mails passing through - that mwifiex is
located in net/wireless and that it contains its own functions besides
those of mac80211, while the description on the wiki mentions that it is
a driver for Marvell SDIO chips.
Is there any specific reason why it is not using mac80211 and why it is
located in net/wireless instead of drivers/net/wireless, or is this an
artifact of past choices that need to be cleaned up?
Thanks,
Wim.
Avinash Patil <[email protected]> writes:
> Could you please mark this patch for stable as well?
Better that you do it, so please resend.
--
Kalle Valo
Hi Avinash,
Thanks for the clarification.
Obviously I missed the most important part of the path, which caused the
confusion.
Thanks,
Wim.
On 01/13/2015 02:44 PM, Avinash Patil wrote:
> Hi Wim,
>
> Mwifiex is FullMac driver; we have our own thick FW for managing MLME. This is reason why we do not use mac80211.
> Mwifiex is very much located under drivers/net/wireless; its not in net/wireless. net/wireless has cfg80211 driver.
>
> Thanks,
> Avinash.
> ________________________________________
> From: [email protected] [[email protected]] On Behalf Of wim torfs [[email protected]]
> Sent: Tuesday, January 13, 2015 7:04 PM
> To: [email protected]
> Subject: mwifiex - question
>
> Hi,
>
> I just noticed - from the mails passing through - that mwifiex is
> located in net/wireless and that it contains its own functions besides
> those of mac80211, while the description on the wiki mentions that it is
> a driver for Marvell SDIO chips.
>
> Is there any specific reason why it is not using mac80211 and why it is
> located in net/wireless instead of drivers/net/wireless, or is this an
> artifact of past choices that need to be cleaned up?
>
> Thanks,
> Wim.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html