Subject: [PATCH] ath10k: Add QCA99X0 to supported device list

Add vendor/device id of QCA99X0 V2.0 to pci id table and
QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for
QCA99X0 to get detected by the driver.

Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 5778e52..cc0e897 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -64,6 +64,7 @@ MODULE_PARM_DESC(reset_mode, "0: auto, 1: warm only (default: 0)");
static const struct pci_device_id ath10k_pci_id_table[] = {
{ PCI_VDEVICE(ATHEROS, QCA988X_2_0_DEVICE_ID) }, /* PCI-E QCA988X V2 */
{ PCI_VDEVICE(ATHEROS, QCA6174_2_1_DEVICE_ID) }, /* PCI-E QCA6174 V2.1 */
+ { PCI_VDEVICE(ATHEROS, QCA99X0_2_0_DEVICE_ID) }, /* PCI-E QCA99X0 V2 */
{0}
};

@@ -78,6 +79,7 @@ static const struct ath10k_pci_supp_chip ath10k_pci_supp_chips[] = {
{ QCA6174_2_1_DEVICE_ID, QCA6174_HW_3_0_CHIP_ID_REV },
{ QCA6174_2_1_DEVICE_ID, QCA6174_HW_3_1_CHIP_ID_REV },
{ QCA6174_2_1_DEVICE_ID, QCA6174_HW_3_2_CHIP_ID_REV },
+ { QCA99X0_2_0_DEVICE_ID, QCA99X0_HW_2_0_CHIP_ID_REV },
};

static void ath10k_pci_buffer_cleanup(struct ath10k *ar);
--
1.9.1



2015-07-30 14:04:54

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath10k: Add QCA99X0 to supported device list

Vasanthakumar Thiagarajan <[email protected]> writes:

> Add vendor/device id of QCA99X0 V2.0 to pci id table and
> QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for
> QCA99X0 to get detected by the driver.
>
> Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>

Thanks, applied. I just modified the commit log to make it a bit clear
that QCA99X0 is now working:

ath10k: add QCA99X0 to supported device list

Add vendor/device id of QCA99X0 V2.0 to pci id table and
QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for
QCA99X0 to get detected by the driver.

kvalo: now QCA99X0 family of chipsets is supported by ath10k. Tested
client, AP and monitor mode with QCA9990.

Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>

--
Kalle Valo

2015-08-06 18:45:45

by Peter Oh

[permalink] [raw]
Subject: Re: [PATCH] ath10k: Add QCA99X0 to supported device list


On 08/06/2015 12:59 AM, Felix Fietkau wrote:
> On 2015-08-06 09:43, Vasanthakumar Thiagarajan wrote:
>> On Wednesday 05 August 2015 05:51 PM, Felix Fietkau wrote:
>>> On 2015-07-21 13:36, Vasanthakumar Thiagarajan wrote:
>>>> Add vendor/device id of QCA99X0 V2.0 to pci id table and
>>>> QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for
>>>> QCA99X0 to get detected by the driver.
>>>>
>>>> Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
>>> I just tested a 99X0 card, and I'm getting this:
>>>
>>> [ 8.742514] ath10k_pci 0000:01:00.0: enabling device (0140 -> 0142)
>>> [ 8.747173] ath10k_pci 0000:01:00.0: pci irq msi interrupts 1
> irq_mode 0 reset_mode 0
>>> [ 11.793314] ath10k_pci 0000:01:00.0: failed to receive initialized
> event from target: 00000000
>>> [ 11.793344] ath10k_pci 0000:01:00.0: failed to wait for target after
> cold reset: -110
>>> [ 11.800814] ath10k_pci 0000:01:00.0: failed to reset chip: -110
>>> [ 11.809228] ath10k_pci: probe of 0000:01:00.0 failed with error -110
>>>
>>> This is on an AP148 board with Linux 3.18, backports generated from
>>> latest wireless-testing (2015-08-03) + all patches from kvalo's ath
>>> tree.
>> Any idea about the version of AP148 that you are using?. By any chance
> did
>> you check if QCA988X is working on the same board?.
> No idea about the version, but QCA988X is working in the same slot.
QCA99X0 uses a different version of firmware from QCA988X.
Could you verify which firmware version or file name is using?
> - Felix
>
> _______________________________________________
> ath10k mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/ath10k
Thanks,
Peter

2015-08-05 12:21:22

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] ath10k: Add QCA99X0 to supported device list

On 2015-07-21 13:36, Vasanthakumar Thiagarajan wrote:
> Add vendor/device id of QCA99X0 V2.0 to pci id table and
> QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for
> QCA99X0 to get detected by the driver.
>
> Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
I just tested a 99X0 card, and I'm getting this:

[ 8.742514] ath10k_pci 0000:01:00.0: enabling device (0140 -> 0142)
[ 8.747173] ath10k_pci 0000:01:00.0: pci irq msi interrupts 1 irq_mode 0 reset_mode 0
[ 11.793314] ath10k_pci 0000:01:00.0: failed to receive initialized event from target: 00000000
[ 11.793344] ath10k_pci 0000:01:00.0: failed to wait for target after cold reset: -110
[ 11.800814] ath10k_pci 0000:01:00.0: failed to reset chip: -110
[ 11.809228] ath10k_pci: probe of 0000:01:00.0 failed with error -110

This is on an AP148 board with Linux 3.18, backports generated from
latest wireless-testing (2015-08-03) + all patches from kvalo's ath
tree.

- Felix

Subject: Re: [PATCH] ath10k: Add QCA99X0 to supported device list

On Wednesday 05 August 2015 05:51 PM, Felix Fietkau wrote:
> On 2015-07-21 13:36, Vasanthakumar Thiagarajan wrote:
>> Add vendor/device id of QCA99X0 V2.0 to pci id table and
>> QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for
>> QCA99X0 to get detected by the driver.
>>
>> Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
> I just tested a 99X0 card, and I'm getting this:
>
> [ 8.742514] ath10k_pci 0000:01:00.0: enabling device (0140 -> 0142)
> [ 8.747173] ath10k_pci 0000:01:00.0: pci irq msi interrupts 1 irq_mode 0 reset_mode 0
> [ 11.793314] ath10k_pci 0000:01:00.0: failed to receive initialized event from target: 00000000
> [ 11.793344] ath10k_pci 0000:01:00.0: failed to wait for target after cold reset: -110
> [ 11.800814] ath10k_pci 0000:01:00.0: failed to reset chip: -110
> [ 11.809228] ath10k_pci: probe of 0000:01:00.0 failed with error -110
>
> This is on an AP148 board with Linux 3.18, backports generated from
> latest wireless-testing (2015-08-03) + all patches from kvalo's ath
> tree.

Any idea about the version of AP148 that you are using?. By any chance did
you check if QCA988X is working on the same board?.

Vasanth


2015-08-06 07:59:20

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] ath10k: Add QCA99X0 to supported device list

On 2015-08-06 09:43, Vasanthakumar Thiagarajan wrote:
> On Wednesday 05 August 2015 05:51 PM, Felix Fietkau wrote:
>> On 2015-07-21 13:36, Vasanthakumar Thiagarajan wrote:
>>> Add vendor/device id of QCA99X0 V2.0 to pci id table and
>>> QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for
>>> QCA99X0 to get detected by the driver.
>>>
>>> Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
>> I just tested a 99X0 card, and I'm getting this:
>>
>> [ 8.742514] ath10k_pci 0000:01:00.0: enabling device (0140 -> 0142)
>> [ 8.747173] ath10k_pci 0000:01:00.0: pci irq msi interrupts 1 irq_mode 0 reset_mode 0
>> [ 11.793314] ath10k_pci 0000:01:00.0: failed to receive initialized event from target: 00000000
>> [ 11.793344] ath10k_pci 0000:01:00.0: failed to wait for target after cold reset: -110
>> [ 11.800814] ath10k_pci 0000:01:00.0: failed to reset chip: -110
>> [ 11.809228] ath10k_pci: probe of 0000:01:00.0 failed with error -110
>>
>> This is on an AP148 board with Linux 3.18, backports generated from
>> latest wireless-testing (2015-08-03) + all patches from kvalo's ath
>> tree.
>
> Any idea about the version of AP148 that you are using?. By any chance did
> you check if QCA988X is working on the same board?.
No idea about the version, but QCA988X is working in the same slot.

- Felix

2015-08-06 22:00:45

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] ath10k: Add QCA99X0 to supported device list

On 2015-08-06 20:45, Peter Oh wrote:
>
> On 08/06/2015 12:59 AM, Felix Fietkau wrote:
>> On 2015-08-06 09:43, Vasanthakumar Thiagarajan wrote:
>>> On Wednesday 05 August 2015 05:51 PM, Felix Fietkau wrote:
>>>> On 2015-07-21 13:36, Vasanthakumar Thiagarajan wrote:
>>>>> Add vendor/device id of QCA99X0 V2.0 to pci id table and
>>>>> QCA99X0_HW_2_0_CHIP_ID_REV to ath10k_pci_supp_chips[] for
>>>>> QCA99X0 to get detected by the driver.
>>>>>
>>>>> Signed-off-by: Vasanthakumar Thiagarajan <[email protected]>
>>>> I just tested a 99X0 card, and I'm getting this:
>>>>
>>>> [ 8.742514] ath10k_pci 0000:01:00.0: enabling device (0140 -> 0142)
>>>> [ 8.747173] ath10k_pci 0000:01:00.0: pci irq msi interrupts 1
>> irq_mode 0 reset_mode 0
>>>> [ 11.793314] ath10k_pci 0000:01:00.0: failed to receive initialized
>> event from target: 00000000
>>>> [ 11.793344] ath10k_pci 0000:01:00.0: failed to wait for target after
>> cold reset: -110
>>>> [ 11.800814] ath10k_pci 0000:01:00.0: failed to reset chip: -110
>>>> [ 11.809228] ath10k_pci: probe of 0000:01:00.0 failed with error -110
>>>>
>>>> This is on an AP148 board with Linux 3.18, backports generated from
>>>> latest wireless-testing (2015-08-03) + all patches from kvalo's ath
>>>> tree.
>>> Any idea about the version of AP148 that you are using?. By any chance
>> did
>>> you check if QCA988X is working on the same board?.
>> No idea about the version, but QCA988X is working in the same slot.
> QCA99X0 uses a different version of firmware from QCA988X.
> Could you verify which firmware version or file name is using?
ath10k/QCA99X0/hw2.0/firmware-5.bin_10.4.1.00007-1 from git is
/lib/firmware/ath10k/QCA99X0/hw2.0/firmware-5.bin on the device.

However, this error shows up even before it gets to the point of loading
the firmware.

- Felix