2015-11-19 15:04:58

by Bob Copeland

[permalink] [raw]
Subject: [PATCH] ath5k: fix RTS/CTS by using proper rate flags

The rates in the tx control rateset do not have the protection
flags applied, so RTS/CTS would never get enabled if requested.

Fix by using the rate flags in the rates returned by
ieee80211_get_tx_rates().

Signed-off-by: Bob Copeland <[email protected]>
---
drivers/net/wireless/ath/ath5k/base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 342563a..3d946d8 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -767,7 +767,7 @@ ath5k_txbuf_setup(struct ath5k_hw *ah, struct ath5k_buf *bf,
if (info->flags & IEEE80211_TX_CTL_NO_ACK)
flags |= AR5K_TXDESC_NOACK;

- rc_flags = info->control.rates[0].flags;
+ rc_flags = bf->rates[0].flags;

hw_rate = ath5k_get_rate_hw_value(ah->hw, info, bf, 0);

--
2.1.4



2015-11-19 15:23:36

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] ath5k: fix RTS/CTS by using proper rate flags

On 2015-11-19 16:04, Bob Copeland wrote:
> The rates in the tx control rateset do not have the protection
> flags applied, so RTS/CTS would never get enabled if requested.
>
> Fix by using the rate flags in the rates returned by
> ieee80211_get_tx_rates().
>
> Signed-off-by: Bob Copeland <[email protected]>
Acked-by: Felix Fietkau <[email protected]>

2015-12-08 14:57:51

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath5k: fix RTS/CTS by using proper rate flags

Bob Copeland <[email protected]> writes:

> The rates in the tx control rateset do not have the protection
> flags applied, so RTS/CTS would never get enabled if requested.
>
> Fix by using the rate flags in the rates returned by
> ieee80211_get_tx_rates().
>
> Signed-off-by: Bob Copeland <[email protected]>

Applied, thanks.

--
Kalle Valo