2016-01-20 13:06:41

by Rafał Miłecki

Subject: [PATCH] brcmfmac: advertise frames supported for TX in AP mode

Callback mgmt_tx implementation supports both: PROBE_RESP and ACTION.

Signed-off-by: Rafał Miłecki <[email protected]>
---
This matches code I can see in brcmf_cfg80211_mgmt_tx, hope it makes
sense.
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index ab431e5..8d9cff4 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -5948,6 +5948,10 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
},
+ [NL80211_IFTYPE_AP] = {
+ .tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
+ BIT(IEEE80211_STYPE_PROBE_RESP >> 4)
+ },
[NL80211_IFTYPE_P2P_CLIENT] = {
.tx = 0xffff,
.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
--
1.8.4.5

2016-01-25 09:52:36

by Arend van Spriel

Subject: Re: [PATCH] brcmfmac: advertise frames supported for TX in AP mode

On 20-1-2016 14:06, Rafał Miłecki wrote:
> Callback mgmt_tx implementation supports both: PROBE_RESP and ACTION.
>
> Signed-off-by: Rafał Miłecki <[email protected]>
> ---
> This matches code I can see in brcmf_cfg80211_mgmt_tx, hope it makes
> sense.

As said in another response [1] this function was added for P2P
functionality. Hence I do not feel comfortable adding this patch without
subsequent testing.

Regards,
Arend

[1] http://mid.gmane.org/[email protected]

> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index ab431e5..8d9cff4 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -5948,6 +5948,10 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
> .rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
> BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
> },
> + [NL80211_IFTYPE_AP] = {
> + .tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
> + BIT(IEEE80211_STYPE_PROBE_RESP >> 4)
> + },
> [NL80211_IFTYPE_P2P_CLIENT] = {
> .tx = 0xffff,
> .rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
>

2016-03-16 23:28:26

by Julian Calaby

Subject: Re: [PATCH] brcmfmac: advertise frames supported for TX in AP mode

Hi,

On Mon, Jan 25, 2016 at 8:52 PM, Arend van Spriel <[email protected]> wrote:
>
>
> On 20-1-2016 14:06, Rafał Miłecki wrote:
>> Callback mgmt_tx implementation supports both: PROBE_RESP and ACTION.
>>
>> Signed-off-by: Rafał Miłecki <[email protected]>
>> ---
>> This matches code I can see in brcmf_cfg80211_mgmt_tx, hope it makes
>> sense.
>
> As said in another response [1] this function was added for P2P
> functionality. Hence I do not feel comfortable adding this patch without
> subsequent testing.

Has anyone tested this yet?

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/